add task solution#6251
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all functional requirements including responsive grid layout with correct breakpoints (488px/768px/1024px), proper hover effects with 300ms transitions, correct data-qa attributes placement, semantic HTML structure, and SCSS variables/mixins usage. The code works correctly with no broken functionality. The BEM methodology issues identified (.is-active scoping and redundant .buy-button class) are methodological/style concerns rather than critical blockers since the code functions as intended. These BEM naming issues can be improved in future iterations, but they don't prevent task completion or break any required functionality.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| </a> | ||
| </li> | ||
| <li class="header__menu-item"> | ||
| <a |
There was a problem hiding this comment.
The .is-active class is defined as a standalone global class in header.scss (line 47), but according to BEM methodology, it should be a modifier of .header__menu-link. This violates BEM principle where modifiers follow the pattern block__element--modifier. Consider scoping it as .header__menu-link.is-active or .header__menu-link--active.
| <p class="card__price">$2,199</p> | ||
| </div> | ||
| <a | ||
| class="card__buy-button buy-button" |
There was a problem hiding this comment.
In the HTML, the Buy button uses both .card__buy-button (BEM element) and .buy-button (separate block) classes. However, in card.scss, only .buy-button is styled (line 86), making .card__buy-button redundant. The BEM element class .card__buy-button has no styling defined for it. Consider either using just .card__buy-button and adding styles there, or using .buy-button as a modifier.
DEMO LINK
TEST REPORT LINK
All components follow BEM and use SCSS
Repeated sizes and special colors are put to variables
Grid is used for the columns
Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
All changes on
:hoverare smoothCode follows all the Code Style Rules ❗️