Skip to content

add task solution #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggylyon wants to merge 1 commit into
base: master
Choose a base branch
from
+623 −5
Open

add task solution #6251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,8 +33,8 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://ggylyon.github.io/layout_catalog/)
- [TEST REPORT LINK](https://ggylyon.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
334 changes: 333 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,338 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<a
href="#"
class="header__logo-link"
>
<img
src="images/logo.png"
alt="Moyo"
class="header__logo-image"
/>
</a>
<nav class="header__menu">
<ul class="header__menu-list">
<li class="header__menu-item">
<a
href="#"
class="header__menu-link is-active"
>
Apple
</a>
</li>
<li class="header__menu-item">
<a
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .is-active class is defined as a standalone global class in header.scss (line 47), but according to BEM methodology, it should be a modifier of .header__menu-link. This violates BEM principle where modifiers follow the pattern block__element--modifier. Consider scoping it as .header__menu-link.is-active or .header__menu-link--active.

href="#"
class="header__menu-link"
>
Samsung
</a>
</li>
<li class="header__menu-item">
<a
href="#"
class="header__menu-link"
>
Smartphones
</a>
</li>
<li class="header__menu-item">
<a
href="#"
data-qa="nav-hover"
class="header__menu-link"
>
Laptops & Computers
</a>
</li>
<li class="header__menu-item">
<a
href="#"
class="header__menu-link"
>
Gadgets
</a>
</li>
<li class="header__menu-item">
<a
href="#"
class="header__menu-link"
>
Tablets
</a>
</li>
<li class="header__menu-item">
<a
href="#"
class="header__menu-link"
>
Photo
</a>
</li>
<li class="header__menu-item">
<a
href="#"
class="header__menu-link"
>
Video
</a>
</li>
</ul>
</nav>
</header>
<main class="main">
<section class="main__cards">
<article
class="card"
data-qa="card"
>
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a
class="card__buy-button buy-button"
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the HTML, the Buy button uses both .card__buy-button (BEM element) and .buy-button (separate block) classes. However, in card.scss, only .buy-button is styled (line 86), making .card__buy-button redundant. The BEM element class .card__buy-button has no styling defined for it. Consider either using just .card__buy-button and adding styles there, or using .buy-button as a modifier.

data-qa="card-hover"
>
Buy
</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
<article class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27&QUOT; Retina 5K Monoblock"
class="card__image"
/>
<div class="card__content">
<div class="card__title">
<p class="card__title-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</p>
<p class="card__title-code">Product code: 195434</p>
</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>
<div class="card__info">
<p>Price:</p>
<p class="card__price">$2,199</p>
</div>
<a class="card__buy-button buy-button">Buy</a>
</div>
</article>
</section>
</main>
</body>
</html>
Loading
Loading