Skip to content

Solution#2266

Open
realasdfg wants to merge 4 commits into
mate-academy:masterfrom
realasdfg:develop
Open

Solution#2266
realasdfg wants to merge 4 commits into
mate-academy:masterfrom
realasdfg:develop

Conversation

@realasdfg
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The request meets the required criteria for approval.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread app/main.py
Comment thread app/main.py
cached = {}

@wraps(func)
def wrapper(*args, **kwargs) -> Any:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kwargs parameter is accepted but never used in the cache key. If someone calls the decorated function with keyword arguments like func(a=1, b=2), the cache won't recognize it as the same call as func(1, 2). Either include kwargs in the cache key or document that keyword arguments are not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants