[AEP][medium] AEP-20260924-r3-REPO-B02: reject bad history limits - #336
Merged
Merged
Conversation
mattmre
force-pushed
the
aep/medium/AEP-20260924-BE002/api-limits
branch
from
September 24, 2026 14:43
0b93b62 to
de1fcab
Compare
mattmre
force-pushed
the
aep/medium/AEP-20260924-r3-REPO-B02/history-limit
branch
from
September 24, 2026 14:44
a2e43cf to
91ab50c
Compare
1 task
Base automatically changed from
aep/medium/AEP-20260924-BE002/api-limits
to
main
September 24, 2026 15:11
Campaign, validation, preflight, and evidence-chain history used to ignore a bad limit and return the default page. They now return HTTP 400, the same rule as /api/events.
mattmre
force-pushed
the
aep/medium/AEP-20260924-r3-REPO-B02/history-limit
branch
from
September 24, 2026 15:11
91ab50c to
fe09228
Compare
mattmre
deleted the
aep/medium/AEP-20260924-r3-REPO-B02/history-limit
branch
September 24, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Campaign, validation, preflight, and evidence-chain history return HTTP 400 when
limitis not an integer. An omitted limit keeps the route default. This commit isfe09228, replayed onto the squash of #330.Type of Change
Testing
Parent re-ran
test_history_non_integer_limit_is_400andtest_events_non_integer_limit_is_400. Ruff passed. Reviewgrok-tierb-336b-20260924probed the four handlers on a loopback server. No browser.Brutal Honesty
limit=abcstays on the default page size. That route was not this finding.a2e43cf. This score is forfe09228.EVIDENCE: history limit tests and the loopback probe on fe09228; review grok-tierb-336b-20260924
SMOKE: targeted unittest only; bash scripts/smoke.sh was not run on this branch
BHS_SELF_DRAFT: 100
BHS_SELF_DRAFT_AGENT: grok-aep-fix-20260924
BHS_TIER_B: 100
BHS_TIER_B_AGENT: grok-tierb-336b-20260924
BHS_TIER_B_SEVERITY: none
BHS_OFFICIAL: 100
CARRY_FORWARD: none
DEFERRED_SCOPE: inline timestamp stays on PR 337
LOOP_ITERATIONS: 2
OPERATOR_OVERRIDE: none