Repository navigation
Add chatId to messages_fetch query filters - #251
Merged
Merged
Conversation
sebpretzer
changed the title
isPartOf reports each message's conversation @id, but nothing accepted it back. chatId maps to Madrid's chatID predicate and composes with the other filters, so chatId plus participants returns those senders' messages in that conversation. An unknown chatId matches nothing rather than falling back to every chat.
sebpretzer
force-pushed
the
messages-fetch-chat-id
branch
from
September 27, 2026 19:40
cc7d40a to
94ae8ba
Compare
sebpretzer
marked this pull request as ready for review
September 27, 2026 19:48
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds optional chatId filtering to messages_fetch, allowing messages to be scoped to a specific conversation.
Changes:
- Adds
chatIdto the tool schema. - Validates the parameter and applies conversation ID filtering.
| File | Description |
|---|---|
App/Services/Messages.swift |
Adds chat ID parsing, validation, and message filtering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
|
Thanks, @sebpretzer! And yes, a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #245. Now that
messages_fetchreturns the conversation each message belongs to (isPartOf, including its@id), it would be good to be able to query on that@idaschatIdto isolate messages to that conversation.This will also be relevant if we add a
chats_fetchcall that would return the correctchatIdbased on criteria, but I am considering that out of scope for this PR. I will potentially follow up with another PR for that, assuming this is a direction we want to go.Let me know what you think @mattt !