v1.0.1: トリガ設定を Xbox の LT/RT 命名に統一 + バージョン表記 - #4
Merged
Conversation
- Rename ini keys EnableL2/EnableR2 -> EnableLT/EnableRT and struct fields enableL2/enableR2 -> enableLT/enableRT across Config, XFireEngine, tests. Clean break: legacy EnableL2/EnableR2 keys are no longer accepted. - Add build version v1.0.1 via CMake project VERSION, injected as integer macros XFIRE_VERSION_MAJOR/MINOR/PATCH and stringified in new Version.h. Emitted in the [STICKYINIT] diagnostic log line. Integer macros avoid the VS generator's Release-config string-macro quoting breakage. - Add version comment to XInputXFire.ini header and README ini block. - Unify LT/RT trigger naming in code comments and test diagnostics (XFireEngine.h, Config.h, xfire_unit, TestHarness, xinput_probe). BREAKING CHANGE: ini keys EnableL2/EnableR2 renamed to EnableLT/EnableRT. Configs that set EnableL2=0 to disable a trigger revert to the default (enabled) and must use EnableLT=0 / EnableRT=0 instead. Co-Authored-By: Claude <noreply@anthropic.com>
Address review findings on the v1.0.1 LT/RT rename PR: - Config.cpp: detect removed EnableL2/EnableR2 keys and emit a [CONFIG] warning (value still ignored = clean break maintained). Prevents a user's "disabled" intent from silently flipping to the default (enabled=true) on upgrade with no diagnostic trace. - Version.h: guard MAJOR/MINOR/PATCH fallbacks individually so a partial macro injection cannot yield a malformed half-version; add trailing newline. - xfire_unit.cpp: add T31 (clean break: removed keys ignored -> default true), T32/T32b (engine respects enableLT/RT=false per-trigger gate), and extend T30e to also cover EnableRT unknown-value fallback. 98 checks, 0 failed. - README.md: full XINPUT_GAMEPAD_RIGHT_SHOULDER name, version placeholder in the [STICKYINIT] doc line, and mention removed-key detection in the [CONFIG] description. - assets/XInputXFire.ini: drop trailing whitespace on a blank line. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
連射発動トリガの設定名を PlayStation 命名(L2/R2)から Xbox 命名(LT/RT)に統一し、ビルドバージョン v1.0.1 を導入します。本プロジェクトは XInput(Xbox API) ベースであるため、基本表記を Xbox 名に揃え、PS 名は対応表のみに局所化します。
変更内容
1. LT/RT 命名統一（クリーンブレイク・破壊的変更）
EnableL2/EnableR2→EnableLT/EnableRTenableL2/enableR2→enableLT/enableRT（Config.h/cpp・XFireEngine.cpp・テスト）EnableL2/EnableR2キーは受理しない（フォールバック無し）2. バージョン v1.0.1 の記録
CMakeLists.txt:project(... VERSION 1.0.1)、XFIRE_VERSION_MAJOR/MINOR/PATCHを数値マクロで注入Version.h（新規）: 数値を文字列化して"1.0.1"を構築（0.0.0フォールバック付き）exports.cpp: 起動診断ログ[STICKYINIT] version=1.0.1 ...にバージョン表示assets/XInputXFire.ini: ヘッダコメント(v1.0.1)README.md: ini ブロックにバージョンコメント、診断ログ説明にversion=追記破壊的変更（BREAKING CHANGE）
ini キー
EnableL2/EnableR2がEnableLT/EnableRTにリネームされます。旧 ini でEnableL2=0等によりトリガを無効化していた場合、新キー未設定となり既定（有効）に戻ります。EnableLT=0/EnableRT=0に書き換えてください。検証
version=1.0.1が埋め込まれフォールバック文字列無しを確認version=1.0.1埋込確認レビューポイント
EnableL2/EnableR2の旧名参照がコード全体に残っていないか（grep 済み・0件）Version.hの二段階文字列化マクロが正しく"1.0.1"を生成するか