feat: copy bundled bwrap binary for sandbox support#243
Merged
Conversation
|
🎉 This PR is included in version 3.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Kilo v7.4.0+ ships with a sandbox feature that uses Bubblewrap (bwrap) for filesystem and network isolation on Linux. The bwrap binary is bundled in the Kilo release tarball, but the Dockerfile only copies
kilo,tree-sitter, andconsole— leavingbwrapbehind. Without it, sandboxed file operations and network restrictions fail silently.Solution
Add
COPY --from=builder /tmp/bwrap /usr/local/bin/bwrapto the Dockerfile to include the bundled bwrap binary in the runtime image.Changes
Dockerfile— Added COPY line for/tmp/bwrapfrom the builder stage to/usr/local/bin/bwrapin the runtime image