Upgrade Pagy to version 43#40
Closed
an-lee wants to merge 2 commits into
Closed
Conversation
BREAKING CHANGE: Upgrade from Pagy 9.3.1 to 43.0.6
This upgrade implements the breaking changes required by Pagy 43,
which is a complete redesign of the legacy code. The changes include:
- Replace Pagy::Backend with Pagy::Method in EventsController
* The backend module has been renamed to Method in v43
- Remove Pagy::Frontend include from ApplicationHelper
* Frontend functionality is now integrated into the core and no longer
requires explicit inclusion
- Update pagy_nav helper to use new instance method syntax
* Changed from pagy_nav(@pagy) to @pagy.series_nav
* This follows the new pattern where helpers are now instance methods
on the @pagy object
- Update gemspec to require Pagy >= 43.0.6
* Updated minimum version requirement to support the new API
All changes follow the official Pagy 43 upgrade guide:
https://ddnexus.github.io/pagy/guides/upgrade-guide/
Refs: https://ddnexus.github.io/pagy/guides/upgrade-guide/
Owner
|
Thank you. Would you mind bumping the ruby version dependency? |
Contributor
|
Honestly I think we would be better off by removing the dependency on pagy. With the dependency we can end up with issues between the app required pagy version and inner performance required pagy version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Upgrade from Pagy 9.3.1 to 43.0.6
This upgrade implements the breaking changes required by Pagy 43, which is a complete redesign of the legacy code. The changes include:
Replace Pagy::Backend with Pagy::Method in EventsController
Remove Pagy::Frontend include from ApplicationHelper
Update pagy_nav helper to use new instance method syntax
pagy_nav(@pagy)to@pagy.series_nav@pagyobjectUpdate gemspec to require Pagy >= 43.0.6
All changes follow the official Pagy 43 upgrade guide: https://ddnexus.github.io/pagy/guides/upgrade-guide/
Refs: https://ddnexus.github.io/pagy/guides/upgrade-guide/