Skip to content

Upgrade Pagy to version 43 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
an-lee wants to merge 2 commits into from
Closed

Upgrade Pagy to version 43 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29613be
Upgrade Pagy to version 43
an-lee Nov 19, 2025
dded211
bump requried ruby version >= 3.2
an-lee Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:

- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1
ruby-version: 3.2
bundler-cache: true

- name: Rubocop
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/inner_performance/events_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module InnerPerformance
class EventsController < ApplicationController
include Pagy::Backend
include Pagy::Method

def index
@q = InnerPerformance::Event.all.ransack(params[:q])
Expand Down
2 changes: 0 additions & 2 deletions app/helpers/inner_performance/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

module InnerPerformance
module ApplicationHelper
include Pagy::Frontend

# Based on https://stackoverflow.com/a/45428183/552936 and
# https://datadome.co/learning-center/how-to-reduce-server-response-time/
def row_class_from_duration(duration)
Expand Down
2 changes: 1 addition & 1 deletion app/views/inner_performance/events/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@
</tbody>
</table>

<%== pagy_nav(@pagy) if @pagy.pages > 1 %>
<%== @pagy.series_nav if @pagy.pages > 1 %>
4 changes: 3 additions & 1 deletion inner_performance.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ Gem::Specification.new do |spec|
spec.metadata["source_code_uri"] = "https://github.com/mbajur/inner_performance"
spec.metadata["changelog_uri"] = "https://github.com/mbajur/inner_performance"

spec.required_ruby_version = ">= 3.2"

spec.files = Dir.chdir(File.expand_path(__dir__)) do
Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
end

spec.add_dependency("activejob", ">= 7.1.5")
spec.add_dependency("pagy", ">= 9.3.1")
spec.add_dependency("pagy", ">= 43.0.6")
spec.add_dependency("rails", ">= 7.1.5")
spec.add_dependency("ransack", ">= 4.2.1")

Expand Down