Skip to content

ci: pause crates.io publishing and release assets - #424

Merged
RealiCZ merged 5 commits into
mainfrom
cz/ci/pause-crates-publish
Nov 20, 2026
Merged

RealiCZ merged 5 commits into
mainfrom
cz/ci/pause-crates-publish

Conversation

@RealiCZ

@RealiCZ RealiCZ commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two publish targets in on-release.yml fail on every release now: the crates job and the release-assets step. v1.7.3 hit both. This PR removes them and updates the docs that promised their results.

crates.io publishing is paused.

  • The six OP crates are pinned to an Optimism monorepo git revision: op-revm, alloy-op-evm, alloy-op-hardforks, op-alloy-consensus, op-alloy-network and op-alloy-rpc-types. cargo publish rejects git dependencies. See the note in the root Cargo.toml.
  • Upstream's last crates.io releases are from April and target revm 38, so they cannot replace the git pins.
  • This PR removes the crates job. To resume once those crates are on crates.io, restore it from this PR.
  • crates.io stays at 1.7.2, which predates the current hardfork schedule. README.md, bin/mega-evme/README.md and docs/mega-evme/overview.md now document two ways to install mega-evme, and note that building requires Foundry's forge:
    • from GitHub: cargo install --git https://github.com/megaeth-labs/mega-evm --locked mega-evme;
    • from a Git checkout: git clone --recursive …, then cargo install --locked --path bin/mega-evme.

Release assets are paused.

  • Releases here are now immutable once published; v1.7.3 is the first one.
  • on-release.yml runs on release: published, so release-assets fails with HTTP 422: Cannot upload assets to an immutable release. v1.7.3 has no assets for this reason, and stateless-validator v2.1.0 failed the same way.
  • This PR removes the release-assets step, together with the contents: write permission on the mega-evme job. It also removes the "Prebuilt binary" sections from README.md, bin/mega-evme/README.md and docs/mega-evme/overview.md.
  • The binary still goes to the artifact registry; that step is unchanged.
  • The lasting fix is to attach assets before the Release is published. That belongs in the shared release pipeline and is a separate change.

REVIEW.md and the bump-version-release skill are updated to match.

Test plan

  • The mega-evme job is unchanged except for the removed release-assets step and its contents: write permission. Checked by comparing the parsed workflow with main, plus actionlint and app-token-lint.
  • Both documented install ways work and report mega-evme 1.7.3:
    • cargo install --git https://github.com/megaeth-labs/mega-evm --locked mega-evme;
    • git clone --recursive https://github.com/megaeth-labs/mega-evm, then cargo install --locked --path bin/mega-evme.
  • No remaining reference to CARGO_REGISTRY_TOKEN, release-assets, SHA256SUMS or a prebuilt download outside CHANGELOG.md.
  • The next release's on-release run passes, with the artifact registry upload only.

Labels checklist

  • spec: spec:unchanged
  • comp: comp:misc
  • api: api:unchanged

The OP crates are pinned to a git revision and cargo publish rejects git dependencies, so the crates job in the release workflow could only fail. The job is removed, and the install docs now point at release tags.
Releases are immutable once published and this workflow runs after publishing, so uploading the binary to the Release fails with HTTP 422. The upload step and the prebuilt-binary docs are removed, and the binary still goes to the artifact registry.
@RealiCZ RealiCZ added spec:unchanged No change to any `mega-evm`'s behavior comp:misc Changes to the miscellaneous part of this repo api:unchanged No change to the public interface or API labels Nov 20, 2026
@mega-maxwell

mega-maxwell Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude review status

Living comment — rewritten in place. The review workflow keeps this single comment up to date instead of posting a new one each round, so it always describes the latest reviewed commit and the earlier text is intentionally gone. No reply is needed here; reply to a finding in its own review thread, and answer an open question in a reply on this PR. The next review round reconciles your answer.

✅ Review clean

Last reviewed: 27d620c9..88e253cd · updated 2026-11-20T09:41:36+00:00

New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0

@github-actions

Copy link
Copy Markdown

🧬 Mutation testing

No results at target/mutants/mutants.out — nothing was mutated (e.g. no mutatable changes).

@github-actions

Copy link
Copy Markdown

🧬 Spec-gate mutation — ✅ PASS

Nothing to test — no mutants were generated on the changed lines.

@codspeed

codspeed Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ Unable to measure the execution of 16 benchmarks

These benchmarks measured no execution time, so their results are not comparable and count as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

✅ 359 untouched benchmarks
⏩ 30 skipped benchmarks1


Comparing cz/ci/pause-crates-publish (88e253c) with main (904a621)

Open in CodSpeed

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

The README install instructions now give the plain cargo install command from the GitHub repository, without a hand-filled tag.
@RealiCZ
RealiCZ marked this pull request as draft November 20, 2026 09:16
The Installation section now lists installing from GitHub and from a Git checkout as two plain alternatives.
Sync the mega-evme overview install section and tighten wording in the release workflow, README and release skill.
@RealiCZ
RealiCZ marked this pull request as ready for review November 20, 2026 09:41
@RealiCZ
RealiCZ merged commit cfdb825 into main Nov 20, 2026
31 checks passed
@RealiCZ
RealiCZ deleted the cz/ci/pause-crates-publish branch November 20, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:unchanged No change to the public interface or API comp:misc Changes to the miscellaneous part of this repo spec:unchanged No change to any `mega-evm`'s behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants