Repository navigation
Redesign V2 operational readiness workspace - #25
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f28e32b1ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (resource.error) return <EvidenceUnavailable resource={resource} />; | ||
| const view = resource.data; | ||
| const actions = view?.actions ?? []; | ||
| const shown = actions.filter(row => filter === 'all' || row.state === filter); |
There was a problem hiding this comment.
Include closed actions in the Verified filter
When a successfully verified action advances to closed, selecting the Verified tab hides it because this predicate only accepts the literal verified state; the tab's count applies the same strict comparison. The lifecycle permits closed only after verified and requires retained successful verification (server/v2/lifecycle.ts), so closed actions are verified outcomes and should remain visible in this filter.
Useful? React with 👍 / 👎.
Scope
Redesign the actual six-section HubCyS V2 workspace around evidence-backed readiness, not a separate dashboard mockup.
Dependencies / review order
Stacked on #23 (
feat/v2-exercise-workflow), not directly on main. Review this diff for UI changes; merge #23 first and retarget/revalidate this PR against main before merging. Independent security PR #24 remains separate.No production flags, Firebase rules, data, pricing, authorization or scoring algorithms are changed. Leave this PR open and unmerged for review.
Verification
Preview boundary
The review preview uses the actual components with clearly labeled synthetic data. It cannot write to production. Create is explicitly read-only; live workspace operations require the connected application and are separately tested against local emulators. Threat recommendations and report generation are still unconnected; no fabricated readiness trends are shown.
See
docs/v2/ui-redesign.mdfor scope, QA coverage and release limitations.