Repository navigation
chore: add ecosystem records mirroring CI's checks - #137
Conversation
Add .claude/ecosystems/ records for bash, cross-cutting, markdown and yaml so /toolchain:check and /toolchain:lint run this repository's own commands instead of the bundled defaults. The records mirror the pr-require-checks workflow: shellcheck and bash -n over the two shell scripts, jq over the two JSON manifests, and the offline lychee link check pinned at 0.24.2. The markdown and yaml records run no command, because CI runs no markdownlint or actionlint here; they stop the bundled defaults from running tools CI does not run. The notes state the deviations, the checks not run locally (the pull-request contract, the result aggregation, the review lanes and the managed-files guard), and an example of a glob gap. Refs: melodic-software/claude-code-plugins#15725 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The cross-cutting note named two of the six paths lychee.toml excludes as if they were the whole list; it now cites the exclude block and gives those two as examples. It also no longer presents the missing .gitignore as a cause, since a glob input ignores .gitignore anyway. Header comments and notes cited different line ranges for the jq, shellcheck and lychee steps; both now cite the same range. Refs: melodic-software/claude-code-plugins#15725 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t comes from The cross-cutting note said every check reads the whole tree; jq reads two named files. Both records now say their file lists copy CI's and change with it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings in this pull request. The PR adds four toolchain ecosystem records under
critical-findings: 0 |
|
claude-review reviewed No findings. I compared the four new
Verifier dropped 0 of 0 candidates. |
Refs: melodic-software/claude-code-plugins#15725 ## Summary Puts the local gitleaks secret scan back into `.claude/ecosystems/cross-cutting.yaml`. The record merged in #137 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default would run for this repository. The owner had not approved removing a secret scan. ## Fix - `check-cmd` gains `gitleaks dir . --config .gitleaks.toml --no-banner --redact` as its last check; it contributes to the status like every other line. No existing check changes. - The notes state the line as a deviation from CI: no CI job here runs gitleaks. The command, version (8.30.1) and checksum are those of the gitleaks composite at melodic-software/ci-workflows v0.39.8, which this repository does not call. - `opt-in`, `install-hint` and `tool-pin` name gitleaks. - One cite into `pr-automerge-dependabot.yml` was a line short; it is corrected. ## Verification - The record validates against the ecosystem-commands schema. - `gitleaks dir` 8.30.1 over this branch's tree: no leaks found. - An independent review read every cite the change adds or moves, compared the record key by key with the version on main, and ran the command shape with stub tools: exit 0 when clean, exit 1 when gitleaks finds something, errors or is missing. READY, no blocking finding. - A probe in this worktree (a token-shaped line in a git-ignored file under `.work/`, since deleted) showed `gitleaks dir` also reads untracked and git-ignored files, as the notes say. ## Remaining Issue melodic-software/claude-code-plugins#15725 stays open after this pull request; its baseline steps and recorded `/toolchain:check all` output are still owed. Whether a record should keep other bundled checks that CI does not run (typos, for example) is an open owner question; this pull request changes only the secret scan. ## Related - #137 (the records this corrects), melodic-software/claude-code-plugins#15703 (parent) session: GitHub Support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…the cross-cutting record (#147) Refs: melodic-software/claude-code-plugins#15725 ## Summary Since #137 and #139, #145 moved the check-managed-files pin to ci-workflows v0.74.0 (`944d346`), and #144 added a header line to `pr-automerge-dependabot.yml`. The cross-cutting record's notes still named v0.71.0 and line ranges one line short. This change corrects those three citations and nothing else. ## Fix - `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`, matching `pr-check-managed-files-hosted.yml:118`. - `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and `:3-7` becomes `:3-8` (the header sentence). No command, version or checksum changes. #143 also moved the lychee-offline composite to v0.74.0. I diffed it against v0.39.8 (`594987a`): its version (0.24.2), sha256 and argument defaults are unchanged. It moved its run step into `run.sh` unchanged, and it now falls back to a bundled `lychee.toml` only when the caller has none; this repository has one. The other records' citations still hold: apart from that header line, every CI edit since #139 changed lines in place. ## Verification - Schema: `check-jsonschema --schemafile docs/contracts/ecosystem-commands/ecosystem.schema.json` (claude-code-plugins `origin/main`) over all four records printed `ok -- validation done`. - Range: from #139's merge `455a89f` to this commit, covering #140 through #146 plus this fix: 8 files (workflows, dependabot, policy.json, REVIEW.md, the record). Every tool runs with `env -C <checkout>`. Toolchain skill text is 1.4.0. - Run 1, `/toolchain:check all`, 11:38 PM to 11:39 PM EST 2026-11-15. Overall line: `Overall: PASS (1 of 1 ecosystems passed)`. | Ecosystem | Build | Test | Lint | Status | |---|---|---|---|---| | bash | — | — | pass | PASS | | markdown | — | — | — | — | - bash: `shellcheck .claude/cloud-bootstrap.sh .cursor/install.sh` and `bash -n` on each exited 0. - markdown: every command is null. - No other ecosystem's files exist. - The output contains no `skip (unresolved`. - Run noise: the first attempt ran in a clone nested under another repository. With no `.shellcheckrc` here, shellcheck took that repository's rc and reported 9 optional SC2310 infos. The record's command run from this branch's own checkout exits 0, as on CI's runner. - Run 2, `/toolchain:lint`, 11:39 PM EST. Overall line: `Overall: PASS (1 of 1 ecosystems passed)`. - cross-cutting passed: `jq empty` on both files, lychee with 0 errors, and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` with no leaks. - markdown and yaml are all null. - The installed lychee 0.24.2 and gitleaks 8.30.1 match the pins. - The verify gate passed on this commit: schema validation plus the cross-cutting check-cmd. ## Remaining melodic-software/claude-code-plugins#15725 stays open after this pull request. Its baseline steps are still owed: a `/toolchain:check all` and a `/toolchain:lint` with the bundled defaults (records removed) on one range, then the comparison of their command lists with the record runs above. This pass had a two-run budget, which went to the record runs. ## Related - #137 and #139, which merged the records this change corrects - melodic-software/claude-code-plugins#15725, melodic-software/claude-code-plugins#15703 (parent) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15725
Summary
Adds
.claude/ecosystems/records (bash, cross-cutting, markdown, yaml), so/toolchain:checkand/toolchain:lintrun what this repository's CI runs and no bundled default runs a tool CI does not.Fix
This repository's CI is inline steps in
pr-require-checks.yml. Each record copies the step it cites byfile:line; the notes state the deviations and the checks not run locally.bash.yaml: shellcheck on CI's two scripts andbash -non each, as CI's steps. CI stops at its first failure; the check runs all three commands and fails when any fails.fix-cmdis null so the bundled shfmt does not run. Notool-pin: CI uses the runner image's shellcheck.cross-cutting.yaml:jq emptyon the two JSON files CI checks, and lychee offline at CI's pinned version (0.24.2);install-hintgives the checksum CI verifies. Typos, gitleaks and editorconfig-checker are not run in CI here and get no command.markdown.yamlandyaml.yaml: enabled with every command null, which stops the bundled markdownlint and actionlint defaults; CI runs neither.There is no glob gap against CI: the workflow has no path filter, cross-cutting's globs select every file, and the bash globs select both scripts its commands read. If a
.shellcheckrcis ever synced in, a change to it alone would change CI's shellcheck result without selecting the bash record.Not run locally, each listed in notes: the pull-request contract check, the result aggregation, the two review lanes, check-managed-files.
Verification
bash -u -candzsh -c: exit 0 when all pass, exit 1 when any one command fails, every later command still run. It found one false note sentence, corrected here with its wording.bash -non both scripts,jq emptyon both files, lychee 0.24.2. The runner image's shellcheck version was not read.Remaining
Issue melodic-software/claude-code-plugins#15725 stays open after this pull request. Its done-when also asks for:
/toolchain:check alloutput for this repository that contains noskip (unresolved;Related
session: GitHub Support
🤖 Generated with Claude Code