Skip to content

ci(ci-status): yield a contract-only run to the full run instead of waiting - #68

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/yield-to-full-run
Oct 5, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/yield-to-full-run

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: ci-perf adoption of ci-workflows v0.37.0, owner-approved.

Summary

Adopt yield-to-full-run from ci-workflows v0.37.0 in pr-require-checks.yml, the shape proven in melodic-software/medley#2115. A contract-only ci-status (pull_request edited/labeled/unlabeled, every lane skipped) no longer waits up to 4 minutes on an in-flight full run: it fails at once with "superseded by full run ", the full run's own ci-status decides the gate, and on success the full run re-runs the red contract-only siblings.

Fix

  • check-contract and aggregate-results composites re-pinned to d49c4915ba75bbc9602cc30980604cad0806334e # v0.37.0.
  • aggregate-results inputs: yield-to-full-run: 'true', rerun-contract-only-siblings: 'true', carry-forward-wait-seconds: '0'. No record-pending.
  • ci-status: actions: write (was read), timeout-minutes: 3 (was 5).
  • Comments describing the old carry-forward wait updated.
  • Not changed: the sync-managed *-hosted.yml workflows (stay on v0.36.0, owned by standards). The repo has no .github/runner-policy.json and no pin-asserting tests.

Verification

  • actionlint .github/workflows/pr-require-checks.yml: clean.
  • CI on this PR; contract-only timing recorded in a comment after the full run is green.

Related

melodic-software/medley#2115, melodic-software/ci-workflows v0.37.0.

🤖 Generated with Claude Code

…aiting

Pin the pr-require-checks composites (check-contract, aggregate-results) to
ci-workflows v0.37.0 and enable yield-to-full-run and
rerun-contract-only-siblings with carry-forward-wait-seconds '0'. A
contract-only ci-status now fails at once while a full run is in flight, the
full run's ci-status decides the gate, and on success it re-runs the red
contract-only siblings. ci-status drops to timeout-minutes: 3 and gains
actions: write for the run list and rerun.

Same shape as melodic-software/medley#2115.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 5, 2026 01:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T01:26:35.639633Z 8713534 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 58s —— View job


CI code review — pr-require-checks.yml

  • Gather context (PR description, diff, CLAUDE.md/AGENTS.md)
  • Understand the request (CI code-review lane via /review:code-review)
  • Review .github/workflows/pr-require-checks.yml changes
  • Check against REVIEW.md / org criteria (security scoped to the dedicated pr-review-security-hosted.yml lane in this repo, so the permissions.actions: write grant is left to that lane)
  • Post findings

No blocking findings. This is a narrow, mechanical change (composite version bump, three new aggregate-results inputs, a permission widen, a timeout cut) and every line is accompanied by a rationale comment that matches the behavior described in the PR body:

  • check-contract / aggregate-results re-pinned to d49c4915… (v0.37.0) — consistent SHA across both.
  • actions: read → actions: write: correctly justified (write is a superset of read in GitHub's permission model, and rerun-contract-only-siblings needs the write-level re-run API).
  • timeout-minutes: 5 → 3: the old 5-minute budget had up to 4 minutes consumed by carry-forward-wait-seconds: '240', leaving ~1 minute of actual work headroom. The new 3-minute budget with carry-forward-wait-seconds: '0' leaves the full 3 minutes for actual work — strictly more headroom, not less, so the cut is safe given the new wait-free design.
  • yield-to-full-run / rerun-contract-only-siblings / carry-forward-wait-seconds: '0' are internally consistent with the updated concurrency-group commentary above the jobs block (lines 61–65), and with the dropped record-pending input the PR body calls out.

Two things I could not independently verify, flagging per the review's evidence rule rather than restating the author's claims as confirmed:

  • actionlint .github/workflows/pr-require-checks.yml — the author reports clean; I was unable to run actionlint in this environment (the tool call required approval that wasn't available), so this remains author-claimed and unverified by me.
  • The actual runtime behavior of yield-to-full-run / rerun-contract-only-siblings lives in melodic-software/ci-workflows@d49c4915… (external repo), outside this PR's diff — I reviewed only how this file wires those inputs, not the composite's internal implementation, per the lane's scope-to-changed-files rule.

@claude

claude Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 2m 5s —— View job


Security review — /review:security-review

  • Gather context
  • Run /review:security-review
  • Post findings

Scope: only the changed file, .github/workflows/pr-require-checks.yml.

Result: no security findings in this lane's scope.

What the diff does, from a trust-boundary angle:

  • The ci-status job's permissions.actions moves read → write, and the check-contract / aggregate-results composites are re-pinned v0.36.0 → v0.37.0. Both are permission-widening / supply-chain-pin concerns that this lane defers to zizmor's advisory lane, per this skill's scope — not re-reported here.
  • The new yield-to-full-run / rerun-contract-only-siblings behavior (and the actual API calls that use the widened actions: write scope) live inside the external ci-workflows composite actions at the pinned SHA, outside this PR's diff, so they're outside this review's scope ("review only the files changed in this PR").
  • The contract-only branch (and thus the actions: write grant actually taking effect) is gated on github.event.pull_request.head.repo.full_name == github.repository. For fork PRs, pull_request-triggered tokens are forced read-only by GitHub regardless of the permissions: block, so the widened scope can't be exercised by a fork PR — consistent with the inline comment at L29–32.
  • The new fail-closed semantics ("contract-only run fails at once when a full run is in-flight, full run's own ci-status decides the gate, red siblings get rerun on success") err toward blocking rather than allowing a merge, so no required-check bypass path is introduced by the logic visible in this diff.
  • No instruction/guardrail document (CLAUDE.md, AGENTS.md, rules/skill/hook files) is touched, so the instruction-surface-deletion lens doesn't apply here.

No inline comments were posted since there are no findings to anchor.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

claude-review has reviewed this pull request through 8713534; a later push is reviewed from there.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

claude-security-review has reviewed this pull request through 8713534; a later push is reviewed from there.

@kyle-sexton
kyle-sexton merged commit cee6075 into main Oct 5, 2026
13 checks passed
@kyle-sexton
kyle-sexton deleted the ci/yield-to-full-run branch October 5, 2026 01:26
kyle-sexton added a commit that referenced this pull request Oct 5, 2026
No related issue: follow-up to #68 for the draft gap found in
dotfiles#1031 and provisioning#704.

## Summary

`rerun-contract-only-siblings` is now `${{
github.event.pull_request.draft && 'false' || 'true' }}`, so a draft
full run re-runs nothing.

## Fix

One line in `.github/workflows/pr-require-checks.yml`. The repo has no
refuse-a-draft step, so the live-state draft check from the addendum
does not apply. No test asserts the input; none exists for this
workflow.

## Verification

`actionlint .github/workflows/pr-require-checks.yml`: clean. CI on this
PR.

## Related

#68, melodic-software/dotfiles#1031, melodic-software/provisioning#704.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant