Repository navigation
ci(ci-status): skip sibling re-runs from a draft full run - #69
Conversation
rerun-contract-only-siblings is now false while the pull request is a draft and true otherwise, matching dotfiles#1031 and provisioning#704. The repo has no refuse-a-draft step, so the live-state draft check does not apply. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 56s —— View job Security review (
|
|
Claude finished @kyle-sexton's task in 3m 13s —— View job Claude's code review
Scope. Single-line change: Finding posted inline ( Not re-raised as findings (noted for transparency, not blocking):
|
|
claude-security-review has reviewed this pull request through ac50554; a later push is reviewed from there. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac505544b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # the `success` and replace their red check runs. | ||
| yield-to-full-run: 'true' | ||
| rerun-contract-only-siblings: 'true' | ||
| rerun-contract-only-siblings: ${{ github.event.pull_request.draft && 'false' || 'true' }} |
There was a problem hiding this comment.
Trigger a healing run when the draft becomes ready
When a draft full run overlaps a labeled, unlabeled, or contract-only edited run, the sibling deliberately fails while yielding to the full run, but this new value prevents that full run from rerunning and healing it. Because the workflow's event types omit ready_for_review, marking the PR ready starts no replacement run, leaving the required ci-status red and blocking the merge until an unrelated push/edit/label event or manual rerun occurs; either handle ready_for_review or otherwise heal these siblings once the draft is ready.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
| # the `success` and replace their red check runs. | ||
| yield-to-full-run: 'true' | ||
| rerun-contract-only-siblings: 'true' | ||
| rerun-contract-only-siblings: ${{ github.event.pull_request.draft && 'false' || 'true' }} |
There was a problem hiding this comment.
Maintainability: this file documents the rationale for every other non-obvious conditional inline — the if: predicates, the concurrency group, yield-to-full-run, even timeout-minutes: 3 get multi-line "why" comments (e.g. lines 15-34, 41-72, 140-146 directly above this line). The new github.event.pull_request.draft && 'false' || 'true' ternary is the one conditional in the file with no explanation at all, even though the comment block right above it (140-146) walks through the adjacent yield-to-full-run mechanism in detail and says nothing about draft state.
The rationale does exist — it's in the commit message ("rerun-contract-only-siblings is now false while the pull request is a draft... matching dotfiles#1031 and provisioning#704. The repo has no refuse-a-draft step, so the live-state draft check does not apply.") — but per this file's own established convention, that belongs in an inline comment, not only in history a future reader of the YAML won't see.
|
claude-review has reviewed this pull request through ac50554; a later push is reviewed from there. |
… again (#70) ## Summary Reverts the draft-conditional `rerun-contract-only-siblings` value from #69 back to `'true'`. This repo's `pull_request` trigger omits `ready_for_review` (pr-require-checks.yml line 35), and no lane is gated on draft. A draft full run therefore runs every lane, and its sibling re-runs are safe. Skipping them on a draft can leave a yielded red contract-only `ci-status` stuck after the PR is marked ready, because nothing re-runs it. The same reasoning closed cursor-plugins#85 (Codex review P2). ## Related Follow-up to #69. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
No related issue: follow-up to #68 for the draft gap found in dotfiles#1031 and provisioning#704.
Summary
rerun-contract-only-siblingsis now${{ github.event.pull_request.draft && 'false' || 'true' }}, so a draft full run re-runs nothing.Fix
One line in
.github/workflows/pr-require-checks.yml. The repo has no refuse-a-draft step, so the live-state draft check from the addendum does not apply. No test asserts the input; none exists for this workflow.Verification
actionlint .github/workflows/pr-require-checks.yml: clean. CI on this PR.Related
#68, melodic-software/dotfiles#1031, melodic-software/provisioning#704.
🤖 Generated with Claude Code