Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-require-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
# `success` it re-runs those red contract-only runs, which then read
# the `success` and replace their red check runs.
yield-to-full-run: 'true'
rerun-contract-only-siblings: 'true'
rerun-contract-only-siblings: ${{ github.event.pull_request.draft && 'false' || 'true' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger a healing run when the draft becomes ready

When a draft full run overlaps a labeled, unlabeled, or contract-only edited run, the sibling deliberately fails while yielding to the full run, but this new value prevents that full run from rerunning and healing it. Because the workflow's event types omit ready_for_review, marking the PR ready starts no replacement run, leaving the required ci-status red and blocking the merge until an unrelated push/edit/label event or manual rerun occurs; either handle ready_for_review or otherwise heal these siblings once the draft is ready.

AGENTS.md reference: AGENTS.md:L5-L5

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainability: this file documents the rationale for every other non-obvious conditional inline — the if: predicates, the concurrency group, yield-to-full-run, even timeout-minutes: 3 get multi-line "why" comments (e.g. lines 15-34, 41-72, 140-146 directly above this line). The new github.event.pull_request.draft && 'false' || 'true' ternary is the one conditional in the file with no explanation at all, even though the comment block right above it (140-146) walks through the adjacent yield-to-full-run mechanism in detail and says nothing about draft state.

The rationale does exist — it's in the commit message ("rerun-contract-only-siblings is now false while the pull request is a draft... matching dotfiles#1031 and provisioning#704. The repo has no refuse-a-draft step, so the live-state draft check does not apply.") — but per this file's own established convention, that belongs in an inline comment, not only in history a future reader of the YAML won't see.

Fix this →

carry-forward-wait-seconds: '0'
results: ${{ join(needs.*.result, ' ') }}
# The replaced inline aggregator passed only `success`, so a `skipped`
Expand Down