Repository navigation
ci(ci-status): skip sibling re-runs from a draft full run #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,7 +144,7 @@ jobs: | |
| # `success` it re-runs those red contract-only runs, which then read | ||
| # the `success` and replace their red check runs. | ||
| yield-to-full-run: 'true' | ||
| rerun-contract-only-siblings: 'true' | ||
| rerun-contract-only-siblings: ${{ github.event.pull_request.draft && 'false' || 'true' }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maintainability: this file documents the rationale for every other non-obvious conditional inline — the The rationale does exist — it's in the commit message ("rerun-contract-only-siblings is now false while the pull request is a draft... matching dotfiles#1031 and provisioning#704. The repo has no refuse-a-draft step, so the live-state draft check does not apply.") — but per this file's own established convention, that belongs in an inline comment, not only in history a future reader of the YAML won't see. |
||
| carry-forward-wait-seconds: '0' | ||
| results: ${{ join(needs.*.result, ' ') }} | ||
| # The replaced inline aggregator passed only `success`, so a `skipped` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a draft full run overlaps a
labeled,unlabeled, or contract-onlyeditedrun, the sibling deliberately fails while yielding to the full run, but this new value prevents that full run from rerunning and healing it. Because the workflow's event types omitready_for_review, marking the PR ready starts no replacement run, leaving the requiredci-statusred and blocking the merge until an unrelated push/edit/label event or manual rerun occurs; either handleready_for_reviewor otherwise heal these siblings once the draft is ready.AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.