Skip to content

ci: remove the ci-status mirror job now that CI Status is required - #1086

Merged
kyle-sexton merged 2 commits into
mainfrom
ci/remove-ci-status-mirror
Nov 13, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
ci/remove-ci-status-mirror

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: step C of the owner-approved ci-status to CI Status required-check rename (owner decision "go w/ recommendations": remove the mirror jobs after a day of merges under the new requirement).

Summary

The org ci-gate ruleset has required CI Status since 2026-11-12T17:07Z. This removes this repository's own report-ci-status mirror job, which repeated the gate's conclusion under the old check name ci-status, and the alias-jobs: ci-status input that made the aggregate ignore it. The scheduled Dependabot queue, which read the ci-status check run that only the mirror produced, now reads CI Status.

Fix

  • .github/workflows/pr-require-checks.yml: the report-ci-status job and the alias-jobs: ci-status input with its comment are removed. The job key ci-status is unchanged.
  • .github/scripts/ci-fanout-consolidation.test.cjs: MIRROR_JOB and the assertions on the mirror job are removed with the job.
  • .github/actions/automerge-dependabot/queue.cjs: CI_STATUS is now "CI Status". Without this, pr-automerge-dependabot-queue.yml would report every in-tier Dependabot pull request as "not queued yet: ci-status ... is missing" once the mirror is gone. CI Status exists whether or not a repository still has a mirror. .github/scripts/pr-automerge-dependabot-queue.test.cjs follows.
  • AGENTS.md, README.md, check-contract/README.md, .github/dependabot.yml, and comments in pr-automerge-dependabot.yml, pr-automerge-dependabot-queue.yml and pr-review-security.yml: name CI Status as the required check.
  • Not changed: the alias-jobs input of the aggregate-results action, its run.sh and tests (pr-pipeline-sandbox and older pins elsewhere still pass it), and its README entry.

Verification

  • node --test .github/scripts/ci-fanout-consolidation.test.cjs .github/scripts/pr-automerge-dependabot-queue.test.cjs: 58 tests, 58 pass.
  • alias-jobs is optional in this repository's own aggregate-results (default: '', action.yml:268).
  • Local actionlint 1.7.12 does not parse the $/ refs and cache-mode key on main either; the repository's actionlint lane is the check.

Related

Follow-ups

These are managed by the standards sync and were left unedited; they need a melodic-software/standards change:

  • Pre-existing (advisory): .claude/rules/pr-body-contract.md says "inside ci-status"; it should name CI Status.
  • Pre-existing (advisory): REVIEW.md:89,91 name ci-status as the check a Dependabot pull request merges on.
  • Pre-existing (advisory): docs/standards/issue-tracker.md:30 names ci-status as the required check.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. Remove the `report-ci-status` mirror job and the
`alias-jobs: ci-status` input of this repository's own gate, and drop
the test assertions that pinned the mirror.

The scheduled Dependabot queue read the `ci-status` check run, which
only the mirror produced; it now reads `CI Status`, so in-tier bumps
keep being queued once the mirror is gone.

Present-tense docs and comments now name `CI Status` as the required
check. The `alias-jobs` input of the aggregate-results action is
unchanged: other repositories and older pins still pass it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T21:15:56.788105Z e79ff58 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

claude-security-review reviewed 10b9ab5f5fc9e42317e6a59a8541039935b34632: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

No security findings. critical-findings: 0

Blocking-only review (this lane already reviewed an earlier head). I read the whole incremental diff, which touches one file, .github/scripts/ci-fanout-consolidation.test.cjs. In two places a multi-line if (name === undefined || name === "ci-status" || name === ISSUE_JOB) condition is collapsed to one line. The condition has the same operands and the same logic, so the test asserts the same thing as before.

The change touches no workflow, action, token scope, trusted-actor list, kill switch or merge hold, and no plugin manifest. The earlier review of e79ff58 found nothing, and this push changes nothing it relied on.

The PR context contains no embedded instructions. The change spends no billable resources.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

claude-review reviewed 10b9ab5f5fc9e42317e6a59a8541039935b34632: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

No findings. I reviewed the incremental change since e79ff58, which touches only .github/scripts/ci-fanout-consolidation.test.cjs. It collapses two multi-line if (name === undefined || name === "ci-status" || name === ISSUE_JOB) conditions onto one line each. Both conditions are logically identical to before, so test behavior is unchanged. This is a formatting-only follow-up, matching the head commit message.

This was a blocking-only review, because the lane already reviewed an earlier head. No blocking findings exist.

  • Manifests: the diff changes no plugin manifest.
  • Closing issue: none.
  • Verification: I did not run the tests.
  • Cost: the change spends nothing and sets no hold.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit c8b96c9 Nov 13, 2026
38 checks passed
@kyle-sexton
kyle-sexton deleted the ci/remove-ci-status-mirror branch November 13, 2026 21:24
kyle-sexton added a commit to melodic-software/standards that referenced this pull request Nov 13, 2026
)

No related issue: step C of the owner-approved `ci-status` to `CI
Status` required-check rename (owner decision "go w/ recommendations":
remove the mirror jobs after a day of merges under the new requirement).

## Summary

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. This removes this repository's own `report-ci-status`
mirror job, which repeated the gate's conclusion under the old check
name `ci-status`, and the `alias-jobs: ci-status` input that made the
aggregate ignore it. Nothing distributed to other repositories changes
here.

## Fix

- `.github/workflows/pr-require-checks.yml`: the `report-ci-status` job
and the `alias-jobs: ci-status` input with its comment are removed. The
job key `ci-status` is unchanged.
- Not changed, for a separate later change: everything the sync
distributes (`components/**`, `distribution/**`, `standards/**`), the
`report-ci-status` entry in the github-actions-conventions vocabulary's
`jobNameExceptions`, `naming-lint.test.mjs:304-307`,
`components/github-actions-conventions/README.md:92-95`,
`.claude/rules/pr-body-contract.md`, `REVIEW.md`, the issue-tracker
standard and `components/dependabot-policy/policy.json`.

## Verification

- `alias-jobs` is optional in the pinned `aggregate-results` (ac4d878):
`default: ''`.
- `naming-lint.mjs --root . --mode enforcing`: 25 findings, 0 blocking
(warnings only, all pre-existing missing display names).
- `node --test
components/github-actions-conventions/naming-lint.test.mjs`: 21 tests,
21 pass.
- `actionlint` on the workflow with `.github/actionlint.yaml`: no
findings.

## Related

- Same change in claude-code-plugins:
melodic-software/claude-code-plugins#16005; ci-runner:
melodic-software/ci-runner#553; ci-workflows:
melodic-software/ci-workflows#1086.

## Follow-ups

Left unedited here; they need the later distributed-files change in this
repository:

- Pre-existing (advisory):
`components/github-actions-conventions/vocabulary.json:307` keeps the
`report-ci-status` job-name exception, pinned by
`naming-lint.test.mjs:304-307` and described in
`components/github-actions-conventions/README.md:92-95`.
- Pre-existing (advisory): `.claude/rules/pr-body-contract.md` and
`REVIEW.md` name `ci-status` as the required check.
- Pre-existing (advisory): the issue-tracker standard and
`components/dependabot-policy/policy.json` name `ci-status`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant