Skip to content

ci: remove the ci-status mirror job now that CI Status is required - #997

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror
Nov 13, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: step C of the owner-approved ci-status to CI Status required-check rename (owner decision "go w/ recommendations": remove the mirror jobs after a day of merges under the new requirement).

Summary

The org ci-gate ruleset has required CI Status since 2026-11-12T17:07Z. This removes this repository's own report-ci-status mirror job, which repeated the gate's conclusion under the old check name ci-status, and the alias-jobs: ci-status input that made the aggregate ignore it. Nothing distributed to other repositories changes here.

Fix

  • .github/workflows/pr-require-checks.yml: the report-ci-status job and the alias-jobs: ci-status input with its comment are removed. The job key ci-status is unchanged.
  • Not changed, for a separate later change: everything the sync distributes (components/**, distribution/**, standards/**), the report-ci-status entry in the github-actions-conventions vocabulary's jobNameExceptions, naming-lint.test.mjs:304-307, components/github-actions-conventions/README.md:92-95, .claude/rules/pr-body-contract.md, REVIEW.md, the issue-tracker standard and components/dependabot-policy/policy.json.

Verification

  • alias-jobs is optional in the pinned aggregate-results (ac4d878): default: ''.
  • naming-lint.mjs --root . --mode enforcing: 25 findings, 0 blocking (warnings only, all pre-existing missing display names).
  • node --test components/github-actions-conventions/naming-lint.test.mjs: 21 tests, 21 pass.
  • actionlint on the workflow with .github/actionlint.yaml: no findings.

Related

Follow-ups

Left unedited here; they need the later distributed-files change in this repository:

  • Pre-existing (advisory): components/github-actions-conventions/vocabulary.json:307 keeps the report-ci-status job-name exception, pinned by naming-lint.test.mjs:304-307 and described in components/github-actions-conventions/README.md:92-95.
  • Pre-existing (advisory): .claude/rules/pr-body-contract.md and REVIEW.md name ci-status as the required check.
  • Pre-existing (advisory): the issue-tracker standard and components/dependabot-policy/policy.json name ci-status.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. Remove this repository's own `report-ci-status`
mirror job and the `alias-jobs: ci-status` input of its gate. The
job key `ci-status` is unchanged.

Distributed files (components, distribution, the github-actions
conventions vocabulary exception and its tests, the synced rules and
standards) are left for a separate change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T21:29:41.387727Z d625bcf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed d625bcf108e7bceb77ad625d0d2e706972ffd73b: 0 finding(s), 0 as inline comments.

No findings.

The PR changes one file, .github/workflows/pr-require-checks.yml. It removes the report-ci-status mirror job and the alias-jobs: ci-status input, along with that input's comment.

  • Nothing left depends on the removed job. A repo-wide grep finds report-ci-status only in the vocabulary exception, the naming-lint test and the README. The ci-status job key, named CI Status, is unchanged at .github/workflows/pr-require-checks.yml:1037-1038. No remaining step reads needs.report-ci-status.
  • The aggregate step is still well-formed. After the edit, aggregate-results still has its other inputs (treat-skipped-as, yield-to-full-run and the rest).
  • The README already says to remove the job. components/github-actions-conventions/README.md:92-95 says each repository removes the mirror job once the ruleset requires CI Status. This PR does that.
  • The stale references are disclosed, so I did not count them. The PR body lists the jobNameExceptions entry at components/github-actions-conventions/vocabulary.json:307, the pinning test at naming-lint.test.mjs:304-307 and the README paragraph as a follow-up, to be fixed in a later change to distributed files. This is the cross-doc reconciliation AGENTS.md asks for before a normative-doc change merges. Here the stale text only describes a transitional exception, and the PR names where it will be reconciled, so I did not raise it.
  • Not checked by me. I did not run actionlint, the naming-lint tests or the pinned aggregate-results action. The PR claims that alias-jobs defaults to '' and that those checks pass. I treated both as author-claimed and unverified. I also did not check the ruleset's CI Status requirement or its 2026-11-12 date, because that needs org API access.

No closing issue exists ("No related issue: …"), so there are no acceptance criteria to check. The PR body contract is met: it has a No related issue line and the Summary, Fix, Verification and Related sections.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed d625bcf108e7bceb77ad625d0d2e706972ffd73b: 0 finding(s), 0 as inline comments.

Security review: PR #997 (head d625bcf)

No security findings. critical-findings: 0

The diff changes only .github/workflows/pr-require-checks.yml, which is a ci-status hold file. I read the whole change and what it gates.

  • Removed report-ci-status job (display name ci-status).
    • It had permissions: {} and no secrets, and only echoed needs.ci-status.result and exited non-zero unless that result was success. It was a pure mirror of the CI Status job and held no logic of its own.
    • Removing it widens nothing: no actor, token scope, secret or untrusted text is newly reachable. It adds no code to run.
    • The real gate is unchanged. The CI Status job (name: CI Status, line 1038) still runs the aggregate step with if: !cancelled() and treat-skipped-as: fail. It still lists the same needs lane results, including pr-contract, pr-scan-dependencies, test-cloud-environment and test-distribution.
    • If a ruleset still required the old ci-status context, a pull request would not merge until the ruleset changed, because the context would never report. That fails closed and is not a bypass. The ruleset is not in the diff, so I could not check it. The base commit's subject says CI Status is now the required check.
  • Removed alias-jobs: ci-status input. It told the aggregate's run-shape reads to ignore the mirror check run. With the mirror job gone, nothing carries that name. The only effect would be that a leftover check run named ci-status stops being ignored, and none can exist from this workflow. This does not weaken treat-skipped-as: fail or the aggregate's lane checks. The pinned action SHA ac4d8780… is unchanged.
  • Other trust controls: the diff touches no trusted-actor list, token request, kill switch, CODEOWNERS, .gitmodules or merge-hold script. It carries no instruction-surface deletion and no plugin manifest change, so there are no manifest lines.
  • Embedded instructions: none seen in the diff.
  • Protected-class list: I did not consult docs/contracts/instruction-exception-register/README.md, because no instruction was removed.

@kyle-sexton
kyle-sexton merged commit c5273d3 into main Nov 13, 2026
22 checks passed
@kyle-sexton
kyle-sexton deleted the ci/remove-ci-status-mirror branch November 13, 2026 21:33
kyle-sexton added a commit to melodic-software/.github that referenced this pull request Nov 14, 2026
No related issue: text follow-up to the `ci-status` mirror removal
(#245).

## Summary

`CONTRIBUTING.md` and the pull request template still named the required
check `ci-status`. The org ruleset requires `CI Status`.

## Fix

- `CONTRIBUTING.md:18` and `.github/PULL_REQUEST_TEMPLATE.md:17`: one
name each.

## Verification

- `git diff` shows two one-word changes.

## Related

- #245, melodic-software/standards#997

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant