Skip to content

Cut the model-read ecosystem specifics from tdd #16758

Open
5 of 6 issues completed
Open

Description

@kyle-sexton

Parent

Refs #15703
Source: #15730 (blind classification under rules revision 5, #15730 comment 6950077480), cut item 8 of 47 in its filing order.

Depends on

Blocks #15732 (the portability gate widens only after every cut lands).

Outcome

tdd ships no model-read tool, library or command choice outside ADR 0101's named exceptions: the 23 rows below are cut (R11 22, R4 1).

Demo: on main after the merge, each listed row's cited text is gone or replaced by generic text at a routing site, and the pull request body lists every row id with what happened to it.

Row count (bulk-mutation standard): 23 rows. The pull request states this number and lists each row.

Rows to cut

Paths are repository-relative; line numbers are as read at 5b66a7fa and may have moved. Kind is the inventory kind (K2 detection table, K3 bundled value, K4 tool guidance, K5 tool pointer, K7 example).

Row Rule Kind Cited at Fact the classifier matched Notes
F0391 R11 K7 plugins/tdd/skills/principles/SKILL.md:30 The routing keyword DateTime.Now (SKILL.md:30) is a C#-flavored example in a model-read routing row.
F0392 R11 K5 plugins/tdd/skills/principles/SKILL.md:66-72 Hypothesis, fast-check, ApprovalTests, Verify and Jest docs are cited as sources, but R9 excludes links to one ecosystem's tool documentation.
F0394 R11 K7 plugins/tdd/skills/principles/reference/test-design.md:25-192 The Beck sections carry java code fences (test-design.md:31 onward), examples written for one stack, which R9 excludes.
F0395 R11 K7 plugins/tdd/skills/principles/reference/test-design.md:206-245 The naming and Object Mother section is C#-flavored ("less boilerplate in C#"), an example written for one stack.
F0396 R11 K4 plugins/tdd/skills/principles/reference/test-design.md:247-299 The xUnit.net [Theory]/[InlineData]/[MemberData] section is model-read per-tool API guidance (K4).
F0397 R4 K5 plugins/tdd/skills/principles/reference/test-design.md:301-317 "The readability improvement is significant enough to justify the additional package in most projects" picks the Fluent Assertions library for the consumer. Two readings (other: R11). Reader's note: F0397: R11 is the other reading, if R4 is limited to bundled defaults.
F0398 R11 K7 plugins/tdd/skills/principles/reference/test-doubles.md:5-87 Beck's Mock Object, Self Shunt and Log String patterns are shown in java and python fences, examples written for one stack.
F0399 R11 K7 plugins/tdd/skills/principles/reference/test-doubles.md:116-124 Moq Times.Once and VerifyNoOtherCalls() illustrate a neutral rule (verify expected and unexpected calls) with one library's API.
F0400 R11 K7 plugins/tdd/skills/principles/reference/test-doubles.md:126-148 The one-function-per-remote-operation rule is illustrated with a TypeScript example.
F0401 R11 K7 plugins/tdd/skills/principles/reference/classical-vs-london-khorikov.md:21-60, 149 Khorikov's classical-vs-London listings are C#/Moq code, examples written for one stack.
F0402 R11 K7 plugins/tdd/skills/principles/reference/observable-behavior-khorikov.md:18-53, 99-209 The observable-behavior listings use C# and Moq Mock<T>, examples written for one stack.
F0403 R11 K7 plugins/tdd/skills/principles/reference/testing-styles-khorikov.md:20-330 The output/state/communication style listings use C#, xUnit.net, Moq and Fluent Assertions BeEquivalentTo, examples written for one stack.
F0404 R11 K7 plugins/tdd/skills/principles/reference/anti-patterns-khorikov.md:20-262 The anti-pattern listings use C#, Moq CallBase and DateTime.Now, examples written for one stack.
F0405 R11 K7 plugins/tdd/skills/principles/reference/testable-architecture-khorikov.md:62-290 The Humble Object and CanExecute/Execute listings are C#/xUnit.net code, examples written for one stack.
F0406 R11 K7 plugins/tdd/skills/principles/reference/code-coverage-khorikov.md:39-110 The coverage listings in code-coverage-khorikov.md:39-110 are C#/xUnit.net code, examples written for one stack.
F0407 R11 K7 plugins/tdd/skills/principles/reference/code-coverage-khorikov.md:128-141 The editorial note naming PIT's "test strength" and Infection's "Covered Code MSI" is model-read tool-specific naming, not a cited language-neutral source.
F0408 R11 K7 plugins/tdd/skills/principles/reference/integration-testing-khorikov.md:88-210, 353 The mocking and spy listings in integration-testing-khorikov.md use C#, Moq and xUnit.net, examples written for one stack.
F0409 R11 K7 plugins/tdd/skills/principles/reference/integration-testing-khorikov.md:239-325 The unit-of-work and DbContext listings illustrate neutral rules with EF Core/NHibernate/SQLite, examples written for one stack.
F0410 R11 K7 plugins/tdd/skills/principles/reference/four-pillars-khorikov.md:73 "Verifying SQL string literal" (four-pillars-khorikov.md:73) is a SQL-flavored example of a brittle test.
F0411 R11 K4 plugins/tdd/skills/principles/reference/property-based-testing.md:34-46, 84-85 The Shrinking section and the @example(...).xfail() line in property-based-testing.md are model-read statements about Hypothesis and fast-check behind a neutral rule (pin the shrunk input), and no earlier rule holds them.
F0412 R11 K5 plugins/tdd/skills/principles/reference/property-based-testing.md:101-130 The Sources entries for Hypothesis, fast-check, rapid, CsCheck, FsCheck, QuickCheck, the /hypothesis command and Kiro are links to tool documentation, which R9 excludes, so the row falls to model-read K5. Two readings (other: R9). Reader's note: F0412, F0414, F0432, F0434: the same lines also cite papers or author pages (Maaz, Vikram, Feathers, Seemann, Fowler's ContractTest) that would be R9 alone; the rule follows the inventoried tool-doc links.
F0413 R11 K4 plugins/tdd/skills/principles/reference/characterization-testing.md:36-50 The Golden Master section of characterization-testing.md (ApprovalTests, Verify scrubbers, Jest snapshots and property matchers) is still present, and it is model-read tool guidance behind a neutral rule.
F0414 R11 K5 plugins/tdd/skills/principles/reference/characterization-testing.md:80-94 The Sources lines for ApprovalTests, Verify, Jest and Scientist are tool-documentation links, which R9 excludes, so the row is model-read K5. Two readings (other: R9). Reader's note: F0412, F0414, F0432, F0434: the same lines also cite papers or author pages (Maaz, Vikram, Feathers, Seemann, Fowler's ContractTest) that would be R9 alone; the rule follows the inventoried tool-doc links.

Kept rows, not touched here (count per rule): R9 1.

Steps

  • List every item with its rule: the pull request body repeats the table above with each row's outcome (cut, replaced at a routing site, or kept with its reason).
  • Back every R11 call with a search showing whether a script reads the file, for example git grep -n -F '<file name>' -- plugins scripts .github, quoted in the pull request body. A row whose file a script reads is not cut here: report it on Classify the remaining guidance rows blind and count the cuts per plugin #15730.
  • Name the cases that read the cut text: in the pull request body, name for each changed skill the existing eval case whose run reads the cut text, or say that none does. The lane names them; it runs none.
  • Whole page or part: in the pull request body, say for each changed file whether the cut deletes the whole page or part of it.
  • R4 rows: the bundled default goes; the choice is resolved from the consumer through the ecosystem-resolution contract (docs/contracts/ecosystem-resolution/). A shipped default that picks a library goes with this cut.
  • Fence ratchet: lower the skill-stack-fences ceiling in .performance/ratchets.json for each of these files whose fences the cut removes: plugins/tdd/skills/principles/reference/test-design.md, plugins/tdd/skills/principles/reference/test-doubles.md, plugins/tdd/skills/principles/reference/classical-vs-london-khorikov.md, plugins/tdd/skills/principles/reference/observable-behavior-khorikov.md, plugins/tdd/skills/principles/reference/testing-styles-khorikov.md, plugins/tdd/skills/principles/reference/anti-patterns-khorikov.md, plugins/tdd/skills/principles/reference/testable-architecture-khorikov.md, plugins/tdd/skills/principles/reference/code-coverage-khorikov.md, plugins/tdd/skills/principles/reference/integration-testing-khorikov.md.
  • References outside the plugin: these files on main name a cut file; update or remove each entry the cut makes stale: plugins/tdd/skills/principles/reference/test-design.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/test-doubles.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/classical-vs-london-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/observable-behavior-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/testing-styles-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/anti-patterns-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/testable-architecture-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/code-coverage-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/integration-testing-khorikov.md in .performance/ratchets.json; plugins/tdd/skills/principles/reference/property-based-testing.md in scripts/docs-anchor-baseline.txt; plugins/tdd/skills/principles/reference/characterization-testing.md in scripts/docs-anchor-baseline.txt.
  • Open the pull request with Closes this issue in its body, then stop: the lane adds no label. A sweep adds do-not-merge and the hold line when the pull request opens; the evidence below is a host session's work.

After the pull request opens (host session, not the lane)

The lane opens the pull request and stops there. The pull request stays held with do-not-merge for the eval; a host session runs only the eval and posts its record on the pull request; the merge lane releases the hold when the record matches the head; this issue closes with the pull request.

  • Hold line: the hub's sweep (or a host session) adds do-not-merge to the pull request and posts, from a listed human's account, a comment with the line <!-- pr-hold reason=eval --> on a line of its own.
  • Targeted case per changed skill (this replaces Classify the remaining guidance rows blind and count the cuts per plugin #15730's "no more than 400 runs per plugin (the changed skills' cases on the opus and sonnet aliases, three runs per side, plus control sides on one model)"): one before-and-after case, on sonnet at 3 runs a side; opus runs only to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first (owner decision of 2026-11-16 in the owner-decisions record, superseding the run counts in #15703 comment 6906800940). Select cases with --case, use --runs 3 and a --max-cost-usd ceiling, and start no batch after a usage-limit error.
  • Controls: each whole-page deletion carries a sensitivity-control result, its predicted outcome written in the pull request body before the first batch; each partial cut carries a detection-control result. No paired no-loss compare per cut (#15703 comment 6906800940).
  • On a LOSS reading: a trace read of each dropped case and an opus confirm; only a loss traced to the changed text counts (#16672 comment 6935228111).
  • Record: the verdict and the control result go into the pull request body. When the run is VALID and shows no loss, the host session posts, from a listed human's account, a comment with the line <!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> --> naming the pull request's current head, and keeps "do not merge" and do-not-merge out of that comment (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). A loss or a run that is not VALID leaves the hold in place; say so on the pull request.
  • Release: pr-merge's scheduled step "Release eval holds whose record matches the head" (.github/scripts/pr-merge/release-eval-hold.mjs) removes do-not-merge once that record is the newest since the label went on and names the current head, and no other hold stands. A push after the record needs a new record.
  • AC7 is met here: each whole-page deletion carries a sensitivity-control result and each partial cut a detection-control result, in the pull request body.

Decisions

  • D3: each plugin's cut is its own topic and pull request.
  • Interview Q32 (D4 of the Brief): bundled defaults that pick a tool, command or library are retired wherever they appear.
  • AC1's named exceptions are the kept classes of ADR 0101 (docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment).
  • Bulk-mutation standard: count first, then act; the pull request states its row count.
  • The rules this item's rows fall under (rules revision 5):
    • R11 (shipped knowledge): everything else that is model-read K2, K3, K4, K5 or K7. Goes through the cutting route: the generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
    • R4 (consumer default): the value picks a tool or library for the consumer. Goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer.

Key interfaces

  • "The consumer's ecosystem (language, framework, tools): abstract now. Seam: the ecosystem-resolution contract and the consumer's own records."
  • Conventions followed: a cut ships with eval evidence (the skills-and-agents review rules).

Done when

  • AC1 (this plugin's share): tdd ships no model-read tool, library or command choice outside the named exceptions; each listed R11 and R4 row is cut.
  • The pull request body states the row count (23) and lists every row id with its rule and outcome.
  • Each R11 row's script-reader search is quoted in the pull request body.
  • The pull request body names, for each changed skill, the existing case that reads the cut text, or says none does.
  • The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
  • AC10: no new enforcement-placing skill is added here.

Out of scope

Activity

  1. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 17, 2026
  2. added theissue type on Nov 17, 2026
  3. updated Work status ready and Priority medium on Nov 17, 2026
  4. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    Size: Medium
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: the tdd plugin's principles skill and its reference pages, plus the .performance/ratchets.json and scripts/docs-anchor-baseline.txt entries that name them; anyone who loads the tdd skill reads the result.
    Reversible: yes; revert the pull request.
    Open questions: none
    I read this as a bounded cut of 23 listed rows of tool- and library-specific text from tdd, with the pull request body reporting every row. The issue states the route, the row count and the done-when items, so nothing is missing. I found no duplicate among the open issues and no merged pull request that already does this cut.

    Automated triage. A maintainer reviews it.

  5. melodic-automation-lanes commented on Nov 17, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: Size large: the split into sub-issues at intake is pending (owner Q93).

  6. added
    host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.
    on Nov 17, 2026
  7. removed
    host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.
    on Nov 17, 2026
  8. melodic-automation-lanes commented on Nov 17, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped on this issue (split-required): the issue's Size is too large for one run, and intake's split (owner Q93) files its sub-issues.
    Its Size is too large for one run: intake splits it into sub-issues (owner Q93).
    It set Work status to needs-triage, so the hourly triage sweep sends it back through intake triage, and it waits on no decision from a person.

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/44146271204

  9. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    Intake triage did not triage this issue after 2 dispatches, so the sweep no longer dispatches it and set its Work status to needs-triage for a maintainer. Triage it by hand, and read the runs for why intake did not:

  10. melodic-automation-lanes commented on Nov 17, 2026

    @melodic-automation-lanes
    Contributor

    Not split at intake (owner Q93). This issue stays parked at status: ready: no split into whole changes was found, either by task-list line or by the targets the lines name. No person is asked to act and no hold label is added. The split settings are size-split in .github/actions/resolve-config/admission-rules.json.

    Automated by the lanes App, once per reason and body version.

  11. kyle-sexton commented on Nov 21, 2026

    @kyle-sexton
    MemberAuthor

    Split by hand into #17763, #17764, #17765, #17767, #17769, #17771 (native sub-issues, each Small or Medium, each eval-gated): intake sized this issue Large and its size split declined no-split. Most of the Large rating came from the "References outside the plugin" list, which was built by bare file name and pulls in about 300 unrelated files. Each child lists only the outside references a full-path git grep finds. Each child carries its rows, the rules and the host-session eval method, and closes with its own pull request. This issue's AC1 is met when every child closes by merge; the per-PR done-when lines live on the children.

  12. removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    needs-triage

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions