Repository navigation
Closed
Task
Copy link
Description
Part 2 of 6 of #16758. Refs #15703.
Problem
The test-doubles and classical-vs-London pages show their patterns in Java, Python, TypeScript and C#/Moq listings.
Rows (4: all R11)
| Row | Rule | Kind | Cited at (as of 5b66a7f) | Fact |
|---|---|---|---|---|
| F0398 | R11 | K7 | plugins/tdd/skills/principles/reference/test-doubles.md:5-87 |
Mock Object, Self Shunt, Log String in java and python fences |
| F0399 | R11 | K7 | .../reference/test-doubles.md:116-124 |
Moq Times.Once, VerifyNoOtherCalls() |
| F0400 | R11 | K7 | .../reference/test-doubles.md:126-148 |
TypeScript example of one-function-per-remote-operation |
| F0401 | R11 | K7 | .../reference/classical-vs-london-khorikov.md:21-60, 149 |
C#/Moq listings |
Files
- Cut:
plugins/tdd/skills/principles/reference/test-doubles.md,.../reference/classical-vs-london-khorikov.md. - Outside references at d46efa9:
.performance/ratchets.json:194(test-doubles.md ceiling 5),:189(classical-vs-london-khorikov.md ceiling 2).
Rules this part follows (from #16758, rules revision 5)
- R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
- R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through
docs/contracts/ecosystem-resolution/. - R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated
portability-ok: measured <case-id>. - AC1's named exceptions are the kept classes of ADR 0101 (
docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief). - Line numbers below were read at
5b66a7faand may have moved; find each row by its cited text.
After the pull request opens (host session, not the lane)
The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:
- Hold line: a sweep or host session adds
do-not-mergeand posts, from a listed human's account, a comment with<!-- pr-hold reason=eval -->on a line of its own. - Targeted case per changed skill: one before-and-after case on
sonnetat 3 runs a side,--case,--runs 3, a--max-cost-usdceiling;opusonly to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16). - Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from tdd #16758's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
- On a LOSS reading: a trace read of each dropped case and an
opusconfirm; only a loss traced to the changed text counts. - R8 rows: the row's targeted case with and without it; on a
case dropor a mean fall of 0.15 or more without it, restore the row annotatedportability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail. - Record: on a VALID no-loss run, post from a listed human's account
<!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> -->naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removesdo-not-merge; a later push needs a new record.
Out of scope
Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).
Done when
- Every row in this part's table is cut or replaced at a routing site; a row whose cited text is already gone on
mainis listed as GONE. - The pull request body states this part's row count (4) and lists every row id with its rule and outcome.
- Each R11 row's script-reader search is quoted in the pull request body; a row whose file a script reads is not cut, and is listed in the pull request body under a
Script readersheading. - The pull request body names, for tdd:principles, the existing eval case that reads the cut text, or says none does.
- The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
- The
skill-stack-fencesceilings for both files in.performance/ratchets.jsonare lowered to the fences left. - AC10: no new enforcement-placing skill is added.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 21, 2026
Size: Small
Complexity: Low
Uncertainty: Known
Flags: none
Blocked by: none
Blast radius: two tdd reference pages (test-doubles.md, classical-vs-london-khorikov.md) and two ceilings in .performance/ratchets.json; read by the tdd:principles skill.
Reversible: yes; revert the pull request.
Open questions: none
Understood: cut the Java/Python/TypeScript/C# listings from the two tdd reference pages (4 rows, F0398-F0401), lower the two skill-stack-fences ceilings, and report row outcomes, script-reader searches and eval-case evidence in the pull request body. The done-when is exact, and the eval gate runs afterward in a host session. No merged pull request that already fixes this turned up. Sibling parts such as #17764's neighbours in the open list (other tdd cuts) cover different rows, so this is not a duplicate.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 21, 2026
{"v":1,"actor_id":337595936,"title_sha256":"2349fd9e7ededc04f35331fc6cacf8e43a4137f55d6484a2ce2bfa10001effbe","body_sha256":"09134e98a94a283604ae0b0613e6f38d05ed38d09db3798b787bbf54e3806d68"}
melodic-automation-lanes commentedon Nov 21, 2026
This records a re-fire of an earlier stop, not a new one. The start gate stopped run 44893048196, the work-resolve-issue run that
agent-readystarted, before any model turn, because the GITHUB_TOKEN budget was under its start-gate share, or the window was projected to have under its start-project share of the header's limit left by the run's expected end (github-token start-gate, start-project and start-run-minutes in rate-limits.json; the run's start-gate notice names which); that run ended at 2026-11-21T10:12:06Z. work-unblock has now removed and addedagent-readyback to start a fresh run. A budget stop is the lanes' load, not a fault in this issue: it never counts toward limits.limit-stops-per-issue or thekill-switchwait.github-actions commentedon Nov 21, 2026