Skip to content

fix(repin): skip formal models' checked-commit citations in the leftover check - #17314

Merged
kyle-sexton merged 2 commits into
mainfrom
fix/17303-repin-skip-formal-models
Nov 19, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
fix/17303-repin-skip-formal-models

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Closes #17303

Summary

The daily ci-workflows re-pin fails on every run once a release newer than the pin exists (run 44410972086): its leftover check finds the old commit in .claude/skills/formal-ci-lanes-carry-forward/model/CarryForward.tla:9, where the model cites the ci-workflows commit it was checked against. That citation moves only after the model is re-checked, per the skill's SKILL.md, so the re-pin must not require it to move.

Fix

  • scripts/repin-ci-workflows.sh: the leftover check also excludes .claude/skills/formal-*/model/** (a glob pathspec), the same way it already excludes the standards-managed caller.
  • scripts/repin-ci-workflows.test.sh: a case where a formal model names the old SHA; apply succeeds and leaves the model's citation in place. The existing case that fails on a leftover outside the set still fails.

Verification

  • bash scripts/repin-ci-workflows.test.sh: PASS=36 FAIL=0.
  • On this branch, git grep -l 24067add42f5fa04743c587c6a22aa7d4059e7b8 -- . ':(exclude).github/workflows' ':(exclude)docs/conventions/pr-pipeline/pr-run-activity.md' ':(exclude,glob).claude/skills/formal-*/model/**' finds nothing, so the v0.75.0 to v0.76.0 re-pin passes the leftover check once this lands.
  • The model's citation then lags the pin, which its stale-coverage warning reports; its sync follows its own SKILL.md.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

kyle-sexton and others added 2 commits November 18, 2026 18:42
…ver check

The daily ci-workflows re-pin died on CarryForward.tla, which cites the
ci-workflows commit the model was checked against. That citation moves
only after the model is re-checked, per its SKILL.md, so the re-pin's
leftover check now excludes .claude/skills/formal-*/model/**.

Closes #17303

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 23:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T23:48:26.606328Z ee613e8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed ee613e8ea33011c8d6ff86458507f80acd12fcc5: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found.

I read the whole change in both files: scripts/repin-ci-workflows.sh and scripts/repin-ci-workflows.test.sh.

What changed. apply() runs a check after the rewrite to catch any copy of the old pin that is left behind. That check now also skips the pathspec :(exclude,glob).claude/skills/formal-*/model/**. The change affects only that check:

  • The set of files that gets rewritten ($files) is the same as before.
  • The outside check, which fails when a path outside the re-pin set was changed, is the same as before.

Paths checked:

  • Can the excluded files run anything? No. Under glob magic, formal-* matches inside a single directory level, and ** covers only what sits under each skill's model/ directory. Those files are formal models (TLA+ sources) that record which ci-workflows commit they were checked against. An old SHA left in them is not a uses: reference. GitHub only runs workflows from .github/workflows/, so a stale citation there cannot keep an old ci-workflows commit running.
  • Does the exclusion reach further than intended? No. A file in a formal skill but outside model/, such as SKILL.md, is still caught. The new test case at scripts/repin-ci-workflows.test.sh:39-45 pins that behaviour.
  • Trust controls and owner policy. The script is not on the trusted-path list, and the diff widens none of the listed trust controls (trusted-trigger check, lane token scope, kill switch, token broker, merge holds). Loosening the re-pin leftover check counts as a "pin or repin ceremony" friction hold under the owner's throughput-phase policy, so it is noted here and holds nothing. No token, secret, newly trusted actor, untrusted-text path or billable resource is involved.
  • Untrusted inputs. The PR context and the prior-findings file contain no embedded directives. There are no settled threads and no earlier reviews by this lane (blocking only: no).

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed ee613e8ea33011c8d6ff86458507f80acd12fcc5: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

This PR fixes #17303. The re-pin script's leftover check now also skips .claude/skills/formal-*/model/**, using a :(exclude,glob) pathspec. The check sits at scripts/repin-ci-workflows.sh:100 and the new constant at L9. The skip is handled the same way as the existing MANAGED exclusion.

Correctness

  • With glob magic, * does not cross /, so formal-* matches only a skill directory's name. The trailing /** covers everything under model/. A formal skill's SKILL.md or sync.yaml is still checked.
  • The second new test pins that boundary: an old SHA in .claude/skills/formal-lanes/SKILL.md still fails the run.
  • A Grep of the head tree for the current pin 24067add… found only the re-pin set (.github/workflows/*.yml, the pr-run-activity.md doc), the excluded managed caller, and .claude/skills/formal-ci-lanes-carry-forward/model/CarryForward.tla. So once this lands, the v0.76.0 re-pin's leftover check has nothing left to flag. Both sync.yaml files cite a different commit (c4fe439d…) and are not involved.
  • The outside check (L102) is unchanged. The model file is never rewritten, so it shows no change in git status.
  • The PR's test result (PASS=36 FAIL=0) is the author's claim; I did not run it. I traced the two new cases by reading them:
    • apply leaves a formal model citing the old SHA exits 1 on base and 0 on head, so it is a real regression test.
    • The SKILL.md case fails on both base and head, as intended.

Closing issue #17303

  • The suggested fix asks for the formal models to be excluded from the leftover check at scripts/repin-ci-workflows.sh:99 and for a test case to be added. Both are done, and the new model test case would fail if the exclusion broke.
  • The issue's "Expected" outcome is the auto-merge re-pin PR opening. That depends on a live run and cannot be checked from the diff.

Loosened checks

  • Adding a pathspec exclusion to the leftover check is a kind-4 change (an ignore entry). It is also part of a re-pin guard, which the criterion lists as a friction hold.
  • Either way it passes. The closing issue's Suggested fix names this exclusion at this line, with the same glob scope. It also says why: the model's commit citation moves only after the model is re-checked, under the skill's own SKILL.md.
  • The scope does not go past what the issue names.
  • The prompt had no loosened_check_verdict:, loosened_check_patterns: or loosened_check_decision_record: lines. I used the defaults (fail, no consumer entries) and did not check the citation requirement.

Loosened-check verdict: fail (bundled default; no wrapper line); patterns: 0

No embedded instructions were found in the PR context or prior-findings files. There are no prior findings, and this is not a blocking-only review.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit b7bac14 Nov 19, 2026
63 of 75 checks passed
@kyle-sexton
kyle-sexton deleted the fix/17303-repin-skip-formal-models branch November 19, 2026 00:22
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(repin): the daily ci-workflows re-pin fails on the carry-forward model's commit citation

1 participant