Repository navigation
fix(repin): skip formal models' checked-commit citations in the leftover check - #17314
Conversation
…ver check The daily ci-workflows re-pin died on CarryForward.tla, which cites the ci-workflows commit the model was checked against. That citation moves only after the model is re-checked, per its SKILL.md, so the re-pin's leftover check now excludes .claude/skills/formal-*/model/**. Closes #17303 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no security issues found. I read the whole change in both files: What changed.
Paths checked:
critical-findings: 0 |
|
claude-review reviewed Code review: no findingsThis PR fixes #17303. The re-pin script's leftover check now also skips Correctness
Closing issue #17303
Loosened checks
Loosened-check verdict: fail (bundled default; no wrapper line); patterns: 0 No embedded instructions were found in the PR context or prior-findings files. There are no prior findings, and this is not a blocking-only review. Verifier dropped 0 of 0 candidates. |
Closes #17303
Summary
The daily ci-workflows re-pin fails on every run once a release newer than the pin exists (run 44410972086): its leftover check finds the old commit in
.claude/skills/formal-ci-lanes-carry-forward/model/CarryForward.tla:9, where the model cites the ci-workflows commit it was checked against. That citation moves only after the model is re-checked, per the skill's SKILL.md, so the re-pin must not require it to move.Fix
scripts/repin-ci-workflows.sh: the leftover check also excludes.claude/skills/formal-*/model/**(aglobpathspec), the same way it already excludes the standards-managed caller.scripts/repin-ci-workflows.test.sh: a case where a formal model names the old SHA;applysucceeds and leaves the model's citation in place. The existing case that fails on a leftover outside the set still fails.Verification
bash scripts/repin-ci-workflows.test.sh: PASS=36 FAIL=0.git grep -l 24067add42f5fa04743c587c6a22aa7d4059e7b8 -- . ':(exclude).github/workflows' ':(exclude)docs/conventions/pr-pipeline/pr-run-activity.md' ':(exclude,glob).claude/skills/formal-*/model/**'finds nothing, so the v0.75.0 to v0.76.0 re-pin passes the leftover check once this lands.Related
report-ci-statuscomposite), which waits on the v0.76.0 re-pin.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C