Repository navigation
fix(source-control): enforce PR-body linkage under the report-ci-status composite - #17353
Conversation
…us composite Both linkage hooks run only where a workflow names pr-require-checks/check-contract. The ci-status rollout (ci-workflows#1138) replaced that step with the report-ci-status composite, which runs check-contract inside it, so the hooks stopped checking in every repository already moved. They now match either path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: PR #17353 (incremental, e0753c7 → fa893b6)This lane has already reviewed an earlier head, so this pass reports blocking findings only. I read every hunk of all 4 files in the incremental diff. The push changes only comments and docs; no code changed. Both No new findings. This push fixes the one finding from the last round, about scope documentation that named only
I checked the punctuation the edits touched. In the MCP hook's SCOPE GUARD header, the parenthesis that used to close after
Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review (incremental, blocking only): no security issues foundI reviewed only the changes since
This push touches no trust control, token scope, kill switch, merge hold, plugin manifest or standing instruction. It removes no rule from the instruction surface: the edits add wording and take none away. No settled threads apply. The lane's one prior post was a summary with no line anchor and no findings, so nothing carries over. This lane already reviewed an earlier head, so this review reports blocking findings only. critical-findings: 0 |
…age hooks' scope The scope regex now matches pr-require-checks/report-ci-status, but the hook headers, the regex comments, the README and create.md still said the hooks run only where check-contract is used. Name both steps everywhere the scope is stated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: found by the review lane on #17283 and fixed in place.
Summary
The PR-body linkage hooks (
pr-body-linkage-gate.sh,pr-linkage-mcp-gate.sh) run only in a repository where a workflow namespr-require-checks/check-contract. The ci-status rollout (melodic-software/ci-workflows#1138) replaced that step with thepr-require-checks/report-ci-statuscomposite, which runs check-contract inside it, so both hooks exit early in every repository already moved (18 so far) and would in this one once #17283 merges. Reported by the review lane on #17283.Fix
pr-require-checks/(check-contract|report-ci-status), keeping the trailing class that keeps a longer sibling directory out.source-controlpatch changelog fragment.Verification
pr-body-linkage-gate.test.sh: 183 passed, 0 failed;pr-linkage-mcp-gate.test.sh: 58 pass, 0 fail;pr-linkage-spawn-budget.test.sh: 21 passed.expected block(2), got rc=0;expected exit 2, got 0), so the tests catch the regression.scripts/check-affected.sh --tests: 19 passed, 2 skipped.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C