Repository navigation
ci(pr-require-checks): run ci-status on the report-ci-status composite - #17283
Conversation
The ci-status job's check-contract step and its aggregate-results step become one report-ci-status step (ci-workflows v0.76.0), named "Aggregate lane results", followed by "Fail on the contract or draft policy". Draft policy stays allow, exempt-authors, treat-skipped-as, rerun-contract-only-siblings and the 600 s yield ceiling are unchanged. check-contract now runs after the hold steps, so its 60 s rate-limit wait falls inside gh_read's margin: GH_READ_MARGIN_SECONDS goes from 375 to 435. pr-verify's held-run recognition reads the new fail step and its log lines, and still accepts a run from before the composite. Refs: melodic-software/ci-workflows#1138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fd2ef50a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Held with do-not-merge until the daily ci-workflows re-pin (14:47 UTC) moves this repository's ~370 other ci-workflows pins to v0.76.0. scripts/repin-ci-workflows.sh refuses a tree that pins two ci-workflows commits, so merging this first would break that re-pin. After the re-pin merges: update this branch, re-run both review lanes if the kill switch stopped them, confirm CI Status is green, remove the label, and merge. Then move the formal-ci-lanes-carry-forward model's sync commit forward, as its SKILL.md says. |
|
claude-review reviewed Code review: incremental (1449b22 → 9e4d473), blocking onlyThis lane already reviewed earlier heads of this pull request, so this review reports blocking findings only. The scope is the one file changed since What changed. The old assertion added up two
This matches the PR description. Checked by reading the code (I ran nothing):
Prior findings and settled threads. The earlier linkage-hook finding and the pin thread are both resolved with an owner decision, both marked Closing issue: none. The PR only says Embedded instructions: none found in the PR context, settled threads or prior findings. Spend: none. The change adds no billed resource. Loosened checks:
The PR's actionlint and test-pass counts are the author's claims; I could not run them. Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review (incremental, blocking only): no security issues foundThis lane already reviewed an earlier head ( What changed
Why there is no finding
Other notes
critical-findings: 0 |
Conflicts in pr-require-checks.yml: main moved check-contract and aggregate-results to v0.76.3 and passed rate-limit-wait-seconds: '60' to each; this branch replaces both with the report-ci-status composite, now pinned to v0.76.3 (9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8), with its citations moved to that SHA. The composite takes no wait input and runs both inner actions at their default '60' (check-contract and aggregate-results action.yml at v0.76.3), so the waits main set are unchanged. rate-guard.test.mjs, added on main, pinned the two explicit waits and ci-status's read deadline at 1200 - 375. Under the composite both waits run after the read window, so this branch's 435 s margin stands and WAIT_BUDGET_SECONDS.ciStatusReads becomes 765; the test now checks the deadline and that ci-status calls report-ci-status once with no wait input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
…gh-read ci-gh-read.test.sh, added on main, required two explicit rate-limit-wait-seconds in ci-status. report-ci-status takes no wait input and runs check-contract and aggregate-results at their 60 s defaults, the same 120 s the timeout holds; the test now checks that ci-status calls the composite once and passes no wait input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Refs: melodic-software/ci-workflows#1138
Summary
Moves the
ci-statusjob onto the sharedreport-ci-statuscomposite (ci-workflows v0.76.3,9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8), the last repository of the rollout in ci-workflows#1138. Same shape as the merged examples songwriting#75 (draft: refuse) and codex-plugins#208 (draft: allow).CI Statusstays the job name and the single required check.Fix
ci-status: theCheck the pull-request contractstep and theaggregate-resultsstep become onereport-ci-statusstep, still namedAggregate lane results(id: report), at the old aggregate's place, followed byFail on the contract or draft policy(if: !cancelled() && (contract != 'success' || draft != 'success'),exit 1).draft: allow(the job hasNote a draft, no "Refuse a draft" step),exempt-authors: 'dependabot[bot],melodic-release[bot]',treat-skipped-as: ${{ github.event.pull_request.draft && 'pass' || 'fail' }},rerun-contract-only-siblings(false on a draft),step-name, and the job'sif,needs, permissions, runner, timeout and every repo-specific step.rate-limit-wait-seconds: '60'to check-contract and aggregate-results. The composite takes no such input and runs both at their default, which is'60'in each action.yml at v0.76.3, so the waits are unchanged.yield-wait-secondsbecomes${{ github.event.pull_request.draft && '0' || '600' }}: thejob.status == 'failure' && <contract-only>half the old expression carried is now done by the composite, which also drops the hold on a failed contract or draft step (action.yml).yield-to-full-run: 'true'andcarry-forward-wait-seconds: '0'are fixed there (L128-L129).GH_READ_MARGIN_SECONDSgoes from 375 to 435, keeping the slack the margin had.WAIT_BUDGET_SECONDS.ciStatusReadsinrate-guard.mjsfollows (825 to 765), andrate-guard.test.mjsnow checks that ci-status calls report-ci-status once with no wait input instead of pinning two explicit waits.github.run_id, and thepr-require-checks-main-dispatchgroup for pr-merge.yml's whole-suite dispatch is a deliberate repository decision recorded in the workflow's comment, so it stays.pr-verify/resolve-pr.mjsread the old shape: its held-run check (a run red only ondo-not-mergeor an approval-liftable hold) matched theCheck the pull-request contractstep. It now matchesFail on the contract or draft policy, its error line, and check-contract's extra exit inside the composite step, and still accepts a run from before the composite. Its test and the workflow-shape test move with it.docs/ci-runner-routing.md, section Contract-onlyci-status: names the composite that fixes the two inputs.Verification
actionlinton the workflow: clean.resolve-pr.test.mjs,callers.test.mjsandrate-guard.test.mjs639 pass;pr-body-linkage-gate.test.sh183 pass andpr-linkage-mcp-gate.test.sh58 pass (the hooks' scope now includes report-ci-status, fix(source-control): enforce PR-body linkage under the report-ci-status composite #17353).do-not-mergeon, contract-only run 44406693983:Aggregate lane resultssuccess, check-contract logged thedo-not-mergeerror inside it, andFail on the contract or draft policyfailed. With it off, contract-only run 44406880596: "Carried forward: ci-lanes is success on 6fd2ef5", the fail step skipped.Related
pr-check-managed-files-hosted.yml, is the standards sync's and matches main.formal-ci-lanes-carry-forwardmodel cites the old step's inputs and line numbers; its sync commit moves after merge, per its SKILL.md "Updating".🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C