Repository navigation
chore(ci): re-pin ci-workflows actions to v0.76.3 - #17376
Conversation
…contract eval-handoff, the at-pin loaders and every test that loads ci-workflows code at a pin now read run-claude-cli/contract-files.txt and require contract.cjs, never lane.cjs, classify.cjs or select.cjs directly. The restated handoffReason goes: the contract exports it. The eval legs' sparse checkouts list the manifest and its paths, held equal to the manifest at the pin by eval-handoff.test.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
|
claude-security-review reviewed Security review: PR #17376 (re-pin ci-workflows to v0.76.3 and load the launcher only through its published contract)I found no security issues. I read every hunk of all 28 changed files in This lane already reviewed an earlier head ( What changed since the last review The new head adds two changes beyond the 27 files reviewed before:
What I checked
Trust controls: none is widened.
Owner threat model: this PR removes none of the owner's named friction holds. Spend: nothing changes run counts, turn limits, timeouts, models or effort levels. Untrusted text: the PR description contains no embedded instructions to the lane. critical-findings: 0 |
|
claude-review reviewed Code review: re-pin ci-workflows actions to v0.76.3 and load the launcher only through its published contractNo blocking findings. This review was blocking only: this lane already reviewed an earlier head ( What changed since the last reviewed headThe new head is a merge of
Both are plain pin bumps with nothing else changed. The contract-loading code (
Pin consistency
Other checks
Loosened-check verdict: fail (default; no wrapper settings lines); patterns: 0 Verifier dropped 0 of 0 candidates. |
The contract commit removed model-credential.mjs's raw fetch of ci-workflows files (it now reads the contract from the pinned checkout), so rate-guard.test.mjs failed with "a listed file no longer needs its exception". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
No related issue: automated re-pin to the newest ci-workflows release, plus the launcher-contract change this pin requires
Summary
Moves every
melodic-software/ci-workflows/.github/actions/...pin in.github/workflows/, the eval legs' ci-workflows checkout refs and thepr-run-activity.mdlink from v0.75.0 to v0.76.3 (9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8).pr-check-managed-files-hosted.ymlis left to the standards sync. The doc edit carries apr-pipelinechangelog fragment with bumpnone.A second commit (5640836) makes this repository load ci-workflows' launcher only through its published contract, which v0.76.3 is the first release to ship (ci-workflows#1146:
run-claude-cli/contract.cjspluscontract-files.txt). Earlier ci-workflows releases removed internal exports this repository loaded directly (ci-workflows#1129, restored by #1143 and #1145), which broke re-pins; loading only the contract ends that.Fix
.github/workflows/maintenance-repin-ci-workflows.ymlthroughscripts/repin-ci-workflows.sh, which refuses a release that does not contain the current pin.eval-handoff.mjs, the at-pin loaders (lib/ci-workflows-at-pin.mjs,lib/model-credential.mjs) and every test that loads ci-workflows code at a pin now readrun-claude-cli/contract-files.txtand requirecontract.cjs, neverlane.cjs,classify.cjsorselect.cjsdirectly. The restatedhandoffReasonis dropped: the contract exports it.pr-run-plugin-evals.yml,maintenance-measure-skill-edit-pass.yml) list the manifest and the paths in it, andeval-handoff.test.mjsholds that list equal tocontract-files.txtat the pin. Listing the paths in YAML, test-enforced, was chosen over a step that reads the manifest at run time: it keeps the checkout a single declarative step, and a manifest change fails this repository's tests at the next re-pin instead of failing a live eval run. Revisit if the manifest starts changing often.Verification
scripts/repin-ci-workflows.test.shcovers the rewrite.callers.test.mjs(290/290),parity.test.mjs,eval-handoff.test.mjsandcredential-legs.test.mjspass locally against the actions at the new pin; Biome is clean on the changed scripts.Related