Skip to content

chore(ci): re-pin ci-workflows actions to v0.76.3 - #17376

Merged
melodic-release[bot] merged 4 commits into
mainfrom
chore/repin-ci-workflows
Nov 19, 2026
Merged

melodic-release[bot] merged 4 commits into
mainfrom
chore/repin-ci-workflows

Conversation

@melodic-release

@melodic-release melodic-release Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

No related issue: automated re-pin to the newest ci-workflows release, plus the launcher-contract change this pin requires

Summary

Moves every melodic-software/ci-workflows/.github/actions/... pin in .github/workflows/, the eval legs' ci-workflows checkout refs and the pr-run-activity.md link from v0.75.0 to v0.76.3 (9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8). pr-check-managed-files-hosted.yml is left to the standards sync. The doc edit carries a pr-pipeline changelog fragment with bump none.

A second commit (5640836) makes this repository load ci-workflows' launcher only through its published contract, which v0.76.3 is the first release to ship (ci-workflows#1146: run-claude-cli/contract.cjs plus contract-files.txt). Earlier ci-workflows releases removed internal exports this repository loaded directly (ci-workflows#1129, restored by #1143 and #1145), which broke re-pins; loading only the contract ends that.

Fix

  • Re-pin: written by .github/workflows/maintenance-repin-ci-workflows.yml through scripts/repin-ci-workflows.sh, which refuses a release that does not contain the current pin.
  • Contract: eval-handoff.mjs, the at-pin loaders (lib/ci-workflows-at-pin.mjs, lib/model-credential.mjs) and every test that loads ci-workflows code at a pin now read run-claude-cli/contract-files.txt and require contract.cjs, never lane.cjs, classify.cjs or select.cjs directly. The restated handoffReason is dropped: the contract exports it.
  • Sparse checkouts: the six eval legs' sparse checkouts (pr-run-plugin-evals.yml, maintenance-measure-skill-edit-pass.yml) list the manifest and the paths in it, and eval-handoff.test.mjs holds that list equal to contract-files.txt at the pin. Listing the paths in YAML, test-enforced, was chosen over a step that reads the manifest at run time: it keeps the checkout a single declarative step, and a manifest change fails this repository's tests at the next re-pin instead of failing a live eval run. Revisit if the manifest starts changing often.

Verification

  • scripts/repin-ci-workflows.test.sh covers the rewrite.
  • callers.test.mjs (290/290), parity.test.mjs, eval-handoff.test.mjs and credential-legs.test.mjs pass locally against the actions at the new pin; Biome is clean on the changed scripts.

Related

…contract

eval-handoff, the at-pin loaders and every test that loads ci-workflows
code at a pin now read run-claude-cli/contract-files.txt and require
contract.cjs, never lane.cjs, classify.cjs or select.cjs directly. The
restated handoffReason goes: the contract exports it. The eval legs'
sparse checkouts list the manifest and its paths, held equal to the
manifest at the pin by eval-handoff.test.mjs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed d3b8f8e857c64cf17a5d564620449780412d33b7: read 28 of 28 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #17376 (re-pin ci-workflows to v0.76.3 and load the launcher only through its published contract)

I found no security issues. I read every hunk of all 28 changed files in .claude-lane/pr.diff.

This lane already reviewed an earlier head (56408366ef5), so this review covers blocking findings only. That earlier review posted no findings, so there is nothing to repeat.

What changed since the last review

The new head adds two changes beyond the 27 files reviewed before:

  • maintenance-audit-test-selection.yml: its shellcheck action pin moves to the same v0.76.3 SHA.
  • .github/actions/log-api-budget/rate-guard.test.mjs: this test file drops its UNGUARDED exemption for lib/model-credential.mjs. That module no longer fetches anything itself; it now goes through lib/ci-workflows-at-pin.mjs. Only a test changes here: rate-guard.mjs and api-budget.bash are untouched.

What I checked

  • Action pins (20 workflow files). Every melodic-software/ci-workflows/.github/actions/* reference moves from one full SHA (24067add…, v0.75.0) to another (9c5bedfb…, v0.76.3), both in the owner's own repository.
    • No with: input, if: condition, permissions: block, env: or secret mapping changes in any hunk.
    • That holds for the trust-path workflows too: pr-review-main.yml, pr-require-checks.yml (the ci-status, check-contract and aggregate-results steps), pr-unblock.yml, pr-verify.yml, pr-run-activity-read.yml and work-resolve-issue.yml.
    • Pin hygiene belongs to zizmor's lane, and the repin step is one of the owner's named friction holds, so the re-pin is not a finding here.
  • Eval-leg sparse checkouts. These are the six steps in pr-run-plugin-evals.yml and maintenance-measure-skill-edit-pass.yml.
    • They now also fetch contract-files.txt, contract.cjs, check-key-credit/gate.cjs, otlp-receiver.cjs and select-model-credential/select.cjs.
    • They keep persist-credentials: false and the same SHA-pinned ref:. The files are only loaded with require, so no new token or credential reaches these steps.
  • eval-handoff.mjs loadContract. It reads contract-files.txt from the pinned checkout and copies each path it lists into a temporary directory, then requires contract.cjs.
    • Every path comes from the owner-pinned SHA. No pull request author, comment or forked head can control them, so a traversing path cannot come from untrusted input.
    • The local copy of handoffReason is removed in favour of the one the contract exports. Handoff only picks the next credential leg; it grants no permission and passes no untrusted text.
  • lib/ci-workflows-at-pin.mjs, lib/model-credential.mjs and the tests. These are test-time loaders that fetch from raw.githubusercontent.com at a fixed SHA.
    • The old fetchModule followed every relative require it found. The new loader fetches only the paths the manifest lists, so what gets fetched is narrower.
  • pr-run-activity.md and the .changes fragment. The doc change only updates the commit SHA in one link, so the instruction-surface lens has nothing to judge.

Trust controls: none is widened.

  • check-trusted-trigger, request-lane-token, resolve-config and check-kill-switch are unchanged, as is every other repository-local action under .github/actions/ (only log-api-budget's test file changes, as noted above).
  • The merge-hold scripts and pr-merge.yml are unchanged.

Owner threat model: this PR removes none of the owner's named friction holds.

Spend: nothing changes run counts, turn limits, timeouts, models or effort levels.

Untrusted text: the PR description contains no embedded instructions to the lane.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed d3b8f8e857c64cf17a5d564620449780412d33b7: read 28 of 28 changed file(s); 0 finding(s), 0 as inline comments.

Code review: re-pin ci-workflows actions to v0.76.3 and load the launcher only through its published contract

No blocking findings. This review was blocking only: this lane already reviewed an earlier head (56408366ef5), so only blocking findings would be posted. I read every hunk of all 28 changed files in .claude-lane/pr.diff.

What changed since the last reviewed head

The new head is a merge of origin/main. It adds two files to the pull request:

  • maintenance-audit-test-selection.yml: one shellcheck pin moves to v0.76.3.
  • work-resolve-issue.yml: one select-model-credential pin moves to v0.76.3.

Both are plain pin bumps with nothing else changed.

The contract-loading code (eval-handoff.mjs, lib/ci-workflows-at-pin.mjs, lib/model-credential.mjs) and its tests are the same as at the earlier head, where this lane found nothing to flag:

  • callers pass handoffReason in the leg-object form ({ leg }, …)
  • withPartials and judgeStream take it from the contract
  • the sparse-checkout lists are held equal to contract-files.txt at the pin

Pin consistency

  • I checked with Grep across .github/workflows/: 372 of 373 ci-workflows/.github/actions/…@<sha> references are at 9c5bedfb… (v0.76.3).
  • The one left at v0.75.0 is pr-check-managed-files-hosted.yml:119. The PR says it leaves that file to the standards sync on purpose.
  • The only other v0.75.0 SHA in the repository is a comment in a TLA+ model, CarryForward.tla:9, which records a past pin and is not a live reference.

Other checks

  • Closing issue: none. The PR is an automated re-pin, so there are no acceptance criteria to check. The PR context has no instructions aimed at this lane.
  • Verification: the test results in the PR description (callers.test.mjs 290/290, parity, eval-handoff, credential-legs) are the author's claims, not checked by me. This lane has no shell, and those tests fetch files from raw.githubusercontent.com.
  • Spend: none beyond what the existing lanes already spend. The pin bumps add no paid resource or billing setting.
  • Paved paths: the standards index has no paved-path row, so there is nothing to report.
  • Loosened checks: the prompt had no loosened_check_* lines, so I used the default fail with no consumer entries. The decision-record citation requirement was not checked because no loosened_check_decision_record: line was given. No loosening was found: the sparse-checkout equality assertion and the handoff rule expectations are kept, not relaxed.

Loosened-check verdict: fail (default; no wrapper settings lines); patterns: 0

Verifier dropped 0 of 0 candidates.

kyle-sexton and others added 2 commits November 19, 2026 00:04
The contract commit removed model-credential.mjs's raw fetch of
ci-workflows files (it now reads the contract from the pinned checkout),
so rate-guard.test.mjs failed with "a listed file no longer needs its
exception".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@melodic-release
melodic-release Bot added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 90a5928 Nov 19, 2026
67 checks passed
@melodic-release
melodic-release Bot deleted the chore/repin-ci-workflows branch November 19, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant