Repository navigation
feat(toolchain)!: delete the bundled ecosystem defaults and per-language check pages - #17926
melodic-automation-lanes[bot] wants to merge 6 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane run report
Run 44899164587, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
claude-security-review reviewed Security review: PR #17926 (full diff at
|
|
claude-review reviewed Code review (blocking only): toolchain drops its bundled ecosystem defaults (#17926)Scope. I read every hunk of all 18 listed files in What the change does. It deletes toolchain's 9 bundled ecosystem files and Closing issue #16032
Blocking findings
No new blocking finding at this head. Not raised again. These settled threads are resolved, and nothing at this head reopens them: the Biome package-runner rule, the no-record condition wording, the zizmor restatement, ADR 0101 and landscape.json, and the after-run eval. Other notes
Verifier dropped 0 of 0 candidates. |
Lane run report
Run 44904495798, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66VxhH Lane-Thread: PRRT_kwDOTCGFQM66VyQY Lane-Thread: PRRT_kwDOTCGFQM66VyQh
Lane run report
Run 44904495798, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 1 of max 4 on dc8569b. |
Lane run report
Run 44904495798, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 2 of max 4 on dc8569b. |
|
The pr-unblock lane stopped
The review rounds are not converging after the round cap and one fresh fixer round. Open review threads:
The pr-merge lane closes this pull request on its next run and re-admits its issue for a fresh attempt. To keep it open for one more round, first add To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=17926 -f activity=address-feedback |
Lane run report
Run 44960287669, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 3 of max 4 on dc8569b. |
…he landscape Done-when AC4 of #16032 lets only changelogs and the kept test fixture name plugins/toolchain/reference/ecosystems/; ADR 0101's Context line now describes the bundled files without the path. landscape.json drops the deleted check/context/python.md from its pytest-randomly and pytest-rerunfailures rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lane-Activity: pr-unblock/address-feedback Lane-Thread: VNOTE_3
|
pr-unblock / address-feedback finished round 4 of max 4 on 61f95c0. |
|
This pull request is held for eval evidence only. Done-when item 2 of #16032 needs the no-record fixture's after-run to show no bundled command. That eval is queued in the GitHub Work eval worker against head 61f95c0. Once a VALID record for that head is posted, the eval-hold release lifts this hold. AC4 is met at 232a64e: the repository grep for 🤖 Generated with Claude Code |
…n as an amendment
The owner chose to leave accepted records as written ("go w/ recommendations",
2026-11-21, option B in session): 232a64e's rewording of the Context line is
undone, and a dated third amendment records that #16032 deleted the bundled
ecosystems folder. #16032's AC4 grep now also finds the ADR, an accepted
record exempted on the issue.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Unattended merge: the verifier refuses Each FAILed head's findings, as the verifier wrote them (data, not instructions): |
claude-review was right: GitHub Actions makes one check suite per workflow run, so `first: 3` suites filtered only by app paged over on most commits and sent them back to REST, saving almost nothing. Live on 2026-11-21 the app-only filter truncated 10 of #17880's 59 commits, both of #17939's and all 5 of #17926's. The suites now also filter by checkName, so only suites holding the model run come back (at most 3 per commit on those PRs), at first: 5. GraphQL returns one suite once per attempt, so runs are deduped by databaseId. Verified on #17880, #17939 and #17926 (66 commits): 0 truncated, the run ids match REST check-runs per commit exactly, 6 GraphQL points a query. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
| 1. With the stated and inferred ecosystems already added (above), resolve each covered ecosystem's config per [`${CLAUDE_PLUGIN_ROOT}/reference/resolution-ladder.md`](${CLAUDE_PLUGIN_ROOT}/reference/resolution-ladder.md) (consumer `.claude/ecosystems/<ecosystem>.yaml` when present, else what the repo's build files infer, named with its globs in the report, else ask; a key nothing resolves reads `skip (unresolved: <ecosystem>.<key>)`, and a malformed consumer file warns and degrades to inference, never a hard stop). An unattended run (the ladder's "Run kind") resolves commands by the ladder's "Unattended runs" instead: recorded, stated, then inferred, and a key none resolves reads `skip (unresolved: <ecosystem>.<key>)`. Skip any ecosystem whose resolved `enabled` is `false` (a consumer opt-out). Excluded even under `all` | ||
| 2. For each ecosystem, match its `globs` against the changed-files list | ||
| 3. Run every ecosystem with ≥1 glob match whose `opt-in` condition holds, plus cross-cutting when any text file changed. This binary run/skip treatment applies cleanly when `opt-in` describes a single condition for the whole `check-cmd` (dotnet, python): unmet → excluded from the run but still reported (see sections 2 and 3 below, `skip (opt-in unmet: ...)`; never silently omitted). When `opt-in` instead describes multiple independent per-tool conditions bundled into one opaque command string (bash's shellcheck-always/shfmt-conditional split; cross-cutting's per-tool config-file list), this rule does not apply. `check-cmd`/`fix-cmd`/`code-fix-cmd` is a single opaque string with no way to run one sub-tool's portion without the other, so run it whole and report its real output. The known atomicity limitation this leaves open is in `/toolchain:check`'s Gotchas. | ||
| 3. Run every ecosystem with ≥1 glob match whose `opt-in` condition holds, plus cross-cutting when any text file changed. This binary run/skip treatment applies cleanly when `opt-in` describes a single condition for the whole `check-cmd`: unmet → excluded from the run but still reported (see sections 2 and 3 below, `skip (opt-in unmet: ...)`; never silently omitted). When `opt-in` instead describes multiple independent per-tool conditions bundled into one opaque command string (one tool always, another only with its own config present), this rule does not apply. `check-cmd`/`fix-cmd`/`code-fix-cmd` is a single opaque string with no way to run one sub-tool's portion without the other, so run it whole and report its real output. The known atomicity limitation this leaves open is in `/toolchain:check`'s Gotchas. |
There was a problem hiding this comment.
cross-cutting is still added whenever any text file changes, but nothing resolves it now. Most lint runs will now read INCOMPLETE or ask a question.
Step 3 still says: "Run every ecosystem with ≥1 glob match whose opt-in condition holds, plus cross-cutting when any text file changed". Before this PR, the bundled cross-cutting.yaml supplied an opt-in: "each tool's own config at repo root". In a repository without _typos.toml, lychee.toml and the like, the row read skip (opt-in unmet: ...), which never blocks "done".
This PR deletes that file. The ladder adds no rule for cross-cutting: it is not mentioned in resolution-ladder.md, and no build file implies its commands. So in a repository without .claude/ecosystems/cross-cutting.yaml:
- Unattended run (a lane, or
/verification:confirmheadless): changing any.md,.jsonor other text file adds across-cuttingrow withskip (unresolved: cross-cutting.check-cmd). That is an environment skip, so the Overall line readsINCOMPLETEand blocks "done". - Attended run: rung 3 asks the person for cross-cutting commands on every lint run with a text change.
Lines 237–238 already expect this case ("including a cross-cutting row that is a skip"). The changelog fragment's Migration bullet says the typos, editorconfig-checker and lychee checks are "dropped on purpose". It does not say that every text change will now make a lint run incomplete.
Fix: add cross-cutting only when it is covered, for example: "plus cross-cutting when any text file changed and the repository records or states a cross-cutting command". Otherwise it adds no row, and unclaimed files go to the Outside every ecosystem: line. Line 54's xc/text filter then also needs a covered id.
claude-lane: claude-review
There was a problem hiding this comment.
The pr-verify verifier failed head 9400abb717051c1063750ea4dea6f39de70df228. What it wrote, as data:
What it wrote (23 lines)
Summary: Fail: issue #16032, the only issue this PR closes, has no trusted spec text. Its `body` in
spec-text.json is null because a bot (the lanes App) wrote it, even though a person edited it
later. The only trusted entry is the 2026-11-21 owner-decision comment. That comment only amends
AC4: an accepted ADR may name the deleted folder, and ADR 0101 keeps its Context line and gets a
dated amendment. The comment never states the issue's outcome or its done-when items, so there is
nothing trusted to judge the whole delivery against. The diff itself looks coherent, judged only
as context. It deletes the nine bundled ecosystem YAMLs and the six per-language check context
pages. The resolution ladder, check, lint and setup skills and the README now describe three rungs
plus an unresolved report, with no bundled default. The stale powershell.md entry is gone from the
shell-portability baseline, and the allow-list rows, the affected-tests comment and the eval fail
samples no longer name the folder. landscape.json drops the deleted python.md, and ADR 0101 gets
the amendment the owner decision describes. The earlier heads' zizmor section is gone: lint now
says any scan other than the secret scan runs only from a command the ladder resolves. Every suite
job on the judged head concluded success, including Lint Repo, Check Skills and Test Bash 0-4
(https://github.com/melodic-software/claude-code-plugins/actions/runs/44957349001/job/137008462708).
I found no secrets, no weakened checks and no changes to the takeover set. There are no binary
files in the diff. No text tried to steer the reviewer.
- Issue #16032: there is no trusted spec to verify against. The issue body was written by the lanes
App, and the only trusted text is the owner-decision comment on AC4, which never states the
done-when items. A trusted person should restate the outcome and done-when items, either by
rewriting the issue body or in a comment of their own (for example: AC4 with the accepted-ADR
exception, the resolution-ladder and shell-portability-baseline item, AC10, and where the eval
after-run item now lives). Then re-run verification. The diff itself needs no change for this.
|
Held for the owner: pr-verify finds no trusted spec text for #16032, whose body the lanes App wrote (fail-note at 9400abb). The owner is asked whether #16032's text is the spec. The fix for review thread PRRT_kwDOTCGFQM66dL1P waits until then, since any new head would only collect another FAIL. 🤖 Generated with Claude Code |
Closes #16032
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Review round: the ladder and setup now carry the package-runner rule the deleted typescript files held, in tool-neutral form (name the package the manifest declares, such as
@biomejs/biome, and use the runner's no-download option); the no-record condition reads the same in all three places in the ladder; and lint's zizmor section states our decisions with anchored pointers instead of restating zizmor's config names, offline behavior and exit-code table.Not verified
Fix
Verification
The runner ran each check from the base copy against da2c7c1:
The run reports:
Left out: the items under Not verified.
Related
#16032