Repository navigation
feat(toolchain)!: delete the bundled ecosystem defaults and per-language check pages #17926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
melodic-automation-lanes
wants to merge
6
commits into
main
Choose a base branch
from
work-resolve-issue/issue-16032-44896998505-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+170
−686
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
da2c7c1
Resolve issue #16032
melodic-automation-lanes[bot] dc8569b
Address review feedback on work-resolve-issue/issue-16032-44896998505-1
melodic-automation-lanes[bot] 232a64e
docs(toolchain): drop the deleted ecosystems path from ADR 0101 and t…
kyle-sexton 61f95c0
Address review feedback on work-resolve-issue/issue-16032-44896998505-1
melodic-automation-lanes[bot] 9400abb
docs(adr): keep ADR 0101's Context as accepted and record the deletio…
kyle-sexton ca1f09b
Merge branch 'main' into work-resolve-issue/issue-16032-44896998505-1
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
.changes/toolchain/work-resolve-issue-issue-16032-44896998505-1-d4f74506.md
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pr-verify verifier failed head What it wrote (23 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| --- | ||
| bump: major | ||
| --- | ||
|
|
||
| ### Removed | ||
|
|
||
| - **No bundled ecosystem defaults.** The nine bundled ecosystem files (`bash`, `cross-cutting`, | ||
| `dotnet`, `go`, `markdown`, `powershell`, `python`, `typescript`, `yaml`) are deleted, and so are | ||
| `/toolchain:check`'s six per-language context pages. `/toolchain:check` and `/toolchain:lint` run | ||
| only a command the repository records in `.claude/ecosystems/<id>.yaml`, one its build files | ||
| imply, or, in an attended run, one the person gives when asked. A key nothing resolves reads | ||
| `skip (unresolved: <ecosystem>.<key>)` and runs nothing. The resolution ladder has three rungs. | ||
| `/toolchain:setup apply` drafts records from the repository alone. | ||
| ([#16032](https://github.com/melodic-software/claude-code-plugins/issues/16032)) | ||
| - **Migration.** A repository with no ecosystem record used to get the bundled commands in an | ||
| attended run. It now gets inferred commands, a question, or an unresolved skip. To keep a | ||
| command, record it with `/toolchain:setup apply <ecosystem>`. Checks only the bundled files ran | ||
| are dropped on purpose: the spelling check (`typos`), the editorconfig check | ||
| (`editorconfig-checker`) and the offline link check (`lychee --offline`) from the cross-cutting | ||
| file, and the workflow lint (`actionlint`) from the yaml file. Record them in | ||
| `.claude/ecosystems/cross-cutting.yaml` or `.claude/ecosystems/yaml.yaml` to keep them. The secret | ||
| scan stays: `/toolchain:lint` runs it from the skill. | ||
| - **Coverage.** With no bundled file to supply globs, an ecosystem id is covered when it is | ||
| recorded, stated in the repository's instructions, or inferred from its build files. In a | ||
| repository with no ecosystem record, a changed file's own type also infers its id, so it reads | ||
| `skip (unresolved: ...)` rather than going unchecked in silence. | ||
|
|
||
| ### Changed | ||
|
|
||
| - `/toolchain:check` keeps its retry, seed and slow-test reporting rules in the skill, written for | ||
| any test runner. The description now says what the skill runs: the project's own commands only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
plugins/toolchain/evals/ck-unattended-stated-unresolved/samples/no-record-write.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"pass": [{"answer": [{"tool": "Bash", "input": {"command": "ls .claude/ecosystems/ 2>/dev/null"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "cat /tmp/w/.claude/ecosystems/bash.yaml 2>&1"}}], "why": "a read, not a write"}], "fail": [{"answer": [{"tool": "Bash", "input": {"command": "printf 'globs: [\"*.sh\"]\\n' > .claude/ecosystems/bash.yaml"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "echo x | tee -a /w/.claude/ecosystems/markdown.yaml"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "cp plugin/reference/ecosystems/markdown.yaml .claude/ecosystems/markdown.yaml"}}]}]} | ||
| {"pass": [{"answer": [{"tool": "Bash", "input": {"command": "ls .claude/ecosystems/ 2>/dev/null"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "cat /tmp/w/.claude/ecosystems/bash.yaml 2>&1"}}], "why": "a read, not a write"}], "fail": [{"answer": [{"tool": "Bash", "input": {"command": "printf 'globs: [\"*.sh\"]\\n' > .claude/ecosystems/bash.yaml"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "echo x | tee -a /w/.claude/ecosystems/markdown.yaml"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "cp /tmp/markdown.yaml .claude/ecosystems/markdown.yaml"}}]}]} |
2 changes: 1 addition & 1 deletion
2
plugins/toolchain/evals/ck-unsure-run-is-unattended/samples/no-record-write.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"pass": [{"answer": [{"tool": "Bash", "input": {"command": "ls .claude/ecosystems/ 2>/dev/null"}}]}], "fail": [{"answer": [{"tool": "Bash", "input": {"command": "printf 'globs: [\"*.md\"]\\n' >> .claude/ecosystems/markdown.yaml"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "cp plugin/reference/ecosystems/markdown.yaml .claude/ecosystems/"}}]}]} | ||
| {"pass": [{"answer": [{"tool": "Bash", "input": {"command": "ls .claude/ecosystems/ 2>/dev/null"}}]}], "fail": [{"answer": [{"tool": "Bash", "input": {"command": "printf 'globs: [\"*.md\"]\\n' >> .claude/ecosystems/markdown.yaml"}}]}, {"answer": [{"tool": "Bash", "input": {"command": "cp /tmp/markdown.yaml .claude/ecosystems/"}}]}]} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.