Repository navigation
feat(review): read review-digest config from the config-cascade layers - #18082
melodic-automation-lanes[bot] wants to merge 3 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane run report
Run 44966576871, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
| "digest_max_files": { | ||
| "type": "number", | ||
| "title": "Digest max files", | ||
| "description": "The digest files trigger fires when a pull request changes more files than this; shipped default 5. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option.", | ||
| "min": 0 | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.digest_max_files: flag, new number option; its value reaches digest-policy.mjs, decide.mjs and digest-migrate.mjs through a --setting shell argument, so it is not inert
It has no default, so an unset option widens nothing. userConfigLayer accepts only ^(0|[1-9]\d*)$ as a count. Anything else stays a string and is rejected as invalid.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/.claude-plugin/plugin.json:139, plugins/review/lib/review-digest.mjs:131
This flag states facts and asks for no change, so it goes to a person to accept. What the code shows: the option is type number with min 0 and no default, so an unset option adds no layer; userConfigLayer turns the value into a number only when it matches ^(0|[1-9]\d*)$, and anything else stays a string that isCount rejects with an 'invalid max_files; key ignored' warning. A number value holds no shell quote character, and the skill text now also says to escape any ' inside the single-quoted --setting argument.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
| "digest_max_changed_lines": { | ||
| "type": "number", | ||
| "title": "Digest max changed lines", | ||
| "description": "The digest changed-lines trigger fires when additions plus deletions exceed this; shipped default 200. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option.", | ||
| "min": 0 | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.digest_max_changed_lines: flag, new number option; its value reaches digest-policy.mjs, decide.mjs and digest-migrate.mjs through a --setting shell argument, so it is not inert
It has no default, so an unset option widens nothing. It gets the same whole-number check in userConfigLayer as digest_max_files.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/.claude-plugin/plugin.json:145, plugins/review/lib/review-digest.mjs:131
This flag states facts and asks for no change, so it goes to a person to accept. What the code shows: the option is type number with min 0 and no default, so an unset option adds no layer; it gets the same whole-number check in userConfigLayer as digest_max_files, and a value that fails it is rejected by isCount with an 'invalid max_changed_lines; key ignored' warning. A number value holds no shell quote character, and the skill text now also says to escape any ' inside the single-quoted --setting argument.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
|
claude-security-review reviewed Security review: PR #18082 (review-digest settings read from the config-cascade layers)I read all 13 changed files in No CRITICAL finding and no hold. The change touches no trust control: no trusted-actor list, no token request or broker rule, no kill switch, no merge hold, no What I checked at this head
FindingsSix
Spend: none. The change adds no lane runs, models or billed resources. critical-findings: 0 Manifest lines (6)
|
|
claude-review reviewed Code review: review-digest config-cascade layers (#18082), head
|
|
The unattended merge path is about to arm native auto-merge at head |
|
Merge-Risk: max=HIGH demote=true head=502e0382a6fc5a0ac4d5753d43a4484df73fd568 rubric=10.4.6 rater=claude-opus-5-5 checker=claude-opus-5-5 |
Lane run report
Run 44970097612, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66eNQy Lane-Thread: PRRT_kwDOTCGFQM66eNQ4 Lane-Thread: PRRT_kwDOTCGFQM66eNQ7 Lane-Thread: PRRT_kwDOTCGFQM66eNQ_ Lane-Thread: PRRT_kwDOTCGFQM66eNRD Lane-Thread: PRRT_kwDOTCGFQM66eOLu Lane-Thread: PRRT_kwDOTCGFQM66eOLy Lane-Thread: PRRT_kwDOTCGFQM66eOL0
Lane run report
Run 44967575837, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 1 of max 4 on 65d93a1. |
Lane run report
Run 44970097612, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=18082 -f activity=address-feedback |
Lane run report
Run 44970097612, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane run report
Run 44969251244, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/resolve-conflicts
Lane run report
Run 44969251244, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
| "digest_policy": { | ||
| "type": "string", | ||
| "title": "Digest policy", | ||
| "description": "When /review:explain-change offers a change digest: off, offer (the shipped default: when a trigger fires) or always (build at the ready flip). Empty (default): unset. The docs/conventions/review-digest YAML files win over this option." | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.digest_policy: flag, new free-form string option (no options list); the model puts its value into a single-quoted --setting shell argument in explain-change and setup
This is still not a selector, because it has no options list. It is not inert either, because the value reaches a command the session runs. Since the last review, the skill text tells the model to write each ' as '\'' (explain-change/SKILL.md, setup/SKILL.md). That escaping is still left to the model, though, and digest-policy.mjs checks the value against off/offer/always only after the shell has parsed the command. The value comes from the user's own settings, so the impact is self-inflicted. The key has no default, so an unset option widens nothing. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/.claude-plugin/plugin.json:134, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/setup/SKILL.md:65, plugins/review/skills/explain-change/scripts/digest-policy.mjs:93
The flag is accurate as written. digest_policy is a free-form string with no options list. The skill texts tell the model to place the value inside a single-quoted --setting argument and to escape each single quote as the four-character sequence quote-backslash-quote-quote. digest-policy.mjs checks the value against off, offer and always only after the shell has parsed the command. The quoting therefore depends on the model following the skill text, and reading the code cannot settle whether that is acceptable. The value comes from the user's own settings, so any impact is self-inflicted. The reviewer asks for an owner's answer rather than another bot resolution. Two possible fixes are adding an options list (off, offer, always) to this key, or passing the settings through a file or stdin instead of shell arguments. Either is a design choice for the owner, and the second spans three skills and their scripts. Leaving this open for a person.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
| "digest_blast_radius": { | ||
| "type": "string", | ||
| "title": "Digest blast radius (JSON)", | ||
| "description": "Assessed blast radius levels that fire the digest offer, as a JSON list of LOW, MEDIUM, HIGH and CRITICAL; shipped default [\"HIGH\",\"CRITICAL\"]. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option." | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.digest_blast_radius: flag, new free-form JSON string option that the model puts into a single-quoted --setting shell argument
The key has no default. userConfigLayer parses the value as JSON, and the VALID check rejects anything outside LOW/MEDIUM/HIGH/CRITICAL (plugins/review/lib/review-digest.mjs). Both checks run only after the shell has parsed the command the model wrote. The new '\'' rule in the three skill texts narrows the quoting gap, but the model still has to apply it. The value comes from the user's own settings. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/.claude-plugin/plugin.json:151, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/reviewer-media/SKILL.md:43, plugins/review/lib/review-digest.mjs:143
The flag is accurate as written. digest_blast_radius is a free-form JSON string. review-digest.mjs parses it and rejects any level outside LOW, MEDIUM, HIGH and CRITICAL, but only after the shell has parsed the single-quoted --setting argument the model writes. Safe quoting relies on the model applying the escape rule in the skill texts. The value comes from the user's own settings. This is a security flag that reading the code cannot settle, and the reviewer asks for an owner's answer, not a bot resolution. One fix is passing the settings through a file or stdin instead of shell arguments, which spans three skills and their scripts. That is a design decision for the owner, so I'm leaving this open for a person.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
| "digest_risk_paths": { | ||
| "type": "string", | ||
| "title": "Digest risk paths (JSON)", | ||
| "description": "Path globs that fire the digest offer when a changed path matches, as a JSON list of at most 64 globs of at most 256 characters each, e.g. [\"db/migrations/*\"]. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option." | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.digest_risk_paths: flag, new free-form JSON string option (path globs) that the model puts into a single-quoted --setting shell argument
The key has no default. Inside the script, isGlobs allows at most 64 globs of at most 256 characters each. The value is still free text that the model places inside '...' in a bash command. A glob such as ["it's/**"] relies on the model applying the new '\'' rule. The value comes from the user's own settings, so the impact is self-inflicted. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/.claude-plugin/plugin.json:156, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/setup/SKILL.md:65
The flag is accurate as written. digest_risk_paths is a free-form JSON list of globs. The script limits it to at most 64 globs of at most 256 characters each, but the raw value still goes inside a single-quoted bash argument the model writes. A glob containing a single quote is only safe if the model applies the escape rule in the skill texts. The value comes from the user's own settings, so any impact is self-inflicted. This is a security flag that reading the code cannot settle, and the reviewer asks for an owner's answer. Removing the dependence on model-applied quoting, for example by passing settings through a file or stdin, is a cross-skill design change for the owner. Leaving this open for a person.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
| "digest_opt_in_label": { | ||
| "type": "string", | ||
| "title": "Digest opt-in label", | ||
| "description": "The pull request label that fires the digest offer; shipped default explain-change. Empty (default): unset, so to turn the label trigger off, set opt_in_label: \"\" in a docs/conventions/review-digest YAML file. Those files win over this option." | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.digest_opt_in_label: flag, new free-form string option that the model puts into a single-quoted --setting shell argument
The key has no default. The opt_in_label check accepts any string, so the script narrows nothing. A label containing a ' stays safe only if the model applies the '\'' rule added to the skill texts. The value comes from the user's own settings. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/.claude-plugin/plugin.json:161, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/setup/SKILL.md:65
The flag is accurate as written. digest_opt_in_label is a free-form string, and the opt_in_label check accepts any string, so the script does not narrow it. A label containing a single quote stays safe only if the model applies the escape rule in the skill texts when it builds the --setting argument. The value comes from the user's own settings. This is a security flag that reading the code cannot settle, and the reviewer asks for an owner's answer, not a bot resolution. Possible fixes are constraining the label's characters in the script, or passing settings through a file or stdin. Both are design decisions for the owner, so I'm leaving this open for a person.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
|
pr-unblock / address-feedback finished round 2 of max 4 on c4bf31a. |
Refs: #18006
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Remaining work
Not verified
Fix
Verification
The runner ran each check from the base copy against 502e038:
The run reports:
multipleallows a string array;optionsneeds a default or required; values reach skill content only through ${user_config.KEY} substitution, and plugin option…Left out: the items under Not verified.
Related
#18006