Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
bump: minor
---

### Added

- **Review-digest options.** The review plugin has six new options: `digest_policy`, `digest_max_files`, `digest_max_changed_lines`, `digest_blast_radius`, `digest_risk_paths` and `digest_opt_in_label`. The two list options each take a JSON list. Together they are the per-user layer of the review-digest settings that `/review:explain-change` and `/review:reviewer-media` read. The personal override is now `docs/conventions/review-digest.local.yaml` ([#18006](https://github.com/melodic-software/claude-code-plugins/issues/18006)).
- **`/review:setup` moves the old digest files.** `check` names each old file it finds and where each of its settings goes. `apply` previews the move and acts only after a yes. It adds the old personal settings that `docs/conventions/review-digest.local.yaml` lacks, keeps the ones that file already sets, checks that each moved value resolves the same, and then deletes `.claude/review-digest.local.json`. For `~/.claude/review-digest.json` it lists each option still unset. Once every old setting is covered by an option, it deletes the file after a yes.

### Deprecated

- **`~/.claude/review-digest.json` and `.claude/review-digest.local.json`.** Both files are still read while they exist, each just below the layer that replaces it, so a new layer wins on each key it sets. Each run prints one warning per old file that names `/review:setup apply`. A later release stops reading them.
4 changes: 2 additions & 2 deletions docs/contracts/config-cascade/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ its conformance cell.
| `multi-agent` | no-floor | team: `<home>/multi-agent.yaml`, `<home>` being the bound convention home, else `docs/conventions`; user-global `~/.claude/multi-agent.yaml`; personal override `.claude/multi-agent.local.yaml` | all three | later layer | per-key | the team file is validated by `plugins/multi-agent/schemas/multi-agent.schema.json`. The old team locations, the config block in `docs/conventions/multi-agent.md` and `.claude/multi-agent.yaml`, are not read; `/multi-agent:setup check` names each one it finds, and while the YAML is absent the first `/multi-agent:setup apply --layer team` write copies one old file's keys into it, leaving that file in place. Rule 5 holds: a layer that does not parse or names another schema is skipped and named, and an unknown key or a value outside its allowed set is reported and inert. No policy-floor class: every key is a routing dial, and turning the fan-out guard off is a documented opt-in on whichever layer sets it. Keys owned by [`plugins/multi-agent/reference/config.md`](../../../plugins/multi-agent/reference/config.md); resolved by `plugins/multi-agent/scripts/resolve-roles.sh`, read by `/multi-agent:route`, `/multi-agent:audit-defaults` and `/multi-agent:setup check`; written by `/multi-agent:setup apply` (any of the three layers, after a preview and an explicit yes) |
| `multi-agent` (`verification`) | team-only | team: `<home>/multi-agent.yaml`, the role map's team file (`<home>` from the convention-home pointer line at the default branch, default `docs/conventions`; schema `plugins/multi-agent/schemas/multi-agent.schema.json`) | team only | the team file at the default branch; a skill entry over the plugin value; an invalid value resolves `standard`, no value `light` | per-key | conforms to the [location axis](#location-of-the-team-layer-a-docs-convention-file-or-claudename) ([ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md)); no `userConfig` option, and the user-global and personal files do not set it: `scripts/resolve-roles.sh` passes over the keys in every layer, and `/multi-agent:setup apply` writes them to the team layer only. `verification_skills.<skill>` beats `verification`. `lib/read-verification.sh` (the plugin's copy) reads the file at `origin/<default>` after a fetch, never the working tree, so a branch cannot lower its own level, and names a working-tree copy that gives another level. An invalid value or a file that does not parse is named and resolves `standard`; no value resolves `light`. Levels owned by [`docs/contracts/verification-level/README.md`](../verification-level/README.md); read by `/multi-agent:audit-defaults`. This row covers `verification` and `verification_skills` |
| `external-agents` | no-floor | team: `<home>/external-agents.yaml` (schema `plugins/external-agents/schemas/external-agents.schema.json`), `<home>` being the bound convention home, else `docs/conventions`; personal override `<home>/external-agents.local.yaml` | plugin default, team and personal override; no `userConfig` option yet | later layer | per-key | conforms: read through `resolve` by `plugins/external-agents/scripts/lib/config.mjs` over the bundled `defaults.json`; no `~/.claude` file and no `.claude/*.local` file. Declared exception: `<product>.binary_path` is honored only from the personal override and only when absolute, since it picks the executable that runs; a team value is reported and ignored |
| `review-digest` | no-floor | team: `docs/conventions/review-digest.yaml`; user-global `~/.claude/review-digest.json`; personal override `.claude/review-digest.local.json` | all three | later layer; `--policy` over every layer | per-key (lists replace) | conforms to the [location axis](#location-of-the-team-layer-a-docs-convention-file-or-claudename): the team layer is the YAML file alone, the [ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md) team file. Rule 5 holds: a layer that does not parse is named and skipped, an invalid value is reported and ignored, and an unknown key is inert. Declared deviation from the per-layer verdicts: an untracked team layer is reported and resolved as absent rather than stopping, and a personal override that is not gitignored is reported and still applied, since every key only decides when a reader is offered a view. No policy-floor class. Keys owned by [`review-digest`](../../conventions/review-digest.md); resolved by `plugins/review/lib/review-digest.mjs` for `/review:explain-change` (whose `digest-policy.mjs` also reads the `rendered-views` `medium` key) and `/review:reviewer-media` |
| `review-digest` | no-floor | per user: the review plugin's `digest_*` options; team: `docs/conventions/review-digest.yaml`; personal override `docs/conventions/review-digest.local.yaml` | `userConfig` + team + personal override | later layer; `--policy` over every layer | per-key (lists replace) | conforms to the [location axis](#location-of-the-team-layer-a-docs-convention-file-or-claudename): the team layer is the YAML file alone, the [ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md) team file. Dual-read window: the old `~/.claude/review-digest.json` and `.claude/review-digest.local.json` are still read just below the layer that replaces each, with one warning per file per run naming `/review:setup apply`, which moves them. Rule 5 holds: a layer that does not parse is named and skipped, an invalid value is reported and ignored, and an unknown key is inert. Declared deviation from the per-layer verdicts: an untracked team layer is reported and resolved as absent rather than stopping, and a personal override that is not gitignored is reported and still applied, since every key only decides when a reader is offered a view. No policy-floor class. Keys owned by [`review-digest`](../../conventions/review-digest.md); resolved by `plugins/review/lib/review-digest.mjs` for `/review:explain-change` (whose `digest-policy.mjs` also reads the `rendered-views` `medium` key) and `/review:reviewer-media` |
| `reviewer-media` | team-only for `voice_command` and `allow_unattended_paid_voice`, no-floor otherwise | team: `docs/conventions/reviewer-media.yaml` read at the pull request's `baseRefOid`; personal override `docs/conventions/reviewer-media.local.yaml`, applied only when untracked | team and personal override; no user-global file | later layer; `--policy` over every layer | per-key (lists replace) | conforms: read through `readLayers` with the base-commit team text; an invalid team value falls to the default, an invalid personal value leaves the team value, and a team-only key in the personal override is refused. Keys owned by [`reviewer-media`](../../conventions/reviewer-media.md); resolved by `plugins/review/skills/reviewer-media/scripts/decide.mjs` |
| `playbooks` | no-floor | team: `docs/conventions/playbooks.yaml` (schema `plugins/playbooks/schemas/playbooks.schema.json`); per user: the plugin's `userConfig` | `userConfig` + team | later layer | per-key | declared deviation: a [ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md) team file with no `~/.claude/<name>` file and no personal override. An unexpanded `${user_config.<key>}` reads as unset, and a value outside a key's list is named and resolves the default. Keys owned by the plugin's `reference/config.md`; read in the skill text of `/playbooks:fable-5` (`described_problem`), which reports the supplying layer |
| `playbooks` (`verification`) | team-only | team: `docs/conventions/playbooks.yaml`, whatever the convention home, beside the plugin's other keys (schema `plugins/playbooks/schemas/playbooks.schema.json`) | team only | the team file at the default branch; a skill entry over the plugin value; an invalid value resolves `standard`, no value `light` | per-key | conforms to the [location axis](#location-of-the-team-layer-a-docs-convention-file-or-claudename) ([ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md)); no `userConfig` option, no `~/.claude` file and no personal override. `verification_skills.<skill>` beats `verification`. `lib/read-verification.sh` (the plugin's copy) reads the file at `origin/<default>` after a fetch, never the working tree, so a branch cannot lower its own level, and names a working-tree copy that gives another level. An invalid value or a file that does not parse is named and resolves `standard`; no value resolves `light`. Levels owned by [`docs/contracts/verification-level/README.md`](../verification-level/README.md); read by `/playbooks:fable-5`, which passes `--file docs/conventions/playbooks.yaml` so the reader skips the convention home. This row covers `verification` and `verification_skills` |
Expand Down Expand Up @@ -791,7 +791,7 @@ model-run skill with no reader script, so the rule lives in the skill text.
| `docs-naming` | implements | `scripts/resolve-config.sh` sources its `lib/config-root.sh` copy and classifies `--root` (else the git toplevel of the current directory) against `--home`; `paths` reports team and personal override as not-applicable at a `home` or `non-repo` root |
| `ai-slop` | implements | `skills/audit/scripts/detect.sh` sources its `lib/config-root.sh` copy and classifies its root (`CLAUDE_PROJECT_DIR`, else `git rev-parse --show-toplevel`, else `pwd`) before the team and personal override reads; a team or personal override file that is the user-global file is read once; the `verification` key is read by `lib/read-verification.sh`, which sources the plugin's `lib/config-root.sh` |
| `multi-agent` | implements | `scripts/resolve-roles.sh` sources its `lib/config-root.sh` copy and classifies `--root` (else `CLAUDE_PROJECT_DIR`, else the git toplevel) against `--home`; team and personal override are reported not-applicable at a `home` or `non-repo` root, and a team or personal override path that is the user-global file is read once; `/multi-agent:setup apply --layer team` and `--layer local` refuse at a `home` or `non-repo` root; the `verification` key is read by `lib/read-verification.sh`, which sources the plugin's `lib/config-root.sh` |
| `review-digest` | implements | `lib/review-digest.mjs` classifies its root inline (`CLAUDE_PROJECT_DIR`, else the nearest directory holding `.git`) and skips team and personal override when the root is the home directory, above it, or not a working tree, and any team or personal override path that is the user-global file; it does not source the resolver |
| `review-digest` | implements | `lib/review-digest.mjs` classifies its root inline (`CLAUDE_PROJECT_DIR`, else the nearest directory holding `.git`) and skips team and personal override when the root is the home directory, above it, or not a working tree, and an old personal override path that is the old user-global file; it does not source the resolver |
| `reviewer-media` | implements | `skills/reviewer-media/scripts/decide.mjs` classifies its root with `lib/review-digest.mjs` `projectRootOf` (`CLAUDE_PROJECT_DIR`, else the nearest directory holding `.git`) and skips team and personal override when the root is the home directory, above it, or not a working tree |
| `attribution` | implements | `skills/audit/scripts/lib.sh` sources its `lib/config-root.sh` copy; `cfg_layers_init` skips team and personal override unless `config_root_classify` returns `repo`, and skips a layer that `config_root_paths_same` matches to the user-global file; the `verification` key is read by `lib/read-verification.sh`, which sources the plugin's `lib/config-root.sh` |
| `code-metrics` | not yet | `scripts/resolve-config.py`: `git rev-parse --show-toplevel`, else the current directory; `CLAUDE_PROJECT_DIR` is not consulted |
Expand Down
25 changes: 16 additions & 9 deletions docs/conventions/review-digest.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,23 +50,30 @@ Layers resolve per the
[config-cascade convention](../contracts/config-cascade/README.md), per-key override, a later layer replacing
an earlier one key by key:

1. user-global `~/.claude/review-digest.json`
1. `userConfig`: the review plugin's options `digest_policy`, `digest_max_files`,
`digest_max_changed_lines`, `digest_blast_radius` and `digest_risk_paths` (each a JSON list),
and `digest_opt_in_label`. An empty option is unset, so an empty `opt_in_label` needs a file.
2. team: `docs/conventions/review-digest.yaml`, the only team file. An invalid value in it falls to
the layer below.
3. personal override `.claude/review-digest.local.json`
3. personal override `docs/conventions/review-digest.local.yaml`, the same keys as the team file.

A plugin still reads, or reports as retired, the `.claude/` paths named here; until the plugin migrates, keep config where this page says it is read, then move it where [config locations](../contracts/config-cascade/locations.md) says.
The old files `~/.claude/review-digest.json` and `.claude/review-digest.local.json` are still read
while they exist, each just below the layer that replaces it, so the new layer wins on each key it
sets. Every run warns once per old file and names `/review:setup apply`, which moves the old file's
settings to its new home, checks they resolve the same, and deletes it. A later release stops
reading the old paths.

The result names the layer that supplied each value (`team <commit>:<path>`, `user-global <path>`,
`personal-override <path>`, or `default`). Quote glob values in the YAML file (`"**/hooks/**"`),
since a plain `*` opens an alias.
The result names the layer that supplied each value (`team <commit>:<path>`, `userConfig`,
`personal-override <path>`, `user-global <path>` for the old per-user file, or `default`). Quote
glob values in the YAML files (`"**/hooks/**"`), since a plain `*` opens an alias.

The team layer, and the rendered-views team file, are read from the pull request's base commit
(`baseRefOid`), never the working tree, so a checked-out pull request cannot configure its own
digest. When that commit is not in the clone, the team layer is skipped with a warning. The
personal override applies only when untracked, in any letter case, and is refused when `.claude` or the
personal override is a symlink, or when `.claude` is itself a tracked entry (a submodule or a tracked file) or
holds a `.git`; one that is not gitignored is reported and still applied.
personal override applies only when untracked, in any letter case, and is refused when the file or
a directory on its path is a symlink, or when such a directory is itself a tracked entry (a
submodule or a tracked file) or holds a `.git`; one that is not gitignored is reported and still
applied.

An explicit `--policy` argument beats every layer. An unknown key is inert, and an invalid value
is reported and ignored. Lists replace whole. No key is policy-floor: each one only decides when a
Expand Down
32 changes: 32 additions & 0 deletions plugins/review/.claude-plugin/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,38 @@
"description": "Your /review:council selection rules as a JSON list, the same shape as council_rules in docs/conventions/review.yaml. Empty (default): the repository's rules or none. A repository's value wins; invalid JSON is reported and ignored.",
"default": ""
},
"digest_policy": {
"type": "string",
"title": "Digest policy",
"description": "When /review:explain-change offers a change digest: off, offer (the shipped default: when a trigger fires) or always (build at the ready flip). Empty (default): unset. The docs/conventions/review-digest YAML files win over this option."
},
Comment thread
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines +134 to +138

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest userConfig.digest_policy: flag, new free-form string option (no options list); the model puts its value into a single-quoted --setting shell argument in explain-change and setup

This is still not a selector, because it has no options list. It is not inert either, because the value reaches a command the session runs. Since the last review, the skill text tells the model to write each ' as '\'' (explain-change/SKILL.md, setup/SKILL.md). That escaping is still left to the model, though, and digest-policy.mjs checks the value against off/offer/always only after the shell has parsed the command. The value comes from the user's own settings, so the impact is self-inflicted. The key has no default, so an unset option widens nothing. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.

severity: IMPORTANT

claude-lane: claude-security-review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:134, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/setup/SKILL.md:65, plugins/review/skills/explain-change/scripts/digest-policy.mjs:93

The flag is accurate as written. digest_policy is a free-form string with no options list. The skill texts tell the model to place the value inside a single-quoted --setting argument and to escape each single quote as the four-character sequence quote-backslash-quote-quote. digest-policy.mjs checks the value against off, offer and always only after the shell has parsed the command. The quoting therefore depends on the model following the skill text, and reading the code cannot settle whether that is acceptable. The value comes from the user's own settings, so any impact is self-inflicted. The reviewer asks for an owner's answer rather than another bot resolution. Two possible fixes are adding an options list (off, offer, always) to this key, or passing the settings through a file or stdin instead of shell arguments. Either is a design choice for the owner, and the second spans three skills and their scripts. Leaving this open for a person.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:134, plugins/review/skills/explain-change/scripts/digest-policy.mjs:93, plugins/review/lib/review-digest.mjs:45, plugins/review/skills/setup/SKILL.md:65

A trusted person accepted this flag on the thread. They found no exposed surface outside the operator and want no change unless automation or untrusted input ever fills these options. Following that decision, this round makes no edit. I checked that condition. No workflow under .github sets any digest option, so the value comes only from the operator's own plugin settings. The facts the flag states still hold: digest_policy is a free-form string with no options list and no default, the skill texts tell the model to escape each single quote inside the --setting argument, and the script checks the value against off, offer and always only after the shell has parsed the command. This lane has no disposition that closes a thread on an owner's acceptance, so it records UNCERTAIN and leaves the thread open for that person to resolve.

"digest_max_files": {
"type": "number",
"title": "Digest max files",
"description": "The digest files trigger fires when a pull request changes more files than this; shipped default 5. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option.",
"min": 0
},
Comment on lines +139 to +144

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest userConfig.digest_max_files: flag, new number option; its value reaches digest-policy.mjs, decide.mjs and digest-migrate.mjs through a --setting shell argument, so it is not inert

It has no default, so an unset option widens nothing. userConfigLayer accepts only ^(0|[1-9]\d*)$ as a count. Anything else stays a string and is rejected as invalid.

severity: IMPORTANT

claude-lane: claude-security-review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:139, plugins/review/lib/review-digest.mjs:131

This flag states facts and asks for no change, so it goes to a person to accept. What the code shows: the option is type number with min 0 and no default, so an unset option adds no layer; userConfigLayer turns the value into a number only when it matches ^(0|[1-9]\d*)$, and anything else stays a string that isCount rejects with an 'invalid max_files; key ignored' warning. A number value holds no shell quote character, and the skill text now also says to escape any ' inside the single-quoted --setting argument.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:139, plugins/review/lib/review-digest.mjs:131, plugins/review/lib/review-digest.mjs:48

A trusted person accepted this flag on the thread. They found no exposed surface outside the operator and want no change unless automation or untrusted input ever fills these options. Following that decision, this round makes no edit. I checked that condition. No workflow under .github sets any digest option, so the value comes only from the operator's own plugin settings. The facts the flag states still hold: digest_max_files is a number option with min 0 and no default, userConfigLayer turns the value into a number only when it matches a whole-number pattern, and isCount rejects anything else. This lane has no disposition that closes a thread on an owner's acceptance, so it records UNCERTAIN and leaves the thread open for that person to resolve.

"digest_max_changed_lines": {
"type": "number",
"title": "Digest max changed lines",
"description": "The digest changed-lines trigger fires when additions plus deletions exceed this; shipped default 200. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option.",
"min": 0
},
Comment on lines +145 to +150

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest userConfig.digest_max_changed_lines: flag, new number option; its value reaches digest-policy.mjs, decide.mjs and digest-migrate.mjs through a --setting shell argument, so it is not inert

It has no default, so an unset option widens nothing. It gets the same whole-number check in userConfigLayer as digest_max_files.

severity: IMPORTANT

claude-lane: claude-security-review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:145, plugins/review/lib/review-digest.mjs:131

This flag states facts and asks for no change, so it goes to a person to accept. What the code shows: the option is type number with min 0 and no default, so an unset option adds no layer; it gets the same whole-number check in userConfigLayer as digest_max_files, and a value that fails it is rejected by isCount with an 'invalid max_changed_lines; key ignored' warning. A number value holds no shell quote character, and the skill text now also says to escape any ' inside the single-quoted --setting argument.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:145, plugins/review/lib/review-digest.mjs:131, plugins/review/lib/review-digest.mjs:48

A trusted person accepted this flag on the thread. They found no exposed surface outside the operator and want no change unless automation or untrusted input ever fills these options. Following that decision, this round makes no edit. I checked that condition. No workflow under .github sets any digest option, so the value comes only from the operator's own plugin settings. The facts the flag states still hold: digest_max_changed_lines is a number option with min 0 and no default, and it gets the same whole-number check in userConfigLayer and isCount as digest_max_files. This lane has no disposition that closes a thread on an owner's acceptance, so it records UNCERTAIN and leaves the thread open for that person to resolve.

"digest_blast_radius": {
"type": "string",
"title": "Digest blast radius (JSON)",
"description": "Assessed blast radius levels that fire the digest offer, as a JSON list of LOW, MEDIUM, HIGH and CRITICAL; shipped default [\"HIGH\",\"CRITICAL\"]. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option."
},
Comment thread
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines +151 to +155

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest userConfig.digest_blast_radius: flag, new free-form JSON string option that the model puts into a single-quoted --setting shell argument

The key has no default. userConfigLayer parses the value as JSON, and the VALID check rejects anything outside LOW/MEDIUM/HIGH/CRITICAL (plugins/review/lib/review-digest.mjs). Both checks run only after the shell has parsed the command the model wrote. The new '\'' rule in the three skill texts narrows the quoting gap, but the model still has to apply it. The value comes from the user's own settings. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.

severity: IMPORTANT

claude-lane: claude-security-review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:151, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/reviewer-media/SKILL.md:43, plugins/review/lib/review-digest.mjs:143

The flag is accurate as written. digest_blast_radius is a free-form JSON string. review-digest.mjs parses it and rejects any level outside LOW, MEDIUM, HIGH and CRITICAL, but only after the shell has parsed the single-quoted --setting argument the model writes. Safe quoting relies on the model applying the escape rule in the skill texts. The value comes from the user's own settings. This is a security flag that reading the code cannot settle, and the reviewer asks for an owner's answer, not a bot resolution. One fix is passing the settings through a file or stdin instead of shell arguments, which spans three skills and their scripts. That is a design decision for the owner, so I'm leaving this open for a person.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:151, plugins/review/lib/review-digest.mjs:132, plugins/review/lib/review-digest.mjs:54

A trusted person accepted this flag on the thread. They found no exposed surface outside the operator and want no change unless automation or untrusted input ever fills these options. Following that decision, this round makes no edit. I checked that condition. No workflow under .github sets any digest option, so the value comes only from the operator's own plugin settings. The facts the flag states still hold: digest_blast_radius is a free-form JSON string with no default, and userConfigLayer parses it and the VALID checks reject any level outside LOW, MEDIUM, HIGH and CRITICAL, both after the shell has parsed the --setting argument. This lane has no disposition that closes a thread on an owner's acceptance, so it records UNCERTAIN and leaves the thread open for that person to resolve.

"digest_risk_paths": {
"type": "string",
"title": "Digest risk paths (JSON)",
"description": "Path globs that fire the digest offer when a changed path matches, as a JSON list of at most 64 globs of at most 256 characters each, e.g. [\"db/migrations/*\"]. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option."
},
Comment thread
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines +156 to +160

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest userConfig.digest_risk_paths: flag, new free-form JSON string option (path globs) that the model puts into a single-quoted --setting shell argument

The key has no default. Inside the script, isGlobs allows at most 64 globs of at most 256 characters each. The value is still free text that the model places inside '...' in a bash command. A glob such as ["it's/**"] relies on the model applying the new '\'' rule. The value comes from the user's own settings, so the impact is self-inflicted. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.

severity: IMPORTANT

claude-lane: claude-security-review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:156, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/setup/SKILL.md:65

The flag is accurate as written. digest_risk_paths is a free-form JSON list of globs. The script limits it to at most 64 globs of at most 256 characters each, but the raw value still goes inside a single-quoted bash argument the model writes. A glob containing a single quote is only safe if the model applies the escape rule in the skill texts. The value comes from the user's own settings, so any impact is self-inflicted. This is a security flag that reading the code cannot settle, and the reviewer asks for an owner's answer. Removing the dependence on model-applied quoting, for example by passing settings through a file or stdin, is a cross-skill design change for the owner. Leaving this open for a person.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:156, plugins/review/lib/review-digest.mjs:53

A trusted person accepted this flag on the thread. They found no exposed surface outside the operator and want no change unless automation or untrusted input ever fills these options. Following that decision, this round makes no edit. I checked that condition. No workflow under .github sets any digest option, so the value comes only from the operator's own plugin settings. The facts the flag states still hold: digest_risk_paths is a free-form JSON list with no default, isGlobs allows at most 64 globs of at most 256 characters each, and a glob holding a single quote is safe only when the model applies the escape rule in the skill texts. This lane has no disposition that closes a thread on an owner's acceptance, so it records UNCERTAIN and leaves the thread open for that person to resolve.

"digest_opt_in_label": {
"type": "string",
"title": "Digest opt-in label",
"description": "The pull request label that fires the digest offer; shipped default explain-change. Empty (default): unset, so to turn the label trigger off, set opt_in_label: \"\" in a docs/conventions/review-digest YAML file. Those files win over this option."
},
Comment thread
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines +161 to +165

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest userConfig.digest_opt_in_label: flag, new free-form string option that the model puts into a single-quoted --setting shell argument

The key has no default. The opt_in_label check accepts any string, so the script narrows nothing. A label containing a ' stays safe only if the model applies the '\'' rule added to the skill texts. The value comes from the user's own settings. The earlier thread was resolved by a bot, not answered by an owner, so this flag line stays.

severity: IMPORTANT

claude-lane: claude-security-review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:161, plugins/review/skills/explain-change/SKILL.md:29, plugins/review/skills/setup/SKILL.md:65

The flag is accurate as written. digest_opt_in_label is a free-form string, and the opt_in_label check accepts any string, so the script does not narrow it. A label containing a single quote stays safe only if the model applies the escape rule in the skill texts when it builds the --setting argument. The value comes from the user's own settings. This is a security flag that reading the code cannot settle, and the reviewer asks for an owner's answer, not a bot resolution. Possible fixes are constraining the label's characters in the script, or passing settings through a file or stdin. Both are design decisions for the owner, so I'm leaving this open for a person.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/review/.claude-plugin/plugin.json:161, plugins/review/lib/review-digest.mjs:60

A trusted person accepted this flag on the thread. They found no exposed surface outside the operator and want no change unless automation or untrusted input ever fills these options. Following that decision, this round makes no edit. I checked that condition. No workflow under .github sets any digest option, so the value comes only from the operator's own plugin settings. The facts the flag states still hold: digest_opt_in_label is a free-form string with no default, the opt_in_label check accepts any string, and a label holding a single quote is safe only when the model applies the escape rule in the skill texts. This lane has no disposition that closes a thread on an owner's acceptance, so it records UNCERTAIN and leaves the thread open for that person to resolve.

"medium": {
"type": "string",
"title": "Preferred delivery medium",
Expand Down
Loading
Loading