Repository navigation
feat(review): read review-digest config from the config-cascade layers #18082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
502e038
65d93a1
c4bf31a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Added | ||
|
|
||
| - **Review-digest options.** The review plugin has six new options: `digest_policy`, `digest_max_files`, `digest_max_changed_lines`, `digest_blast_radius`, `digest_risk_paths` and `digest_opt_in_label`. The two list options each take a JSON list. Together they are the per-user layer of the review-digest settings that `/review:explain-change` and `/review:reviewer-media` read. The personal override is now `docs/conventions/review-digest.local.yaml` ([#18006](https://github.com/melodic-software/claude-code-plugins/issues/18006)). | ||
| - **`/review:setup` moves the old digest files.** `check` names each old file it finds and where each of its settings goes. `apply` previews the move and acts only after a yes. It adds the old personal settings that `docs/conventions/review-digest.local.yaml` lacks, keeps the ones that file already sets, checks that each moved value resolves the same, and then deletes `.claude/review-digest.local.json`. For `~/.claude/review-digest.json` it lists each option still unset. Once every old setting is covered by an option, it deletes the file after a yes. | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - **`~/.claude/review-digest.json` and `.claude/review-digest.local.json`.** Both files are still read while they exist, each just below the layer that replaces it, so a new layer wins on each key it sets. Each run prints one warning per old file that names `/review:setup apply`. A later release stops reading them. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -131,6 +131,38 @@ | |
| "description": "Your /review:council selection rules as a JSON list, the same shape as council_rules in docs/conventions/review.yaml. Empty (default): the repository's rules or none. A repository's value wins; invalid JSON is reported and ignored.", | ||
| "default": "" | ||
| }, | ||
| "digest_policy": { | ||
| "type": "string", | ||
| "title": "Digest policy", | ||
| "description": "When /review:explain-change offers a change digest: off, offer (the shipped default: when a trigger fires) or always (build at the ready flip). Empty (default): unset. The docs/conventions/review-digest YAML files win over this option." | ||
| }, | ||
|
Comment on lines
+134
to
+138
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.digest_policy: flag, new free-form string option (no options list); the model puts its value into a single-quoted --setting shell argument in explain-change and setup This is still not a selector, because it has no severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence: |
||
| "digest_max_files": { | ||
| "type": "number", | ||
| "title": "Digest max files", | ||
| "description": "The digest files trigger fires when a pull request changes more files than this; shipped default 5. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option.", | ||
| "min": 0 | ||
| }, | ||
|
Comment on lines
+139
to
+144
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.digest_max_files: flag, new number option; its value reaches It has no default, so an unset option widens nothing. severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence: |
||
| "digest_max_changed_lines": { | ||
| "type": "number", | ||
| "title": "Digest max changed lines", | ||
| "description": "The digest changed-lines trigger fires when additions plus deletions exceed this; shipped default 200. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option.", | ||
| "min": 0 | ||
| }, | ||
|
Comment on lines
+145
to
+150
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.digest_max_changed_lines: flag, new number option; its value reaches It has no default, so an unset option widens nothing. It gets the same whole-number check in severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence: |
||
| "digest_blast_radius": { | ||
| "type": "string", | ||
| "title": "Digest blast radius (JSON)", | ||
| "description": "Assessed blast radius levels that fire the digest offer, as a JSON list of LOW, MEDIUM, HIGH and CRITICAL; shipped default [\"HIGH\",\"CRITICAL\"]. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option." | ||
| }, | ||
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines
+151
to
+155
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.digest_blast_radius: flag, new free-form JSON string option that the model puts into a single-quoted --setting shell argument The key has no default. severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence: |
||
| "digest_risk_paths": { | ||
| "type": "string", | ||
| "title": "Digest risk paths (JSON)", | ||
| "description": "Path globs that fire the digest offer when a changed path matches, as a JSON list of at most 64 globs of at most 256 characters each, e.g. [\"db/migrations/*\"]. Empty (default): unset. The docs/conventions/review-digest YAML files win over this option." | ||
| }, | ||
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines
+156
to
+160
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.digest_risk_paths: flag, new free-form JSON string option (path globs) that the model puts into a single-quoted --setting shell argument The key has no default. Inside the script, severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence: |
||
| "digest_opt_in_label": { | ||
| "type": "string", | ||
| "title": "Digest opt-in label", | ||
| "description": "The pull request label that fires the digest offer; shipped default explain-change. Empty (default): unset, so to turn the label trigger off, set opt_in_label: \"\" in a docs/conventions/review-digest YAML file. Those files win over this option." | ||
| }, | ||
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
Comment on lines
+161
to
+165
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.digest_opt_in_label: flag, new free-form string option that the model puts into a single-quoted --setting shell argument The key has no default. The severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value comes only from the operator's own plugin settings, the script validates it after parsing, and a quoting slip breaks only the operator's own command. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills these options, pass the settings through a file or stdin instead of a shell argument.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence: |
||
| "medium": { | ||
| "type": "string", | ||
| "title": "Preferred delivery medium", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.