Repository navigation
feat(improvement): read config from the config-cascade layers - #18083
melodic-automation-lanes[bot] wants to merge 3 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane run report
Run 44967145953, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
| "churn_exclude": { | ||
| "type": "string", | ||
| "title": "Churn exclusions", | ||
| "description": "Extra ERE patterns, one per entry, left out of churn counting in every repository. Unioned with the repository's own patterns.", | ||
| "multiple": true | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.churn_exclude: flag, free ERE patterns put into a shell command
This new option is a string with multiple: true, so it is not a selector and not inert. Its entries are joined into $excludes and passed to grep -Ev "$excludes" in skills/find/context/hotspots.md:57 and :122. The value comes from the user's own plugin settings, and the base ~/.claude/improvement.md already supplied the same key, so this flag shows no new attacker path. It is reported under the manifest default-deny rule.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/improvement/skills/find/context/hotspots.md:81
This is a manifest default-deny flag on a security surface. The finding names no fix, and it says the value comes from the user's own settings and shows no new attacker path. A list of free ERE patterns cannot become a selector, so only a person can accept the flag. In the same round as the churn_window fix, the hotspot recipe now leaves out any churn_exclude entry that holds a single quote or a newline and reports it as malformed with its layer. Such an entry could otherwise break out of the single-quoted excludes assignment that feeds grep -Ev. Left open for a person to accept the remaining flag.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The patterns come only from the operator's own plugin settings, the same per-user scope the old ~/.claude/improvement.md supplied, and the recipe now drops an entry holding a single quote or newline. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills this option, pass it through a file instead of a shell string.
| "find_open_item_cap": { | ||
| "type": "number", | ||
| "title": "Open item cap", | ||
| "description": "Lowers the cap on open items per source label that unattended /improvement:find files under. Applies only when below the repository's cap. 0 stops unattended filing.", | ||
| "min": 0 | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.find_open_item_cap: flag, a number that reaches a command argument
This key is a guard. It has no manifest default, and the cascade lets userConfig only lower the team cap (reference/config.md Merge semantics). So the guard is not widened. It is still not inert, because the value reaches a command: /work-items:track list --label "<source label>" --state open --limit <open cap + 1> in skills/find/context/unattended.md:190-191. The value is a number with min: 0, so it carries little injection risk. It is reported under the manifest default-deny rule.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/improvement/.claude-plugin/plugin.json:40, plugins/improvement/reference/config.md:79
The finding reports the key under the manifest default-deny rule. It also says the guard is not widened: the merge semantics in reference/config.md let userConfig only lower the cap. The value is a number with min 0, so it reaches the --limit argument only as a number. No change to the manifest turns a number cap into a selector or makes it inert. This is a security-surface policy flag, and accepting it is a person's decision. Left open for that decision.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The value is a number with min 0 from the operator's own settings, and the cascade lets it only lower the team cap, so the guard is not widened. No permission, trust boundary or cost changes.
| "find_scope": { | ||
| "type": "string", | ||
| "title": "Unattended scope", | ||
| "description": "What an unattended run scans: repo, or a target /improvement:find accepts. Unset: repo." | ||
| }, |
There was a problem hiding this comment.
manifest userConfig.find_scope: flag, a free string that sets what an unattended run scans
This key is a string with no options, and its value is "repo, or a target /improvement:find accepts". It is substituted into skills/find/SKILL.md:159 and skills/setup/SKILL.md:50, and sets the scan target of unattended runs (skills/find/context/unattended.md:30). The value comes from the user's own settings, and the base ~/.claude/improvement.md already supplied the same key, so this flag shows no new attacker path. It is reported under the manifest default-deny rule.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/improvement/.claude-plugin/plugin.json:70, plugins/improvement/reference/config.md:130
The finding reports find_scope under the manifest default-deny rule and says it shows no new attacker path, since the base user-global file already supplied the same key. The key's contract allows repo or any target /improvement:find accepts, so it cannot be cut down to an options list without dropping a documented use. The finding names no fix. Accepting a free-string flag on a security surface is a person's decision, so the thread is left open for it.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. find_scope comes only from the operator's own settings, the same per-user scope the old ~/.claude/improvement.md supplied, and it picks what the operator's own run scans. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills it, restrict it to the targets /improvement:find accepts.
| "evidence_sources_file": { | ||
| "type": "file", | ||
| "title": "Evidence sources file", | ||
| "description": "A YAML file of yours whose evidence_sources key declares Tier 2 telemetry sources (MCP server, kind, scope, hints) for every repository. A repository's own declarations merge over it per source name." | ||
| } |
There was a problem hiding this comment.
manifest userConfig.evidence_sources_file: flag, a file-typed path that names the MCP servers Tier 2 queries
This new file option is a filesystem path the skills Read (skills/find/SKILL.md:161, skills/setup/SKILL.md:52, :71). Its evidence_sources entries name the MCP telemetry servers /improvement:find queries for Tier 2 evidence, and they merge under the repository's own declarations per source name. The path and the file both come from the user's own settings, and the base user-global evidence_sources map came from the same per-user scope, so this flag shows no new attacker path. It is reported under the manifest default-deny rule, because a path-valued key is never a selector or an inert key.
severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/improvement/.claude-plugin/plugin.json:80, plugins/improvement/reference/config.md:36
The finding reports the file-typed evidence_sources_file option under the manifest default-deny rule, because a path-valued key is never a selector or inert. It also says the path and file come from the user's own settings, the same per-user scope as the old user-global evidence_sources map. reference/config.md explains why this option exists: userConfig cannot hold the nested evidence_sources map. Removing the option would drop that layer. The finding names no fix, so accepting the flag is a person's decision. Left open for it.
There was a problem hiding this comment.
Accepted by the PR lane session. Exposed surface today: none outside the operator. The path and the file come only from the operator's own settings, the same per-user scope as the old user-global evidence_sources map, and they name the MCP servers the operator already configured. No permission, trust boundary or cost changes.
|
claude-security-review reviewed Security review (incremental:
|
|
claude-review reviewed Code review (incremental, 296e865 → 17ee001, blocking only)This review covers only the 15 files changed since Prior findings in this push
New findings
Closing issue #18011
Other changes in this push: the Loosened checks: none found. The grader moves in the run-cap and personal-cap cases follow the new paths the issue asks for. They don't weaken what is graded. The prompt carried no Spend: Embedded text: none found in the PR context. Advisory and manifest lines (1)
Verifier dropped 0 of 2 candidates. |
Lane run report
Run 44970408312, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane run report
Run 44968699035, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66eRSd Lane-Thread: PRRT_kwDOTCGFQM66eRSi Lane-Thread: PRRT_kwDOTCGFQM66eRXA Lane-Thread: PRRT_kwDOTCGFQM66eRXF Lane-Thread: PRRT_kwDOTCGFQM66eRXK Lane-Thread: PRRT_kwDOTCGFQM66eRXP
Lane run report
Run 44968246584, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane run report
Run 44968699035, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 1 of max 4 on 17ee001. |
Lane run report
Run 44970408312, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=18083 -f activity=address-feedback |
Lane run report
Run 44968246584, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 2 of max 4 on 17ee001. |
…e_band options The find config cases (open-cap-stops, run-cap-from-config, personal-cap-cannot-raise) seeded no git tree, so under the root rule in reference/config.md the team and personal layers were not applicable and their layer graders could not pass. Each scaffold now commits the seeded tree as seed-ledger-cli.sh does, the personal case ignores docs/conventions/**/*.local.* so its file gets the ignored verdict, and the three cases allow Bash, as the setup-check cases do, so the model can run git rev-parse --show-toplevel and the tracked and ignored checks. claude plugin validate rejected the manifest: a userConfig field with options needs a default among them or required: true, and a plugin whose options break that rule fails to load. find_size_band has no manifest default by design (an unset option lets the old ~/.claude/improvement.md supply the value), so options is dropped; find reports any other value as malformed. Comment lint flagged the scaffold headers and the retirements.yaml header: the scaffold intent lives in each case's description, the retirements contract in docs/contracts/retired-conventions/README.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtUnz4WHB5auUnwQYq7
Closes #18011
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
Fix
Verification
The runner ran each check from the base copy against 296e865:
The run reports:
Left out: the items under Not verified.
Related
#18011