Repository navigation
feat(improvement): read config from the config-cascade layers #18083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - Config resolves through the config-cascade layers: the plugin default, new `userConfig` options (one per key, with `evidence_sources_file` naming a YAML file of your Tier 2 sources), the team `docs/conventions/improvement.yaml`, then the gitignored `docs/conventions/improvement.local.yaml`. A schema for both files ships at `schemas/improvement.schema.json` ([#18011](https://github.com/melodic-software/claude-code-plugins/issues/18011)). | ||
| - `~/.claude/improvement.md`, `.claude/improvement.md` and `.claude/improvement.local.md` are still read while they exist, wherever the new location does not supply that layer. Each run prints one warning naming the old file, its new location and `/improvement:setup apply`. The two repository files are retirement records `improvement-r001` and `improvement-r002` in the new `retirements.yaml`, checked by the bundled `lib/check-retirements.sh`. | ||
| - `/improvement:setup check` names each old file, and when the new location also exists it lists the old keys that do not apply. `apply` shows a preview, and after your yes moves the old file's settings to the new location, checks they resolve the same values, then deletes the old file. Settings from `~/.claude/improvement.md` move to `userConfig` through `/plugin configure`; the old file is deleted on a later `apply` in a fresh session, once the options read the same values. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,5 +19,67 @@ | |
| ], | ||
| "metadata": { | ||
| "category": "quality" | ||
| }, | ||
| "userConfig": { | ||
| "churn_window": { | ||
| "type": "string", | ||
| "title": "Churn window", | ||
| "description": "Your git log --since window for the hotspot recipe, such as 90 days ago. A repository's docs/conventions/improvement.yaml overrides it. Unset: 90 days ago." | ||
| }, | ||
| "churn_exclude": { | ||
| "type": "string", | ||
| "title": "Churn exclusions", | ||
| "description": "Extra ERE patterns, one per entry, left out of churn counting in every repository. Unioned with the repository's own patterns.", | ||
| "multiple": true | ||
| }, | ||
|
Comment on lines
+29
to
+34
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.churn_exclude: flag, free ERE patterns put into a shell command This new option is a severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The patterns come only from the operator's own plugin settings, the same per-user scope the old ~/.claude/improvement.md supplied, and the recipe now drops an entry holding a single quote or newline. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills this option, pass it through a file instead of a shell string. |
||
| "churn_exclude_defaults": { | ||
| "type": "boolean", | ||
| "title": "Exclude mechanical files from churn", | ||
| "description": "false drops the lockfiles, generated output, snapshots and vendored trees resolved from each repository, leaving only declared patterns. Unset: true." | ||
| }, | ||
| "find_open_item_cap": { | ||
| "type": "number", | ||
| "title": "Open item cap", | ||
| "description": "Lowers the cap on open items per source label that unattended /improvement:find files under. Applies only when below the repository's cap. 0 stops unattended filing.", | ||
| "min": 0 | ||
| }, | ||
|
Comment on lines
+40
to
+45
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.find_open_item_cap: flag, a number that reaches a command argument This key is a guard. It has no manifest default, and the cascade lets severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The value is a number with min 0 from the operator's own settings, and the cascade lets it only lower the team cap, so the guard is not widened. No permission, trust boundary or cost changes. |
||
| "find_run_item_cap": { | ||
| "type": "number", | ||
| "title": "Items filed per unattended run", | ||
| "description": "Where the adaptive per-run filing cap starts. Unset: 3.", | ||
| "min": 1 | ||
| }, | ||
| "find_run_item_cap_floor": { | ||
| "type": "number", | ||
| "title": "Per-run filing cap floor", | ||
| "description": "Lowest value the per-run filing cap adapts to. Unset: 1.", | ||
| "min": 1 | ||
| }, | ||
| "find_run_item_cap_ceiling": { | ||
| "type": "number", | ||
| "title": "Per-run filing cap ceiling", | ||
| "description": "Highest value the per-run filing cap adapts to. Unset: 5.", | ||
| "min": 1 | ||
| }, | ||
| "find_size_band": { | ||
| "type": "string", | ||
| "title": "Unattended size band", | ||
| "description": "Candidate sizes an unattended run ranks: all, small, medium or large. Unset: all." | ||
| }, | ||
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
|
||
| "find_scope": { | ||
| "type": "string", | ||
| "title": "Unattended scope", | ||
| "description": "What an unattended run scans: repo, or a target /improvement:find accepts. Unset: repo." | ||
| }, | ||
|
Comment on lines
+69
to
+73
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.find_scope: flag, a free string that sets what an unattended run scans This key is a severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. find_scope comes only from the operator's own settings, the same per-user scope the old ~/.claude/improvement.md supplied, and it picks what the operator's own run scans. No permission, trust boundary or cost changes. Condition: if automation or untrusted input ever fills it, restrict it to the targets /improvement:find accepts. |
||
| "find_suppress_dismissed": { | ||
| "type": "boolean", | ||
| "title": "Suppress dismissed candidates", | ||
| "description": "Whether an unattended run leaves out candidates an operator dismissed before. Unset: true." | ||
| }, | ||
| "evidence_sources_file": { | ||
| "type": "file", | ||
| "title": "Evidence sources file", | ||
| "description": "A YAML file of yours whose evidence_sources key declares Tier 2 telemetry sources (MCP server, kind, scope, hints) for every repository. A repository's own declarations merge over it per source name." | ||
| } | ||
|
Comment on lines
+79
to
+83
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. manifest userConfig.evidence_sources_file: flag, a file-typed path that names the MCP servers Tier 2 queries This new severity: IMPORTANT claude-lane: claude-security-review
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pr-unblock / address-feedback: UNCERTAIN, left open Evidence:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted by the PR lane session. Exposed surface today: none outside the operator. The path and the file come only from the operator's own settings, the same per-user scope as the old user-global evidence_sources map, and they name the MCP servers the operator already configured. No permission, trust boundary or cost changes. |
||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.