Skip to content

chore(ecosystems): drop tool versions copied from ci-workflows - #209

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/ecosystems-drop-copied-versions
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/ecosystems-drop-copied-versions

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#17

Summary

Row 2 of control-hub#17: the ecosystem records copied tool versions from ci-workflows by hand, and the copies drift. The owner decided (2026-11-18) to delete the copies and keep a tool-pin entry only where this repository owns the version.

Fix

Tool File Decision Source of the version
lychee cross-cutting.yaml (tool-pin, install-hint, a recheck sentence in notes) deleted ci-workflows .github/actions/lychee-offline/action.yml:20-27 (version, sha256 defaults); pr-require-checks.yml passes only config:
gitleaks cross-cutting.yaml (tool-pin, install-hint, version and checksum line refs in notes) deleted ci-workflows .github/actions/gitleaks/action.yml:50-57; no job here installs gitleaks
node typescript.yaml (tool-pin, install-hint) kept, equals .node-version (24) .node-version:1, which pr-require-checks.yml reads via node-version-file; not a sync destination here (standards distribution/sync-manifest.yml: codex-plugins does not take node-runtime)
none bash.yaml, markdown.yaml, python.yaml, yaml.yaml removed empty tool-pin: {} n/a

Hints now name the action that pins the version, without the number. Commands, globs, opt-ins and probes are unchanged.

Not a plugin component change, so the documentation preflight in AGENTS.md does not apply; the contract read is claude-code-plugins docs/contracts/ecosystem-commands/README.md (checked 2026-11-18): tool-pin is optional and only feeds a drift warning in /toolchain:lint.

Verification

  • yq . parses all six records.
  • The repository has no schema check for .claude/ecosystems/ (git grep check-jsonschema finds none).
  • Pre-commit, commit-msg and pre-push hooks passed.
  • Left out: npm test and npm run validate, which read no .claude/ecosystems/ file; CI runs them.

Related

  • melodic-software/control-hub#17

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The lychee and gitleaks versions and checksums in cross-cutting.yaml
restated ci-workflows' composite-action defaults, which this repository
does not override. Hints now name that source without the number, and
empty tool-pin keys are gone. node stays pinned: .node-version is owned
here.

Refs melodic-software/control-hub#17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 23:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T23:25:41.709869Z 63e4aa4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 63e4aa4647f683b02bb04fb044f472aa68515098: 0 finding(s), 0 as inline comments.

No findings. The change deletes tool versions copied from ci-workflows out of the ecosystem records, and I found nothing a careful reviewer would block.

  • What I checked: all five diffs in .claude-lane/pr.diff, and .claude/ecosystems/cross-cutting.yaml and typescript.yaml as committed at the PR head (git show HEAD:). git grep shows nothing in the repository that reads the removed tool-pin keys, and the head's cross-cutting.yaml has no dangling tool-pin reference left in its notes.
  • Working tree: the checkout I reviewed had uncommitted modifications that look like the reverse of the diff. I ignored them and judged the committed head.
  • Closing issue: the PR only references control-hub#17 and does not close it, so the context file has no closing-issue section and there are no acceptance criteria to check.
  • tool-pin removals:
    • Dropping tool-pin for lychee and gitleaks, and the empty tool-pin: {} in four other records, only affects the optional drift warning in /toolchain:lint. The PR cites the contract for that. I did not read the contract myself.
    • The commands, globs, opt-ins and the local gitleaks scan are unchanged.
    • The node pin is kept in typescript.yaml and equals .node-version.
  • Loosened-check criterion: I applied it and none of its nine loosening kinds is hit. The removed tool-pin data feeds a warning about copied data, not a CI test, lint or scanner. The wrapper supplied no loosened_check_verdict: or loosened_check_patterns: lines, so I used fail and no consumer entries. The decision-record citation was not checked. Loosened-check verdict: not applicable, no loosening found.
  • Path-scoped rules: .claude/rules/pr-body-contract.md has no paths: frontmatter, so it matches no changed file as a path rule. The PR body follows its structure: Refs: line, Summary, Fix, Verification, Related.
  • Verification: I ran no tests. The Verification section of the PR body is the author's claim and I did not confirm it.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 63e4aa4647f683b02bb04fb044f472aa68515098: 0 finding(s), 0 as inline comments.

No security issues found in this pull request.

The change touches only five .claude/ecosystems/*.yaml toolchain records. It removes the tool-pin keys, drops the copied lychee and gitleaks versions and SHA-256 checksums from install-hint and notes, and replaces them with pointers to the ci-workflows action defaults.

  • No executable surface. The diff has no workflow, script, manifest, token, hook or trusted-path change. All five records still have check-cmd, fix-cmd and code-fix-cmd set to null, or the unchanged lychee and gitleaks commands, so no command runs differently.
  • Pin removal is not a control weakening. The only remaining tool-pin references in the repository are the other ecosystem records (typescript.yaml) and the notes text this diff removes. Nothing here verifies a checksum. The removed checksums were informational text. CI's own pin and SHA-256 verification stay in the ci-workflows actions (lychee-offline, gitleaks), which this diff does not touch. The local install hints name package managers (winget, brew) and are not checksum-gated, so no verification step is lost.
  • No standing instruction is removed. The deleted notes text is provenance commentary, and the records still state that no secret scan is switched off.

The PR CONTEXT:, SETTLED THREADS: and PRIOR FINDINGS: files were not supplied, so nothing was settled or prior. Not consulted: the instruction exception register, because no standing instruction was deleted.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit 5ea1b61 into main Nov 18, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the chore/ecosystems-drop-copied-versions branch November 18, 2026 23:32
kyle-sexton added a commit to melodic-software/cursor-plugins that referenced this pull request Nov 18, 2026
Refs: melodic-software/control-hub#17

## Summary

Row 2 of control-hub#17: the ecosystem records copied tool versions from
ci-workflows by hand, and the copies drift. The owner decided
(2026-11-18) to delete the copies and keep a `tool-pin` entry only where
this repository owns the version. Here none is owned, so every pin goes.

## Fix

| Tool | File | Decision | Source of the version |
|---|---|---|---|
| lychee | `cross-cutting.yaml` (`tool-pin`, `install-hint`, a recheck
sentence in `notes`) | deleted | ci-workflows
`.github/actions/lychee-offline/action.yml:20-27` (`version`, `sha256`
defaults); `pr-require-checks.yml:254-256` passes only `config:` |
| typos | `cross-cutting.yaml` (`tool-pin`, `install-hint`) | deleted |
ci-workflows `.github/actions/typos/action.yml:44-49`;
`pr-require-checks.yml:271-274` passes only `config:` and `hidden:` |
| gitleaks | `cross-cutting.yaml` (`tool-pin`, `install-hint`, version
and checksum line refs in `notes`) | deleted | ci-workflows
`.github/actions/gitleaks/action.yml:50-57`; no job here installs
gitleaks |
| none | `bash.yaml`, `markdown.yaml`, `powershell.yaml`,
`typescript.yaml`, `yaml.yaml` | removed empty `tool-pin: {}` | n/a |

Hints now name the action that pins the version, without the number.
Commands, globs, opt-ins and notes on unpinned tools (shellcheck,
PSScriptAnalyzer) are unchanged.

## Verification

- `yq .` parses all six records.
- The repository has no schema check for `.claude/ecosystems/` (`git
grep` finds no reader outside the records).
- Pre-commit, commit-msg and pre-push hooks passed.
- Left out: the CI suites (shellcheck, sync-local, manifest validation),
which read no `.claude/ecosystems/` file; CI runs them.

## Related

- melodic-software/control-hub#17
- melodic-software/codex-plugins#209 makes the same change there.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant