Skip to content

ci: remove the ci-status mirror job now that CI Status is required - #150

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror
Nov 13, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: step C of the owner-approved ci-status to CI Status required-check rename (owner decision "go w/ recommendations": remove the mirror jobs after a day of merges under the new requirement).

Summary

The org ci-gate ruleset has required CI Status since 2026-11-12T17:07Z. This removes the report-ci-status mirror job, which repeated the gate's conclusion under the old check name ci-status, and the alias-jobs: ci-status input that made the aggregate ignore it. Present-tense docs and comments now name CI Status as the required check.

Fix

  • .github/workflows/pr-require-checks.yml: the report-ci-status job and the alias-jobs: ci-status input with its comment are removed; the comment above the gate job names CI Status as the context the ruleset requires (it said ci-status was one of four). The job key ci-status is unchanged.
  • AGENTS.md ("Pull requests"), .github/dependabot.yml and .github/workflows/pr-automerge-dependabot.yml: comments and prose name CI Status.

Verification

  • actionlint on both edited workflows: no findings (this repository has no .github/actionlint.yaml).
  • alias-jobs is optional in the pinned aggregate-results (ac4d878): default: ''.
  • No test or script in this repository references report-ci-status, alias-jobs or the job list (git grep).

Related

Follow-ups

These are managed by the standards sync and were left unedited; they need a melodic-software/standards change:

  • Pre-existing (advisory): REVIEW.md:89,91 name ci-status as the check a Dependabot pull request merges on.
  • Pre-existing (advisory): .github/workflows/pr-check-managed-files-hosted.yml:21 names ci-status as the aggregate.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. Remove the `report-ci-status` job, which repeated the
gate's conclusion under the old check name `ci-status`, and the
`alias-jobs: ci-status` input with its comment. The gate job's comment,
AGENTS.md, the Dependabot config and the Dependabot automerge comment now
name `CI Status` as the required check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T20:44:59.393636Z 5e1d49d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 5e1d49d66e7d407df330caea982e32732f601a4b: 0 finding(s), 0 as inline comments.

No security findings.

I read the whole 4-file diff. It renames ci-status to CI Status in comments and docs (.github/dependabot.yml, .github/workflows/pr-automerge-dependabot.yml, AGENTS.md). It also removes the report-ci-status mirror job and the alias-jobs: ci-status input in .github/workflows/pr-require-checks.yml.

The workflow change touches a merge hold, because pr-require-checks.yml's ci-status hold steps are a named hold path. I checked what it can let through:

  • The CI Status job and its needs: list of all six lanes are unchanged. Its aggregate-results step still receives results: ${{ join(needs.*.result, ' ') }}, and the strictness settings (skipped counts as red, rerun-contract-only-siblings) are untouched.
  • The removed job only echoed the result of needs.ci-status.result and exited non-zero on failure. It held permissions: {}, took no secrets and had no untrusted input, so it enforced nothing the CI Status job does not.
  • If the org ruleset still required the old lowercase ci-status context, the merge would block because the context never reports. It would not pass early, so this fails closed. Whether the ruleset requires CI Status is not visible from the diff. It is an operational matter and not a security one.
  • The change does not widen who is trusted, any token scope or permission, what untrusted text reaches a lane, or the kill switch. No plugin manifests changed.

Instruction-surface lens: the AGENTS.md edit is a rename only. It leaves what the instruction forbids unchanged.

manifest fields: none touched.
critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 5e1d49d66e7d407df330caea982e32732f601a4b: 0 finding(s), 0 as inline comments.

No findings. I reviewed the whole diff (4 files) and the PR context. I read the diff and grepped the repo; I did not run actionlint or any CI.

  • The report-ci-status job and the alias-jobs: ci-status input are removed together, so nothing is left dangling. The PR says alias-jobs defaults to '' in the pinned aggregate-results. I did not fetch that action to confirm, so that point is author-claimed.
  • The job key ci-status and the check name CI Status are unchanged. The remaining ci-status mentions in .github/workflows/pr-require-checks.yml (lines 22, 24, 52, 281, 288, 298, 320) refer to the job key, which still exists, so they are not stale.
  • The comment and prose edits in AGENTS.md, .github/dependabot.yml and .github/workflows/pr-automerge-dependabot.yml match the new required check name.
  • No manifests changed, so there are no manifest <field> lines.
  • The PR has no closing issue; it states a no-issue reason, so there are no criteria to check.

Pre-existing (advisory): REVIEW.md:89 and line 91 still name ci-status as the check Dependabot pull requests merge on. .github/workflows/pr-check-managed-files-hosted.yml:21 says the same. This change makes those mentions stale, but both files are managed by the standards sync. The PR already lists both as follow-ups.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit ea442ca into main Nov 13, 2026
12 checks passed
@kyle-sexton
kyle-sexton deleted the ci/remove-ci-status-mirror branch November 13, 2026 20:46
kyle-sexton added a commit to melodic-software/ci-runner that referenced this pull request Nov 13, 2026
)

No related issue: step C of the owner-approved `ci-status` to `CI
Status` required-check rename (owner decision "go w/ recommendations":
remove the mirror jobs after a day of merges under the new requirement).

## Summary

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. This removes the `report-ci-status` mirror job, which
repeated the gate's conclusion under the old check name `ci-status`, the
`alias-jobs: ci-status` input that made the aggregate ignore it, and the
test that pinned the mirror. Present-tense docs and comments now name
`CI Status` as the required check.

## Fix

- `.github/workflows/pr-require-checks.yml`: the `report-ci-status` job
and the `alias-jobs: ci-status` input with its comment are removed. The
job key `ci-status` is unchanged, and no workflow pin changed.
- `.github/scripts/workflow-pin-metadata.test.cjs`: the
"report-ci-status mirrors the gateway under its old check name" test is
removed with the job it pinned; the `ci-status` gateway test is
unchanged.
- `docs/conventions/source-control.yaml`, `docs/releases.md` and
`.github/workflows/pr-automerge-dependabot.yml`: name `CI Status` as the
required check.
- Left alone: `docs/adr/` and `release/dependency-drift-review.json`
(dated records).

## Verification

- `node --test .github/scripts/workflow-pin-metadata.test.cjs`: 5 tests,
5 pass.
- `actionlint` on both edited workflows with the repository's
`.github/actionlint.yaml`: no findings.
- `alias-jobs` is optional in the pinned `aggregate-results` (9bfbca8,
v0.73.0): `default: ''`.

## Related

- Same change in claude-code-plugins:
melodic-software/claude-code-plugins#16005, and in
melodic-software/codex-plugins#178, melodic-software/cursor-plugins#150
and melodic-software/songwriting#56.

## Follow-ups

These are managed by the standards sync and were left unedited; they
need a melodic-software/standards change:

- Pre-existing (advisory): `.claude/rules/pr-body-contract.md:3` says
"inside `ci-status`"; it should name `CI Status`.
- Pre-existing (advisory): `REVIEW.md:89,91` name `ci-status` as the
check a Dependabot pull request merges on.
- Pre-existing (advisory): `docs/standards/issue-tracker.md:30,101` name
`ci-status` as the required check.
- Pre-existing (advisory):
`.github/workflows/pr-check-managed-files-hosted.yml:21` names
`ci-status` as the aggregate.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant