Skip to content

ci: remove the ci-status mirror job now that CI Status is required - #553

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror
Nov 13, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: step C of the owner-approved ci-status to CI Status required-check rename (owner decision "go w/ recommendations": remove the mirror jobs after a day of merges under the new requirement).

Summary

The org ci-gate ruleset has required CI Status since 2026-11-12T17:07Z. This removes the report-ci-status mirror job, which repeated the gate's conclusion under the old check name ci-status, the alias-jobs: ci-status input that made the aggregate ignore it, and the test that pinned the mirror. Present-tense docs and comments now name CI Status as the required check.

Fix

  • .github/workflows/pr-require-checks.yml: the report-ci-status job and the alias-jobs: ci-status input with its comment are removed. The job key ci-status is unchanged, and no workflow pin changed.
  • .github/scripts/workflow-pin-metadata.test.cjs: the "report-ci-status mirrors the gateway under its old check name" test is removed with the job it pinned; the ci-status gateway test is unchanged.
  • docs/conventions/source-control.yaml, docs/releases.md and .github/workflows/pr-automerge-dependabot.yml: name CI Status as the required check.
  • Left alone: docs/adr/ and release/dependency-drift-review.json (dated records).

Verification

  • node --test .github/scripts/workflow-pin-metadata.test.cjs: 5 tests, 5 pass.
  • actionlint on both edited workflows with the repository's .github/actionlint.yaml: no findings.
  • alias-jobs is optional in the pinned aggregate-results (9bfbca8, v0.73.0): default: ''.

Related

Follow-ups

These are managed by the standards sync and were left unedited; they need a melodic-software/standards change:

  • Pre-existing (advisory): .claude/rules/pr-body-contract.md:3 says "inside ci-status"; it should name CI Status.
  • Pre-existing (advisory): REVIEW.md:89,91 name ci-status as the check a Dependabot pull request merges on.
  • Pre-existing (advisory): docs/standards/issue-tracker.md:30,101 name ci-status as the required check.
  • Pre-existing (advisory): .github/workflows/pr-check-managed-files-hosted.yml:21 names ci-status as the aggregate.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. Remove the `report-ci-status` job, which repeated the
gate's conclusion under the old check name `ci-status`, the
`alias-jobs: ci-status` input with its comment, and the test that pinned
the mirror job. The source-control convention, docs/releases.md and the
Dependabot automerge comment now name `CI Status` as the required check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T21:01:23.013136Z 673c5f9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 673c5f96403daf8de5a3496def4a493d5ec7adf2: 0 finding(s), 0 as inline comments.

Security review of PR #553 (head 673c5f9): no security findings.

The PR removes the report-ci-status mirror job, which published the old ci-status check name. It also removes the alias-jobs: ci-status input to aggregate-results, the test that pinned the mirror job, and renames ci-status to CI Status in comments and docs.

I read the whole diff and then the surrounding ci-status aggregation step in .github/workflows/pr-require-checks.yml. pr-require-checks.yml holds the ci-status hold steps, so I treated the change as a possible trust-control change.

  • Merge hold not weakened. The CI Status job still aggregates every lane result with treat-skipped-as: pass, yield-to-full-run and rerun-contract-only-siblings, and still runs under if: always(). Only the alias mirror is gone. Nothing was added that lets through anything the base stopped.
  • Fails closed. If a ruleset still required the old ci-status name, merges would be blocked, not allowed. The commit message says CI Status is now the required check. I did not read the ruleset, so I did not confirm that.
  • No new trust, token, or text surface. Removing a job that had permissions: {} and no secrets leaves the token scope unchanged. No new action, pin, input or untrusted-text path was added. The remaining aggregate-results pin (v0.73.0 SHA) is unchanged.
  • No instruction-surface deletions. No CLAUDE.md, AGENTS.md, rules, skill or hook content is touched. The docs/ and source-control.yaml edits only rename the check in comments and prose.
  • Settled threads, prior findings, PR context: none were supplied.

Not a security finding: release/dependency-drift-review.json:17 still says the v0.73.0 bump is needed for the "CI Status / ci-status alias pair". That is stale after this PR, but it is a historical rationale record and has no security impact.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 673c5f96403daf8de5a3496def4a493d5ec7adf2: 0 finding(s), 0 as inline comments.

No findings. I reviewed head 673c5f9 and found nothing to block or flag.

  • Mirror removal is complete. A repo-wide grep finds no remaining live reference to report-ci-status or alias-jobs. The only hits are the PR context, the diff, and the dated release/dependency-drift-review.json record, which the PR deliberately leaves alone.
  • Aggregation is unaffected. The ci-status job's needs list and its aggregate-results input list do not include the removed job. The ci-status gateway test, which checks that the job aggregates every declared dependency, still holds.
  • alias-jobs removal is safe, but I could not check the pin itself. The PR says alias-jobs defaults to '' in the pinned v0.73.0 aggregate-results. That is author-claimed and I did not check the action. Removing the input only makes sense once the mirror is gone, which this PR does.
  • Not run. The Node test run and actionlint results in the PR body are author-claimed. I did not run them. The test deletions match the removed job.
  • Closing issue. None; the PR uses No related issue: with a stated reason, so there are no acceptance criteria to check. The PR body contract is met: No related issue: line plus Summary, Fix, Verification and Related sections.
  • Stale comments. The PR's own Follow-ups already list the managed-file mentions of ci-status as a required check (REVIEW.md, docs/standards/issue-tracker.md, .claude/rules/pr-body-contract.md, pr-check-managed-files-hosted.yml). Comments in pr-require-checks.yml still say ci-status for the job, which keeps that key, so they are not wrong.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 91028c6 into main Nov 13, 2026
28 checks passed
@kyle-sexton
kyle-sexton deleted the ci/remove-ci-status-mirror branch November 13, 2026 21:03
kyle-sexton added a commit to melodic-software/standards that referenced this pull request Nov 13, 2026
)

No related issue: step C of the owner-approved `ci-status` to `CI
Status` required-check rename (owner decision "go w/ recommendations":
remove the mirror jobs after a day of merges under the new requirement).

## Summary

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. This removes this repository's own `report-ci-status`
mirror job, which repeated the gate's conclusion under the old check
name `ci-status`, and the `alias-jobs: ci-status` input that made the
aggregate ignore it. Nothing distributed to other repositories changes
here.

## Fix

- `.github/workflows/pr-require-checks.yml`: the `report-ci-status` job
and the `alias-jobs: ci-status` input with its comment are removed. The
job key `ci-status` is unchanged.
- Not changed, for a separate later change: everything the sync
distributes (`components/**`, `distribution/**`, `standards/**`), the
`report-ci-status` entry in the github-actions-conventions vocabulary's
`jobNameExceptions`, `naming-lint.test.mjs:304-307`,
`components/github-actions-conventions/README.md:92-95`,
`.claude/rules/pr-body-contract.md`, `REVIEW.md`, the issue-tracker
standard and `components/dependabot-policy/policy.json`.

## Verification

- `alias-jobs` is optional in the pinned `aggregate-results` (ac4d878):
`default: ''`.
- `naming-lint.mjs --root . --mode enforcing`: 25 findings, 0 blocking
(warnings only, all pre-existing missing display names).
- `node --test
components/github-actions-conventions/naming-lint.test.mjs`: 21 tests,
21 pass.
- `actionlint` on the workflow with `.github/actionlint.yaml`: no
findings.

## Related

- Same change in claude-code-plugins:
melodic-software/claude-code-plugins#16005; ci-runner:
melodic-software/ci-runner#553; ci-workflows:
melodic-software/ci-workflows#1086.

## Follow-ups

Left unedited here; they need the later distributed-files change in this
repository:

- Pre-existing (advisory):
`components/github-actions-conventions/vocabulary.json:307` keeps the
`report-ci-status` job-name exception, pinned by
`naming-lint.test.mjs:304-307` and described in
`components/github-actions-conventions/README.md:92-95`.
- Pre-existing (advisory): `.claude/rules/pr-body-contract.md` and
`REVIEW.md` name `ci-status` as the required check.
- Pre-existing (advisory): the issue-tracker standard and
`components/dependabot-policy/policy.json` name `ci-status`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant