Skip to content

style: apply the bash-format formatter to the tree - #176

Merged
kyle-sexton merged 1 commit into
mainfrom
style/bash-format-cleanup
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
style/bash-format-cleanup

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: formatter-only cleanup before this repository adopts the shared git hooks from claude-code-plugins.

Summary

Applies the bash-format formatter (shfmt, with this repository's .editorconfig) to the files it would rewrite, so the hook can be enabled next without mixing reformatting into later changes.

Fix

Formatter output only: byte for byte what the bash-format-remote-format job of the claude-code-plugins lefthook remote writes. No content change.

Verification

Dry run: in a throwaway clone of the default branch with the aggregate remote installed and every tracked file staged, each formatter job ran alone. This PR holds this job's rewrites and nothing else, and each file was unchanged on the default branch since that run. A follow-up PR adds this squash commit to .git-blame-ignore-revs and switches lefthook.yml to the aggregate remote.

Related

🤖 Generated with Claude Code

Formatter output only, from the claude-code-plugins bash-format git hook
(shfmt), so the hook can be enabled without mixing reformatting into
later changes. No content change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T09:58:06.265108Z efc9713 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed efc971355e576625b92bde0bf5a2c81b0a12631b: 0 finding(s), 0 as inline comments.

No findings. I read the full diff (.claude-lane/pr.diff) and the PR context.

What changed. The PR is a formatter-only pass (shfmt) over four shell files: .cursor/install.sh, scripts/check-docs-naming.sh, scripts/sync-local.sh and scripts/test-sync-local.sh. Every hunk is whitespace or line layout:

  • ;-joined statements are split onto separate lines.
  • case arms are re-indented.
  • A trailing \ || becomes || \n.
  • <<< "$parsed" becomes <<<"$parsed".
  • Continuation lines are re-indented.

Behaviour check.

  • The Python heredoc in scripts/sync-local.sh keeps its body byte-identical and its PY terminator at column 0.
  • The $( … )" wrapper is the only part that moved, and set -e propagation from a failing python3 is unchanged.
  • No commands, flags, quoting or control flow changed.
  • The two multi-line diff <(…) <(…) calls keep their line continuations.
  • .cursor/install.sh still tolerates a PowerShell install failure through the same || log … fallback.

Not run. The sandbox refused bash -n, the test suites and shellcheck, so I did not run any of them. The "no content change" claim rests on my reading of the diff and on the author's description, which I could not check.

Manifest items. None apply: no manifests changed.

Loosened check. The wrapper supplied no loosened_check_verdict: line, so I used the default (fail, no consumer entries). Nothing in this diff loosens a check.

Closing issue. None: the PR uses the "No related issue" escape.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed efc971355e576625b92bde0bf5a2c81b0a12631b: 0 finding(s), 0 as inline comments.

No security issues found. I read the whole diff, which covers .cursor/install.sh, scripts/check-docs-naming.sh, scripts/sync-local.sh and scripts/test-sync-local.sh. It is a formatting-only change from the bash formatter.

  • Semantics: the changes are whitespace, one statement per line, || moved to the end of the line, <<< spacing and case indentation. The case arms in check-docs-naming.sh and the --dry-run, --keep-clone and --no-update flag handling in sync-local.sh are unchanged. The $( … ) wrapper in sync-local.sh now spans several lines, but the python3 command and its quoted <<'PY' heredoc are unchanged. The PY terminator is still at column 0.
  • Quoting and paths: the quoting, argument passing and path-validation logic that the existing regression cases cover is untouched. No new inputs, network calls, secrets or permissions were introduced.
  • Trust controls and manifests: the diff touches no plugin manifest, workflow, trusted-path file, trust control or instruction file. The .cursor/install.sh change moves the || log … fallback onto the previous line without altering it.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit 410d843 into main Nov 18, 2026
12 checks passed
@kyle-sexton
kyle-sexton deleted the style/bash-format-cleanup branch November 18, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant