Skip to content

ci: move ci-status onto the shared report-ci-status composite - #178

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status-composite
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status-composite

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

No related issue: a rollout step of melodic-software/ci-workflows#1138, which stays open until every repository has migrated.

Summary

Rollout of ci-workflows#1138: the ci-status job now runs the shared report-ci-status composite (ci-workflows#1139, v0.76.0) instead of its own check-contract and aggregate-results steps. CI Status stays the job's name and the single required check. Worked examples copied: songwriting#75 and codex-plugins#208.

Fix

  • ci-status steps: one report-ci-status step (draft: allow, since the job had no draft refusal and the workflow has no ready_for_review trigger; treat-skipped-as at its default fail, the value set before; no exempt authors, as before), then a "Fail on the contract or draft policy" step that fails on any outcome other than success, so an empty or renamed output fails closed.
  • The composite step keeps the name Aggregate lane results, so a contract-only run still finds the writer step of a full run recorded before this change.
  • Comments describe what the composite fixes (yield-to-full-run: 'true', carry-forward-wait-seconds: '0', the values this job set before, action.yml L128-L129) instead of inputs the file no longer sets.
  • Concurrency: the fallback for a run with no pull request number (push to main, merge_group, workflow_dispatch) changes from github.ref to github.run_id, so every push to main keeps its own result instead of a newer push cancelling the older one. This matches the composite's reference copy. The comment that recorded the old github.ref decision is rewritten.
  • Job if: (!cancelled()), needs, permissions, runner and timeout are unchanged.
  • Lines: 39 removed, 41 added (git diff --numstat).

Verification

  • actionlint .github/workflows/pr-require-checks.yml: no findings.
  • Runs on this PR, all on head 2f2a1f7:
    • Full run, opened (draft, allowed as before): run 44390279944 passed.
    • do-not-merge added: run 44390727102, contract-only, failed: check-contract: this PR carries the 'do-not-merge' label, then the fail step exited 1.
    • Label removed, no push: run 44390874497, contract-only (every lane skipped), CI Status passed with the lanes verdict carried forward.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The contract check and lane aggregation become one report-ci-status step
pinned at ci-workflows v0.76.0, with a step that fails the job on the
contract or draft output. The draft policy stays allow. The push fallback
in the concurrency group moves from github.ref to github.run_id, so every
push to main keeps its own result.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 20:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T20:23:37.987430Z 2f2a1f7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 2f2a1f7badb14791284563b1b3e14f3724f0b436: 0 finding(s), 0 as inline comments.

Code review: PR #178 (move ci-status onto report-ci-status)

No findings. The diff touches one file, .github/workflows/pr-require-checks.yml. I read it against the PR body and AGENTS.md.

Limit of this review: I could not read the composite's action.yml at ebd0e3b (v0.76.0). gh api and WebFetch were both denied in this session. Two points rest on the PR's own description of the composite and are unverified:

  • The composite fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0'. This is the PR's claim, with a permalink to L128-L129 that I did not open.
  • report-ci-status exposes contract and draft outputs.

Worth a quick check by the author (not a finding): the new "Fail on the contract or draft policy" step fails on any contract or draft output other than success. The workflow also runs on push to main, merge_group and workflow_dispatch, where there is no pull request. If the composite reports skipped or leaves those outputs empty on non-PR events, that step would turn every main push and merge-queue run red. The PR's "Label proof: to be recorded below" is still empty, so a push or merge_group run is the evidence to attach. The sibling rollouts the PR cites (songwriting#75, codex-plugins#208) may already show how the composite behaves there.

Checked and fine:

  • The concurrency fallback moves from github.ref to github.run_id, and the rewritten comment matches the expression. The old comment's recorded github.ref decision is replaced, as the PR says.
  • The step keeps the name Aggregate lane results. The new id: report matches the steps.report.outputs.* references.
  • The job if, needs, permissions, runner and timeout are unchanged.
  • The composite is pinned to a full SHA with a version comment.
Advisory and manifest lines (0)

Loosened-check: Loosened-check verdict: fail (default; the wrapper supplied no loosened_check_verdict: line); patterns: 0. The wrapper wrote no loosened_check_decision_record: line, so the citation requirement was not checked.

  • The explicit yield-to-full-run, rerun-contract-only-siblings, carry-forward-wait-seconds and treat-skipped-as: fail inputs are removed and left to the composite's fixed values or defaults.
  • Per the PR, these stay at the previous values (treat-skipped-as stays fail), so I found no loosening. I could not confirm the defaults against the composite's source.

The closing-issue criteria do not apply: the PR links no issue ("No related issue"). Reading the settled-threads and prior-findings files was not needed, since the wrapper named neither.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 2f2a1f7badb14791284563b1b3e14f3724f0b436: 0 finding(s), 0 as inline comments.

No security findings.

Scope. The PR changes only .github/workflows/pr-require-checks.yml. It replaces the check-contract and aggregate-results composite actions with the single report-ci-status composite, and it changes the concurrency fallback from github.ref to github.run_id.

What I checked

  • Action pin. melodic-software/ci-workflows/.../report-ci-status is pinned to full commit SHA ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f (v0.76.0). The source is the same org-owned repository as before, so the pin is not loosened.
  • Trigger and permissions. The triggers are still pull_request, push to main, merge_group and workflow_dispatch. There is no pull_request_target or workflow_run. The workflow-level permissions: contents: read and the job-level ci-status permissions (contents: read, actions: write, pull-requests: write, statuses: write) are unchanged. No token scope grows.
  • Token handling.
    • The explicit token: ${{ github.token }} inputs were removed, so the composite now takes its default token. I did not fetch the composite's action.yml to confirm that default is github.token.
    • Fork pull requests still get a read-only token from GitHub under pull_request. The workflow's comments describe this and the diff does not change it.
  • Failure handling. The new Fail on the contract or draft policy step fails the job unless both the contract and draft outputs equal success. An empty or renamed output therefore fails closed. The step's if: is !cancelled() && (...), and ci-status is the single required check, so a failing contract still blocks the merge.
  • Draft policy. draft: allow is advisory only. GitHub does not merge draft pull requests, and the workflow has no draft-gating trigger.
  • Concurrency. The github.run_id fallback only means pushes to main no longer cancel each other. Pull-request grouping by number is unchanged. This is not a security issue.
  • Expressions. No github context value is interpolated into a run: block. The new run: step only echoes a constant string.

critical-findings: 0

Manifest lines (0)

Protected-class list: docs/contracts/instruction-exception-register/README.md was not consulted. The diff deletes no standing instruction, only workflow comments and steps.

@kyle-sexton kyle-sexton added do-not-merge Hard merge gate: do not merge while applied. and removed do-not-merge Hard merge gate: do not merge while applied. labels Nov 18, 2026
@kyle-sexton
kyle-sexton merged commit da1db9d into main Nov 18, 2026
34 of 35 checks passed
@kyle-sexton
kyle-sexton deleted the ci/report-ci-status-composite branch November 18, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant