Repository navigation
fix(pr-convention-policy): recognize callers on the report-ci-status composite - #1066
Conversation
…composite report-ci-status runs check-contract through $/ at the commit a caller pins, so a caller on it gates with check-contract at that SHA. The pin scan matched only a direct check-contract call site and reported every migrated caller (songwriting, codex-plugins, ci-workflows' own $/ call) as running no contract artifact. detectArtifactPin now accepts either composite, pinned or local, and checks check-contract at that commit. Closes #1065 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Review summaryThe code change is correct. Finding (cross-file, no changed line can carry it)The closing issue's second fix item is not in this PR, but the PR says
To fix it, either include the test change here, or change Other notes
Verifier dropped 0 of 1 candidates. |
|
claude-security-review reviewed Security review: PR #1066 (head 3a7eb23)No security findings. The diff changes two files:
manifest lines: none apply. critical-findings: 0 |
No related issue: a rollout step of melodic-software/ci-workflows#1138, which stays open until every repository has migrated. ## Summary Rollout of [ci-workflows#1138](melodic-software/ci-workflows#1138): the `ci-status` job now runs the shared `report-ci-status` composite ([ci-workflows#1139](melodic-software/ci-workflows#1139), v0.76.0) instead of its own `check-contract` and `aggregate-results` steps. `CI Status` stays the job's name and the single required check. Worked examples copied: [songwriting#75](melodic-software/songwriting#75) and [codex-plugins#208](melodic-software/codex-plugins#208). Merge after [#1066](#1066), which teaches the fleet pin audit the same pin. ## Fix - `ci-status` steps: one `report-ci-status` step, then a "Fail on the contract or draft policy" step that fails on any outcome other than `success`, so an empty or renamed output fails closed. The composite step keeps the name `Aggregate lane results`, as `step-name` did before. - Behavior kept: - `draft: allow`: the workflow is not draft-gated. - `exempt-authors: 'dependabot[bot]'`. - `treat-skipped-as` at the composite's default `fail`, the value set before. - The job's `if: !cancelled()`, `needs`, permissions, runner and `timeout-minutes: 8` are unchanged. - Concurrency: unchanged; a push already falls back to `github.run_id`. - Comments describe what the composite fixes (`yield-to-full-run: 'true'`, `carry-forward-wait-seconds: '0'`, [action.yml L128-L129](https://github.com/melodic-software/ci-workflows/blob/ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f/.github/actions/pr-require-checks/report-ci-status/action.yml#L128-L129)) instead of inputs the file no longer sets. - `components/commit-convention/commit-convention.test.sh` read the `check-contract@<sha>` pin from this workflow to fetch the `types` default, and would have failed `Check PR Convention Copies` with no such pin. It now accepts the `report-ci-status@<sha>` pin too: that composite runs `check-contract` through `$/` at its own commit, so the test still fetches `check-contract/action.yml` at that SHA. - Lines (`git diff --numstat`): workflow 31 removed, 35 added; `commit-convention.test.sh` 3 removed, 5 added. ## Verification - `actionlint .github/workflows/pr-require-checks.yml`: no findings. - The test's new `sed` on this branch's workflow prints `ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f`; `bash -n` on the test passes. The full test runs in this PR's `Check PR Convention Copies` lane. ## Related - Design and rollout: [ci-workflows#1138](melodic-software/ci-workflows#1138). Pin audit: [#1065](#1065) / [#1066](#1066). - Revert: revert this PR; the old steps come back unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Closes #1065
Summary
The caller-pin audit (
maintenance-audit-pr-convention-pins.yml) found each consumer's contract gate only by a directuses: .../pr-require-checks/check-contract@<sha>call site. Callers on thereport-ci-statuscomposite (ci-workflows#1139, v0.76.0) runcheck-contractthrough$/at the commit they pin, so the scan reported them as running no contract artifact. That covers songwriting#75 and codex-plugins#208, both merged today, ci-workflows' own$/.github/actions/pr-require-checks/report-ci-statuscall, and the rest of the ci-workflows#1138 rollout. The next push tomainor the Wednesday run would have gone red.Fix
components/pr-convention-policy/lockstep-drift.mjs:detectArtifactPinmatches either composite directory,check-contractorreport-ci-status(new exportREPORT_DIRECTORY), in both the pinned form and the local.//$/form. Both resolve tokind: "composite"at the same SHA, so the existing check readscheck-contractat that commit, which is the one that gates.lockstep-drift.test.mjs: cases for a pinnedreport-ci-statuscaller, a$/one, and a commented-out$/one.git diff --numstat): 2 removed, 28 added.Verification
node --test components/pr-convention-policy/lockstep-drift.test.mjs: 96 passed, 0 failed (about 6.5 minutes locally, most of it the hook behavior probes).npm run audit:pr-convention-pins, which needs the standards-sync App token that only amainrun mints. The first push tomainafter merge runs it.Related
commit-convention.test.shchange.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C