Repository navigation
chore: land 4 reviewed pull requests together (batch 83) - #12993
josephfarina wants to merge 10 commits into
Conversation
…read, not left out; its copies stay [skip ci]
…mputer, project and integration skills) [skip ci]
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
/approve-spec c60b47c |
PR Analysis Report🔎 Preview ·
|
There was a problem hiding this comment.
Approved: the withdrawn-docs fix, the docs --help examples, the placed-guide test and the shared SKILL.md renderer all match the CLI skills spec, and the two new unread tests fail without the fix and pass with it.
Two CI jobs are red for reasons outside this change, and they need to pass before this lands: test-node (7/9) fails on the Lab MediaPlayer swizzle sample, which fails the same way on the base, and docsite-build stopped on an npm 404 for the flow-estree 0.341.0 tarball while this pull request changes no manifest or lockfile.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: one doc that fails its checks (such as a flat topic with
aliases) makes the catalog withdraw the package's docs — verified,foundation/discovery/docs-discovery.mjs:288,:366,:1039-1049. - Claim:
initandupgrade --applythen keep that package's skill copies — verified,api/docs/skills/skills.test.mjs:337fails on the base and passes here;initandupgrade --applyruns on the same fixture. - Claim: those skills get one note naming the load instead of a
replacesfix — verified,api/docs/_adapter.mjs:2745-2759,skills.test.mjs:370. - Claim:
astryx docs --helpshowsdocs skillsanddocs skills/astryx— verified,clients/cli/commands/docs.doc.mjs:80-81and the help output. - Claim: the
docscommand reference says whatskillsandskills/<name>read — verified,docs.doc.mjs:30-31. - Claim: the computer, project and integration skills render through one function — verified,
foundation/agent-docs/skill-places.mjs:285-291,:315-321,computer-agent-text.mjs:319-330. - Claim: the files are byte-for-byte unchanged — verified, the same inputs render identically on the base and here.
- Claim: four merges, one per member, in order, with no knowledge record changed — verified from the history and the file list.
- Files:
.changeset/docs-help-skills.md,.changeset/one-skill-file-renderer.md,.changeset/skills-doc-load-unread.md,packages/cli/api/docs/_adapter.mjs,packages/cli/api/docs/skills/skills.mjs,packages/cli/api/docs/skills/skills.test.mjs,packages/cli/clients/cli/commands/docs.doc.mjs,packages/cli/foundation/agent-docs/computer-agent-text.mjs,packages/cli/foundation/agent-docs/computer-agent-text.test.mjs,packages/cli/foundation/agent-docs/managed-skill-file.mjs,packages/cli/foundation/agent-docs/skill-places.mjs,packages/cli/test/__golden__/no-icon-set/manifest.json: all clear.
|
/approve-spec 1777e3e |
Merges four reviewed pull requests onto current main, each as its own
--no-ffmerge, in this order. #12953 → #12954 → #12955 → #12956 form one stack (lands as one). Each member keeps its own description, tests and review history.Scope
Tests: a copy of the main-red fix #13001 (a
lab__MediaPlayerswizzle sample), so this batch's test shards run green on today's main.CLI skills: a skill whose integration has a doc that did not load is reported as unread, not left out (#12953);
astryx docs --helpnames the docs skills (#12954); a skill on a placed guide reads that guide, andinitwrites it (test, #12955); one renderer writes every SKILL.md file Astryx manages (refactor, #12956).Records
None. No member changes a knowledge record.
Writing rubric results
No record changes, so R1–R7 do not apply.
When this merges, each pull request above is closed with a note that names this one.