Skip to content

chore: land 4 reviewed pull requests together (batch 83) - #12993

Open
josephfarina wants to merge 10 commits into
mainfrom
josephfarina/land-batch-83
Open

josephfarina wants to merge 10 commits into
mainfrom
josephfarina/land-batch-83

Conversation

@josephfarina

@josephfarina josephfarina commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Merges four reviewed pull requests onto current main, each as its own --no-ff merge, in this order. #12953 → #12954 → #12955 → #12956 form one stack (lands as one). Each member keeps its own description, tests and review history.

Scope

Tests: a copy of the main-red fix #13001 (a lab__MediaPlayer swizzle sample), so this batch's test shards run green on today's main.

CLI skills: a skill whose integration has a doc that did not load is reported as unread, not left out (#12953); astryx docs --help names the docs skills (#12954); a skill on a placed guide reads that guide, and init writes it (test, #12955); one renderer writes every SKILL.md file Astryx manages (refactor, #12956).

Records

None. No member changes a knowledge record.

Writing rubric results

No record changes, so R1–R7 do not apply.

When this merges, each pull request above is closed with a note that names this one.

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 19, 2026 9:11pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2026
@astracat-bot

astracat-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 19, 2026, 8:58 PM UTC

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec c60b47c

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · c60b47c

Storybook · Sandbox · built from this PR's head

Package size: @astryxdesign/cli 5.68 MB packed (+794 B); no new dependencies.

Not run on this PR: add ci:run-visual for Visual, ci:run-a11y for Accessibility, ci:run-rtl for RTL.

Current run: CI concluded failure; parts of this report may be missing.


Generated by PR Enrichment workflow | View full report

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: the withdrawn-docs fix, the docs --help examples, the placed-guide test and the shared SKILL.md renderer all match the CLI skills spec, and the two new unread tests fail without the fix and pass with it.

Two CI jobs are red for reasons outside this change, and they need to pass before this lands: test-node (7/9) fails on the Lab MediaPlayer swizzle sample, which fails the same way on the base, and docsite-build stopped on an npm 404 for the flow-estree 0.341.0 tarball while this pull request changes no manifest or lockfile.

Claims and files checked

Review mode: full; reason: no-earlier-review

  • Claim: one doc that fails its checks (such as a flat topic with aliases) makes the catalog withdraw the package's docs — verified, foundation/discovery/docs-discovery.mjs:288, :366, :1039-1049.
  • Claim: init and upgrade --apply then keep that package's skill copies — verified, api/docs/skills/skills.test.mjs:337 fails on the base and passes here; init and upgrade --apply runs on the same fixture.
  • Claim: those skills get one note naming the load instead of a replaces fix — verified, api/docs/_adapter.mjs:2745-2759, skills.test.mjs:370.
  • Claim: astryx docs --help shows docs skills and docs skills/astryx — verified, clients/cli/commands/docs.doc.mjs:80-81 and the help output.
  • Claim: the docs command reference says what skills and skills/<name> read — verified, docs.doc.mjs:30-31.
  • Claim: the computer, project and integration skills render through one function — verified, foundation/agent-docs/skill-places.mjs:285-291, :315-321, computer-agent-text.mjs:319-330.
  • Claim: the files are byte-for-byte unchanged — verified, the same inputs render identically on the base and here.
  • Claim: four merges, one per member, in order, with no knowledge record changed — verified from the history and the file list.
  • Files: .changeset/docs-help-skills.md, .changeset/one-skill-file-renderer.md, .changeset/skills-doc-load-unread.md, packages/cli/api/docs/_adapter.mjs, packages/cli/api/docs/skills/skills.mjs, packages/cli/api/docs/skills/skills.test.mjs, packages/cli/clients/cli/commands/docs.doc.mjs, packages/cli/foundation/agent-docs/computer-agent-text.mjs, packages/cli/foundation/agent-docs/computer-agent-text.test.mjs, packages/cli/foundation/agent-docs/managed-skill-file.mjs, packages/cli/foundation/agent-docs/skill-places.mjs, packages/cli/test/__golden__/no-icon-set/manifest.json: all clear.

Automated review (maintainer link)

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 1777e3e

This branch was successfully deployed

1 active deployment
Preview — 1777e3ed Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant