fix(genesis): pass creatorFeeShare in the Raydium fee-collect examples - #570
brandontulsi wants to merge 2 commits into
Conversation
metaplex-foundation/genesis#465 made `creatorFeeShare` a required account on `collectRaydiumCpmmFeesWithCreatorFeeV2`. The 0.43.0 client requires it and the program that checks it is live on mainnet and devnet, so the collect examples no longer compile or land on-chain. - Pass `creatorFeeShare: pdas.creatorFeeShare` in both collect examples - Require `@metaplex-foundation/genesis` 0.43.0 or later - Note the account, the `InvalidRaydiumCreatorFeeShare` (260) and `NotEnoughAccountKeys` failures, and bump `updated` (en/ja/ko/zh)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (4)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Summary by CodeRabbit
WalkthroughThe Genesis creator-fee guides in four locales now specify the ChangesCreator-fee guide
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The four localized guides consistently document the required account and updated collection examples. No material merge risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
metaplex-foundation/genesis#465 added a required
creatorFeeShareaccount tocollectRaydiumCpmmFeesWithCreatorFeeV2. It is Raydium'sCreatorFeeSharePDA, which Raydium's CP-Swap creator-fee-share upgrade takes on every creator-fee collect. The two collect examples on the Creator Fees page don't pass it, so they no longer compile against the current client or succeed on-chain.creatorFeeShare: pdas.creatorFeeSharein both collect examples.deriveRaydiumPDAsV2already returns it.@metaplex-foundation/genesis0.43.0 or later in Prerequisites.deriveRaydiumPDAsV2call asammConfig. A mismatch fails withInvalidRaydiumCreatorFeeShare(260); clients older than 0.43.0 fail withNotEnoughAccountKeys.updated.Why the examples break today
@metaplex-foundation/genesisclientcreatorFeeShareas requiredcreator_fee_sharePDA seedOn 0.43.x the current examples fail to type-check with
Property 'creatorFeeShare' is missing. Run as plain JS, the client puts the Genesis program ID in that slot and the program rejects it withInvalidRaydiumCreatorFeeShare. Clients on 0.42.0 or earlier fail withNotEnoughAccountKeys.Protocol fee tables are unaffected
Raydium's upgrade lets it keep a share of the creator fee when the fee is collected. For Genesis pools that share is 0 today:
creator_fee_share_rateis 0 on all four Genesis AMM configs (mainnet and devnet, creator rewards on and off).CreatorFeeShareoverride exists for the Genesis Raydium signer on either network.If Raydium sets a rate later, the CPMM protocol fee and creator revenue rows (#566) both shrink by that fraction, since Genesis splits whatever Raydium releases.
Testing
@metaplex-foundation/genesis0.43.1 withtsc --strict: they pass, and the versions onmainfail withProperty 'creatorFeeShare' is missing.next dev: the page renders the new code line, Prerequisites line and Notes bullet in en, ja, ko and zh.markdownlint-cli2on the changed pages andvalidate-translationspass.