Skip to content
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
2afe813
refactor: replace hardcoded script call with variable for command exe…
guybartal Feb 4, 2025
79daf00
fix: update command execution to use a temporary script file
guybartal Feb 4, 2025
de04e23
fix: update volume mount path for command script in devcontainer action
guybartal Feb 4, 2025
c383f54
refactor multilines commands in devcontainer
guybartal Feb 5, 2025
4648c25
fix: update script file handling in devcontainer action to use comman…
guybartal Feb 9, 2025
c333d37
feat: add Terraform setup step in build validation workflow
guybartal Feb 9, 2025
05741b8
fix: remove unused prRef input from register_tre_bundle workflow
guybartal Feb 9, 2025
4c3784d
fix: update ref input in register_tre_bundle workflow to use github.ref
guybartal Feb 9, 2025
5f0b312
fix: update devcontainer action to use relative path for command.sh s…
guybartal Feb 9, 2025
5480dc7
fix: add shebang and debug option to command.sh script in devcontaine…
guybartal Feb 9, 2025
d2f8a81
fix: enable debug mode in command.sh execution and update conditional…
guybartal Feb 9, 2025
4015e14
fix: update command.sh script generation to use multiline
guybartal Feb 9, 2025
278c801
test
guybartal Feb 9, 2025
1fb1fa2
fix: update conditional checks in register_tre_bundle workflow to use…
guybartal Feb 9, 2025
e07f845
fix: update conditional checks in register_tre_bundle workflow to use…
guybartal Feb 9, 2025
0d4dfda
fix: update register_tre_bundle workflow to use input variables for b…
guybartal Feb 9, 2025
ba3b5d5
fix: update register_tre_bundle workflow to use input variables for b…
guybartal Feb 9, 2025
ad3b210
Merge branch 'main' into guybartal/fix-run-command-in-devconrainer
guybartal Feb 9, 2025
9c90431
fix: update devcontainer_run_command action to correctly write comman…
guybartal Feb 13, 2025
84e017b
Merge branch 'guybartal/fix-run-command-in-devconrainer' of https://g…
guybartal Feb 13, 2025
a740f0b
fix: simplify bundle registration command in workflow
guybartal Feb 13, 2025
2ef0afd
Merge branch 'main' into guybartal/fix-run-command-in-devconrainer
guybartal Feb 13, 2025
ea5db32
Merge branch 'main' into guybartal/fix-run-command-in-devconrainer
guybartal Mar 3, 2025
00b69d1
set 'latest' tag for devcontainer in register_tre_bundle.yml
guybartal Mar 24, 2025
afdb9eb
Update register_tre_bundle.yml
guybartal Mar 25, 2025
21ecfff
Update deploy_tre_reusable.yml
guybartal Mar 26, 2025
8664716
Merge branch 'main' into guybartal/fix-run-command-in-devconrainer
guybartal Apr 20, 2025
3de46f2
remove whitespace in deploy_tre_reusable.yml
guybartal Apr 23, 2025
317dde8
remove trailing whitespace in register_tre_bundle.yml
guybartal Apr 23, 2025
c4dc69d
fix missing secrets keyword
guybartal Apr 23, 2025
147f865
Remove uneeded props
marrobi Jun 5, 2025
f255a15
Remove uneeded paramaters.
marrobi Jun 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 10 additions & 43 deletions .github/workflows/register_tre_bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ on:
description: The name of the workspace service to register user resources for
type: string
required: false
prRef:
description: The git ref to checkout
type: string
required: false

jobs:
deploy_management:
Expand All @@ -50,7 +46,6 @@ jobs:
echo "prRHeadSha : ${{ github.sha }}"
echo "ciGitRef : ${{ github.ref }}"
echo "environment : ${{ inputs.environmentName || 'CICD'}}"
echo "prRef : ${{ inputs.prRef }}"
echo AAD_TENANT_ID: ${{ secrets.AAD_TENANT_ID }}
echo ACR_NAME: ${{ secrets.ACR_NAME }}
echo API_CLIENT_ID: ${{ secrets.API_CLIENT_ID }}
Expand Down Expand Up @@ -92,21 +87,19 @@ jobs:
echo "Missing secret: AZURE_CREDENTIALS" && exit 1
fi

bundle_name="${{ inputs.bundle_name }}"
bundle_type="${{ inputs.bundle_type }}"
workspace_service_name="${{ inputs.workspace_service_name }}"

# if bundle_name is not set, exit with error
if [ -z "${bundle_name}" ]; then
if [ -z "${{ inputs.bundle_name }}" ]; then
echo "Missing input: bundle_name" && exit 1
fi

if [ -z "${bundle_type}" ]; then
# if bundle_type is not set, exit with error
if [ -z "${{ inputs.bundle_type }}" ]; then
echo "Missing input: bundle_type" && exit 1
fi

if [ $bundle_type = "user_resource" ]; then
if [ -z "${workspace_service_name}" ]; then
# if bundle_type is user_resource, then workspace_service_name is required, if not set, exit with error
if [ "${{ inputs.bundle_type }}" = "user_resource" ]; then
if [ -z "${{ inputs.workspace_service_name }}" ]; then
echo "Missing input: workspace_service_name" && exit 1
fi
fi
Expand All @@ -126,7 +119,7 @@ jobs:
persist-credentials: false
# if the following values are missing (i.e. not triggered via comment workflow)
# then the default checkout will apply
ref: ${{ inputs.prRef }}
ref: ${{ github.ref }}

- name: Set up Docker BuildKit
uses: docker/setup-buildx-action@v3
Expand Down Expand Up @@ -176,7 +169,7 @@ jobs:
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
AZURE_ENVIRONMENT: ${{ vars.AZURE_ENVIRONMENT }}
TRE_ID: ${{ secrets.TRE_ID }}
LOCATION: "uksouth"
LOCATION: ${{ vars.LOCATION }}
ACR_NAME: ${{ secrets.ACR_NAME }}
TERRAFORM_STATE_CONTAINER_NAME: ${{ vars.TERRAFORM_STATE_CONTAINER_NAME }}
MGMT_RESOURCE_GROUP_NAME: ${{ secrets.MGMT_RESOURCE_GROUP_NAME }}
Expand Down Expand Up @@ -234,34 +227,8 @@ jobs:
- name: Register Bundle
uses: ./.github/actions/devcontainer_run_command
with:
COMMAND: |
echo "Starting bundle registration"
bundle_name="${{ inputs.bundle_name }}"
bundle_type="${{ inputs.bundle_type }}"
workspace_service_name="${{ inputs.workspace_service_name }}"

if [ $bundle_type = "workspace" ]; then
echo "Registering workspace bundle $bundle_name of type $bundle_type"
make workspace_bundle BUNDLE="${bundle_name}"
fi

if [ $bundle_type = "workspace_service" ]; then
echo "Registering workspace service bundle $bundle_name of type $bundle_type"
make workspace_service_bundle BUNDLE="${bundle_name}" WORKSPACE_SERVICE="${workspace_service_name}"
fi

if [ $bundle_type = "shared_service" ]; then
echo "Registering shared service bundle $bundle_name of type $bundle_type"
make shared_service_bundle BUNDLE="${bundle_name}"
fi

if [ $bundle_type = "user_resource" ]; then
echo "Registering user resource bundle $bundle_name of type $bundle_type into workspace service $workspace_service_name"
make user_resource_bundle BUNDLE="${bundle_name}" WORKSPACE_SERVICE="${workspace_service_name}"
fi

echo "Finished bundle registration"
DEVCONTAINER_TAG: ${{ needs.prepare-not-main.outputs.refid }}
COMMAND: "make bundle BUNDLE=${{ inputs.bundle_name }} BUNDLE_TYPE=${{ inputs.bundle_type }} WORKSPACE_SERVICE=${{ inputs.workspace_service_name }}"
DEVCONTAINER_TAG: 'latest'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
AZURE_ENVIRONMENT: ${{ vars.AZURE_ENVIRONMENT }}
CI_CACHE_ACR_NAME: ${{ secrets.ACR_NAME}}
Expand Down