Fix for register bundle action#124
Conversation
…d.sh instead of temp file
… checks in register_tre_bundle workflow
… single equals for string comparison
… double quotes for string comparison
…undle registration
|
this PR is blocked and waits for microsoft/AzureTRE#4192 to be released and copied into this repo |
|
Can you revert the original PR so people aren't blocked from using this repo? Then can revisit when the mentioned PR is merged? Thanks. |
I've already reverted it |
|
@guybartal can this be closed, as once microsoft/AzureTRE#4192 is handled it will come across with the next release? |
|
correct @marrobi |
|
reopening this as this holds a fix for register bundle, but should be merged only after microsoft/AzureTRE#4192 is released and copied to this repo |
…ithub.com/guybartal/AzureTRE-Deployment into guybartal/fix-run-command-in-devconrainer
|
refactored and waits now for microsoft/AzureTRE#4372 to be merged instead of microsoft/AzureTRE#4192 |
marrobi
left a comment
There was a problem hiding this comment.
LGTM, couple of comments, should they be fixed upstream?
|
@guybartal where are we with this? |
Do we want to wait for v0.22.0 to be released with my PR? |
|
Has there been any traction on getting this pr pulled in? We are facing similar issues using the register action and are looking to use it to resolve a few problems. |
|
@guybartal is there any reason that this can't be merged? |
|
There was a weird issue with the linter blocking me from merging, shall I force approve ? |
|
That's only for e2e in the main repo. Linting error looks like is a property in the workflow that's not in the child workflow. Will need fixing. I can take a look if that's the only issue. |
Resolves #122
What is being addressed
How is this addressed