Fix dangling [Reset] godoc links in workflow binding - #1085
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Conversation
ExecutorBinding has no Reset method; reset is exposed via TryReset (backed by the ResetFunc field). Point the two doc links at [ExecutorBinding.TryReset] so they resolve.
github-actions
Bot
added
area:workflow
There was a problem hiding this comment.
🟡 Changes recommended
The TryReset documentation still needs an accurate reset-callback reference.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes dangling godoc links in workflow/binding.go by referencing existing reset APIs.
Changes:
- Updates reset-related documentation links.
- References
ExecutorBinding.TryReset.
File summaries
| File | Description |
|---|---|
workflow/binding.go |
Corrects reset-related documentation links. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // TryReset resets this binding if it wraps a shared executor instance. | ||
| // Non-shared bindings are already isolated per session and therefore report | ||
| // success without invoking [ExecutorBinding.Reset]. | ||
| // success without invoking [ExecutorBinding.TryReset]. |
|
Scope: internal-only (doc comment fix) This PR only corrects broken godoc cross-references (comment text) and adds no new/changed exported identifiers or observable behavior. No cross-repo parity review is applicable.
|
Two godoc links in
workflow/binding.goreference a method that doesn't exist:SharedInstancedoc: "…participate in workflow reset checks through[Reset]."TryResetdoc: "…report success without invoking[ExecutorBinding.Reset]."ExecutorBindinghas noResetmethod — reset is exposed viaTryReset(backed by theResetFuncfield). Both links are dangling and don't render. Repointed them at[ExecutorBinding.TryReset]. Doc-only change.