Skip to content

Fix dangling [Reset] godoc links in workflow binding #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PratikDhanave (PratikDhanave) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dangling [Reset] godoc links in workflow binding #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workflow/binding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type ExecutorBinding struct {

// SharedInstance reports whether [NewExecutorFunc] returns a shared executor
// instance rather than creating an independent instance for each session.
// Shared instances participate in workflow reset checks through [Reset]. Keep
// Shared instances participate in workflow reset checks through [ExecutorBinding.TryReset]. Keep
// this value consistent with [NewExecutorFunc]; setting it to false for a
// shared executor opts out of reset checks.
SharedInstance bool
Expand Down Expand Up @@ -84,7 +84,7 @@ func (eb ExecutorBinding) isPlaceholder() bool {

// TryReset resets this binding if it wraps a shared executor instance.
// Non-shared bindings are already isolated per session and therefore report
// success without invoking [ExecutorBinding.Reset].
// success without invoking [ExecutorBinding.TryReset].
func (eb ExecutorBinding) TryReset() bool {
if !eb.SharedInstance {
// Non-shared instances do not need resetting
Expand Down
Loading