Strengthen string enum contract coverage by MGudgin · Pull Request #949 · microsoft/mxc

Gudge (MGudgin) · 2026-08-19T15:24:14Z

This PR changes version-specific string enum tests to derive wire-value coverage from each contract declaration.

Details

Generate canonical, alias, non-string, and externally tagged object checks from string_enum!.
Apply the generated coverage consistently to the published 0.6 and 0.7 contracts and the mutable 0.8 contract.
Remove redundant request-level encoding tests and allow rustfmt to normalize macro invocations.

Tests

cargo fmt --all -- --check
cargo test -p mxc_config_contract (573 tests passed)
cargo clippy -p mxc_config_contract --all-targets -- -D warnings

Microsoft Reviewers: Open in CodeFlow

azure-pipelines · 2026-08-19T15:24:23Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Centralizes string-enum contract testing across published 0.6/0.7 and development 0.8 contracts.

Changes:

Generates canonical, alias, non-string, and externally tagged object tests from string_enum!.
Removes redundant request-level tests.
Enables standard rustfmt formatting for macro invocations.

Show a summary per file

File	Description
`src/core/mxc_config_contract/src/dev/mod.rs`	Adds generated enum tests and formats `Version`.
`src/core/mxc_config_contract/src/dev/experimental.rs`	Formats `TransportProtocol`.
`src/core/mxc_config_contract/src/dev/network.rs`	Formats network enums.
`src/core/mxc_config_contract/src/dev/one_shot.rs`	Formats containment enum.
`src/core/mxc_config_contract/src/dev/stable.rs`	Formats shared stable enums.
`src/core/mxc_config_contract/src/published/v0_6_0_alpha/mod.rs`	Adds generated 0.6 enum tests.
`src/core/mxc_config_contract/src/published/v0_6_0_alpha/network.rs`	Formats network enums.
`src/core/mxc_config_contract/src/published/v0_6_0_alpha/request.rs`	Formats request enums.
`src/core/mxc_config_contract/src/published/v0_7_0_alpha/mod.rs`	Adds generated 0.7 enum tests.
`src/core/mxc_config_contract/src/published/v0_7_0_alpha/network.rs`	Formats network enums.
`src/core/mxc_config_contract/src/published/v0_7_0_alpha/request.rs`	Formats request enums.
`src/core/mxc_config_contract/tests/v0_6_0_alpha/enums.rs`	Removes redundant object-encoding tests.
`src/core/mxc_config_contract/tests/v0_6_0_alpha/root.rs`	Removes redundant version type tests.
`src/core/mxc_config_contract/tests/v0_7_0_alpha/enums.rs`	Removes redundant object-encoding tests.
`src/core/mxc_config_contract/tests/v0_7_0_alpha/root.rs`	Removes redundant version type tests.
`src/core/mxc_config_contract/tests/v0_7_0_alpha/seatbelt.rs`	Removes redundant launch-method type tests.
`src/core/mxc_config_contract/tests/v0_8_0_alpha/enums.rs`	Removes redundant enum encoding tests.
`src/core/mxc_config_contract/tests/v0_8_0_alpha/one_shot.rs`	Removes redundant version type tests.
`src/core/mxc_config_contract/tests/v0_8_0_alpha/seatbelt.rs`	Removes redundant launch-method type tests.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 19/19 changed files
Comments generated: 0
Review effort level: Balanced

This PR adds the Phase 5A review follow-up to the plan's stack record and repoints Phase 6 at the new top of the stack. Details * Record PR #949 as part of stack #948 and note that #909 has merged. * Base Phase 6 on #949 rather than #941, since #949 rewrites the `string_enum!` macros and enum declarations that Phase 6.1 and 6.2 edit. * Point Phase 6.2's schema emission at the post-#949 macro, which already derives test coverage from the same value table. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6126ba9a-a004-486c-86b9-03d9e06db54b

This PR repoints the Phase 7.1.1 line references at the Phase 7 worktree branch and names each characterization test. Details * Correct the production call site, the mutation site, and the test module locations, which were taken from a different branch. * Give every test a proposed name, splitting the quoting coverage into resolved-request cases distinct from the existing intermediate-string tests. * Note that the worktree branch predates the rebased #949 tip, so the numbers move on rebase even though the override machinery is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6126ba9a-a004-486c-86b9-03d9e06db54b

Copilot

Review details

Files reviewed: 19/19 changed files
Comments generated: 0 new
Review effort level: Balanced

Copilot

Review details

Files reviewed: 19/19 changed files
Comments generated: 0 new
Review effort level: Balanced

This PR changes version-specific string enum tests to derive wire-value coverage from each contract declaration. Details * Generate canonical, alias, non-string, and externally tagged object checks from `string_enum!`. * Apply the generated coverage consistently to the published 0.6 and 0.7 contracts and the mutable 0.8 contract. * Remove redundant request-level encoding tests and allow rustfmt to normalize macro invocations. Tests * `cargo fmt --all -- --check` * `cargo test -p mxc_config_contract` (573 tests passed) * `cargo clippy -p mxc_config_contract --all-targets -- -D warnings` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 19/19 changed files
Comments generated: 0 new
Review effort level: Balanced

This PR updates the version-specific parser plan to match the current state of the work: Phase 5 is merged end to end, and the capabilities parity finding is being remediated in the Phase 5 stack rather than on the Phase 6 branch. Details * Mark Phases 5B, 5C, and 5D merged in PRs #910, #929, and #941, and record #949 as retargeted onto main now that the stack beneath it has landed. * Add PR #966 to the Phase 5 status list as the capabilities remediation, and repoint the two "top of the Phase 5 stack" references at it. * Resolve remediation item 2 of the Phase 6 review finding: the ProcessContainerCapability newtype landed, the parse-time versus conversion-time asymmetry is now the accepted state, and the shared-constant and parity-test drift risk is recorded as still open. * Note that the unpushed Phase 6 branch carries a duplicate capabilities commit that must be dropped when it rebases onto the merged stack. Tests * Documentation-only change; no build, lint, or test gate applies. * git diff --check passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2a8e0d88-21dd-48e5-8e44-df2393b8a664

This PR updates the version-specific parser plan for the renaming of Phase 7.1 to Phase 7a, and records where the implementation deliberately diverged from the plan. Details * Retire the 7.1.1.4 post-parse context assertion: the probes reuse the parser's own containment mapping and an exhaustive probe-versus-parser test, so the drift it guarded against is closed at the source. Restate the Phase 9 acceptance criterion as the property rather than the mechanism. * Record that the splice declines rather than errors on a document it cannot transform, so such inputs keep the parser's own message and output routing. * Replace the Phase 7 status commit table with the squashed Phase 7a branch and the steps it covers. * Record #949 as merged, leaving #966 as the one open pull request. Tests * Documentation-only change; no build, lint, or test gate applies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2a8e0d88-21dd-48e5-8e44-df2393b8a664