Move PR head ref to env variable#139
Closed
ShereinDabbah wants to merge 5 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors a GitHub Actions workflow step to move the github.head_ref context variable into an environment variable before using it in the step output.
Key Changes
- Introduces an
envblock to definePR_BRANCHfromgithub.head_ref - Updates the
PR_REFoutput assignment to use the new environment variable instead of the GitHub context directly
Yarovinsky
approved these changes
Jan 5, 2026
Comment on lines
35
to
38
| if: steps.check_changes.outputs.any_changed == 'true' | ||
| id: vars | ||
| run: | | ||
| echo "BASE_REF=${{ github.event.pull_request.base.ref }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
For consistency, the BASE_REF should also be moved to an environment variable, similar to how PR_BRANCH is being set. This would make the code more maintainable and follow a consistent pattern for handling GitHub context variables.
Suggested change
| if: steps.check_changes.outputs.any_changed == 'true' | |
| id: vars | |
| run: | | |
| echo "BASE_REF=${{ github.event.pull_request.base.ref }}" >> $GITHUB_OUTPUT | |
| BASE_REF: ${{ github.event.pull_request.base.ref }} | |
| if: steps.check_changes.outputs.any_changed == 'true' | |
| id: vars | |
| run: | | |
| echo "BASE_REF=$BASE_REF" >> $GITHUB_OUTPUT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.