Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/capabilities-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ jobs:
shell: bash

- name: Determine base ref
env:
PR_BRANCH: ${{ github.head_ref }}
if: steps.check_changes.outputs.any_changed == 'true'
id: vars
run: |
echo "BASE_REF=${{ github.event.pull_request.base.ref }}" >> $GITHUB_OUTPUT
Comment on lines 35 to 38

Copilot AI Jan 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, the BASE_REF should also be moved to an environment variable, similar to how PR_BRANCH is being set. This would make the code more maintainable and follow a consistent pattern for handling GitHub context variables.

Suggested change
if: steps.check_changes.outputs.any_changed == 'true'
id: vars
run: |
echo "BASE_REF=${{ github.event.pull_request.base.ref }}" >> $GITHUB_OUTPUT
BASE_REF: ${{ github.event.pull_request.base.ref }}
if: steps.check_changes.outputs.any_changed == 'true'
id: vars
run: |
echo "BASE_REF=$BASE_REF" >> $GITHUB_OUTPUT

Copilot uses AI. Check for mistakes.
echo "PR_REF=${{ github.head_ref }}" >> $GITHUB_OUTPUT
echo "PR_REF=$PR_BRANCH" >> $GITHUB_OUTPUT
Comment thread
ShereinDabbah marked this conversation as resolved.

- name: Checkout base branch file
if: steps.check_changes.outputs.any_changed == 'true'
Expand All @@ -51,4 +53,4 @@ jobs:
if: steps.check_changes.outputs.any_changed == 'true'
run: |
node ./.github/scripts/check-capabilities-compatibility.js --baseFile=capabilities.base.json --prFile=capabilities.json || exit 1
shell: bash
shell: bash
Loading