[aui]: add new port - #53508
[aui]: add new port#53508
Conversation
…scade failed dependencies
Billy O'Neal (BillyONeal)
left a comment
There was a problem hiding this comment.
Thanks for the new port!
Thanks for the new port, only one nitpick I think needs to be fixed before we can merge it. Couple of issues GPT 5.6 Sol reports:
The
auipublic headers are not usable through direct integration. Declarations useAPI_AUI_*macros that are defined only by the custom CMake targets, so compiling against the installed rootinclude/directory without extra build-system definitions fails.
It's OK for direct-include to not work but it would be nice; e.g. by emitting these somewhere in a shared configure header so that build system bindings aren't necessary to use the component.
The package installs Gradle wrapper JARs under both
platform/anddebug/platform/. Those binaries are Apache-2.0 content, butvcpkg.jsondeclares only MPL-2.0 andportfile.cmakeinstalls only AUI's MPL notice.
This is the only thing to "request changes" over here; I would normally submit a PR against you with a suggested fix but I'm not sure what course of action to take (remove installing those bits or declare the licensing appropriately)
Note to other contributors/reviewers: This is a level of patching we would normally not accept but we have significant contributor for the component making the submission here. That said Saikari (@luadebug) it would be nice if you can get a version out with this stuff fixed at some point.
Generated usage still instructs users to link
oboe::oboe, an Android implementation dependency, rather than an AUI target.
Might be nice to fix this while you're here but not strictly rquired.
| @@ -0,0 +1,89 @@ | |||
| vcpkg_from_github( | |||
| OUT_SOURCE_PATH SOURCE_PATH | |||
| REPO aui-framework/aui | |||
There was a problem hiding this comment.
Review note: The contributor Saikari (@luadebug) contributes here so the usual rules about upstream submission do not apply.
No change requested.
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
The ones github reports as cancelled are running :) |
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.Continue of #53142