Add max total crash limit to stop relaunching persistently failing pr…#1436
Open
kezhangMS wants to merge 1 commit intomicrosoft:mainfrom
Open
Add max total crash limit to stop relaunching persistently failing pr…#1436kezhangMS wants to merge 1 commit intomicrosoft:mainfrom
kezhangMS wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ocesses The existing crash protection only stops relaunching a process if it exits more than 10 times within 60 seconds. This misses the case where a process fails at a slower but persistent rate (e.g. 2 times per minute), which causes it to be relaunched indefinitely. Add a total crash counter (max 20) alongside the existing per-minute rolling window so that persistently failing processes are eventually stopped regardless of crash rate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocesses
The existing crash protection only stops relaunching a process if it
exits more than 10 times within 60 seconds. This misses the case where
a process fails at a slower but persistent rate (e.g. 2 times per
minute), which causes it to be relaunched indefinitely.
Add a total crash counter (max 20) alongside the existing per-minute
rolling window so that persistently failing processes are eventually
stopped regardless of crash rate.