Skip to content

Add max total crash limit to stop relaunching persistently failing pr… #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kezhangMS wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

Add max total crash limit to stop relaunching persistently failing pr… #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions WSLGd/ProcessMonitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ int wslgd::ProcessMonitor::LaunchProcess(

int wslgd::ProcessMonitor::Run() try {
std::map<std::string, std::vector<time_t>> crashes;
std::map<std::string, int> totalCrashes;

constexpr int c_maxCrashesPerMinute = 10;
constexpr int c_maxTotalCrashes = 20;

for (;;) {
// Reap any zombie child processes and re-launch any tracked processes.
Expand Down Expand Up @@ -117,8 +121,13 @@ int wslgd::ProcessMonitor::Run() try {
crashTimestamps.erase(std::remove_if(crashTimestamps.begin(), crashTimestamps.end(), [&](auto ts) { return ts < now - 60; }), crashTimestamps.end());
crashTimestamps.emplace_back(now);

if (crashTimestamps.size() > 10) {
LOG_INFO("%s exited more than 10 times in 60 seconds, not starting it again", cmd.c_str());
auto& totalCrashCount = totalCrashes[cmd];
totalCrashCount++;

if (crashTimestamps.size() > c_maxCrashesPerMinute) {
LOG_INFO("%s exited more than %d times in 60 seconds, not starting it again", cmd.c_str(), c_maxCrashesPerMinute);
} else if (totalCrashCount > c_maxTotalCrashes) {
LOG_INFO("%s exited more than %d times in total, not starting it again", cmd.c_str(), c_maxTotalCrashes);
} else {
LaunchProcess(std::move(found->second.argv), std::move(found->second.capabilities), std::move(found->second.env));
}
Expand Down