Repository navigation
Conversation
ReviewKit now reviews a DOCX by staying or going on that same file: zdanie, then akapit, then rozdział, then całość n times. Comments and text changes land during the walk, including two comments on one zdanie and update/delete of existing comments. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
The całość text change is a tracked replace on the same file. Assert the effective post-change paragraph text, not the raw projection that still shows deleted plus inserted runs. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
mikolaj92
left a comment
There was a problem hiding this comment.
Alfred (Grok Bot) — review COMMENT
Co robi: Walk jednego DOCX in-place: zdanie→akapit→rozdział→całość ze stay-or-go; entry review_docx(path, reviewer). Pack/review_tree nietknięte.
Zgodność: to jest właściwy tor produktowy (ReviewKit review_docx = jedyna ścieżka review; Temida nie chodzi pliku).
Ryzyka:
- Duplikat vs #372 (
review_one_docx/ inne modułydocx_live/stay_or_go) — dwa równoległe API na to samo. Wybierz jeden kontrakt publiczny zanim undraft. - Mergeable: CONFLICTING.
- Docxtor ops: efekty komentarzy/tekstu w
docx_effects— upewnij się, że Word ops idą przez Docxtor pin, nie ad-hoc.
Blocker: konflikt + decyzja #371 vs #372. Draft OK; nie merge.
|
The one-DOCX sentence → paragraph → chapter → whole-body walk is already merged through #373/#374. Merged #375 supplies source-hash-bound physical comment regions and complete chapter/whole-body coverage; this older draft uses obsolete scalar/first-paragraph addressing. Closing the superseded alternative without merging its obsolete implementation. Branch preserved. Disposition is based on independent exact-head source review against main |
A DOCX review walks that same file. It does not review an abstract copy and write a different file at the end.
Order
That walk is the review. README describes it with one mermaid diagram using those four words throughout.
review_docx(path, reviewer)is the entry point. Pack tree name-then-judge (review_tree/TaktReviewer) is unchanged and is not this walk. Temida is not touched.Test
Start from one DOCX; stay on the first zdanie and add two comments before moving to the second; then an akapit pass, a rozdział pass, and more than one pass over całość. Comments and a text change land on that same file during the walk. An existing comment is updated and then deleted.
The 0.24.1 two-scan nested post-order plant (
sequential_scan) still exists for Pack trees; it is not this review.Checks
pytest(except native Takt/Mojo) 511 passed.ruffandmypyclean.