Repository navigation
Conversation
A plugin may hold a companion in plugins/<name>/ as a git submodule. The fetched tree shows it only as a gitlink, so validation passed without seeing the companion and a repeated name went unnoticed. Now each gitlink under plugins/ is resolved through .gitmodules: its url must be https, and the commit it pins must have plugin.mirai at its root with the name of the folder. The companion then counts against repeated names like any other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
Member
|
With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plugin may hold a companion in
plugins/<name>/as a git submodule. The tree thatvalidate.pyfetches shows a submodule only as a gitlinkplugins/<name>, with noplugins/<name>/plugin.miraiin it. So validation passed without seeing the companion, and a repeated name went unnoticed.Now
repository_pluginslooks at each gitlink (mode 160000) directly underplugins/and finds its url in.gitmodulesat the same commit. Then:urlof an entry;plugin.miraiat its root, named like the folder;The README says this under
url.Tested locally:
uv run scripts/validate.pypasses with the current entries.https://github.com/5hif7y/mirai-brush-maps.gitat84f622a, which holds four companions as submodules, it listsbrush_maps, bsp_decompile, map_agent, map_convert, valve220.map_agent.jsonfails withthe plugin map_agent is already in the catalog by plugins/brush_maps.json.plugin.miraihas a different name.🤖 Generated with Claude Code