Repository navigation
Store the edit layers of a terrain one value per assignment - #102
Merged
Merged
Conversation
source_edit_layer_add shifted and set its Grid (320 bytes) and its layer in multiple assignments, which reach LLVM as a whole-aggregate store (odin-lang/Odin#7937) and fail no_store_of_an_aggregate_of_more_than_64_bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96.
Changes
terrain::source_edit_layer_add(plugins/terrain/runtime/edits.odin) shifted the layers up and placed the new one with two multiple assignments of aGrid(f32)(320 bytes) and itsEdit_Layer. They now go one value per assignment, with the marker thatdocs/ODIN_WORKAROUNDS.mdlists for odin-lang/Odin#7937.Tests
mirai test cook/build no_store_of_an_aggregate_of_more_than_64_bytes: passes (it failed onmainb33d9a2 with this site).mirai test plugins/terrain/runtime: 122/122.step.odin:984 resident_owner(), the same onmain. It is not from this change; it has its own issue.🤖 Generated with Claude Code