Skip to content

Store the edit layers of a terrain one value per assignment - #102

Merged
tomaszbk merged 1 commit into
mainfrom
terrain/edit-layer-grid-per-field
Nov 16, 2026
Merged

tomaszbk merged 1 commit into
mainfrom
terrain/edit-layer-grid-per-field

Conversation

@5hif7y

@5hif7y 5hif7y commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closes #96.

Changes

terrain::source_edit_layer_add (plugins/terrain/runtime/edits.odin) shifted the layers up and placed the new one with two multiple assignments of a Grid(f32) (320 bytes) and its Edit_Layer. They now go one value per assignment, with the marker that docs/ODIN_WORKAROUNDS.md lists for odin-lang/Odin#7937.

Tests

  • mirai test cook/build no_store_of_an_aggregate_of_more_than_64_bytes: passes (it failed on main b33d9a2 with this site).
  • mirai test plugins/terrain/runtime: 122/122.
    • It prints a leak of 4.13 KiB in step.odin:984 resident_owner(), the same on main. It is not from this change; it has its own issue.

🤖 Generated with Claude Code

source_edit_layer_add shifted and set its Grid (320 bytes) and its
layer in multiple assignments, which reach LLVM as a whole-aggregate
store (odin-lang/Odin#7937) and fail
no_store_of_an_aggregate_of_more_than_64_bytes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@5hif7y 5hif7y self-assigned this Nov 15, 2026
@5hif7y
5hif7y requested a review from tomaszbk November 15, 2026 23:19
@tomaszbk
tomaszbk merged commit 2225441 into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terrain::source_edit_layer_add stores a 320-byte aggregate at once, which no_store_of_an_aggregate_of_more_than_64_bytes refuses

2 participants